Title: [219039] trunk/Source/WebCore
- Revision
- 219039
- Author
- [email protected]
- Date
- 2017-06-30 20:39:09 -0700 (Fri, 30 Jun 2017)
Log Message
REGRESSION(r214194): Safari leaves a popup window open opened during before unload
https://bugs.webkit.org/show_bug.cgi?id=174016
Reviewed by Chris Dumez.
Address Dan's review comments.
* loader/NavigationDisabler.h:
(WebCore::NavigationDisabler::NavigationDisabler):
(WebCore::NavigationDisabler::~NavigationDisabler):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (219038 => 219039)
--- trunk/Source/WebCore/ChangeLog 2017-07-01 03:35:47 UTC (rev 219038)
+++ trunk/Source/WebCore/ChangeLog 2017-07-01 03:39:09 UTC (rev 219039)
@@ -1,3 +1,16 @@
+2017-06-30 Ryosuke Niwa <[email protected]>
+
+ REGRESSION(r214194): Safari leaves a popup window open opened during before unload
+ https://bugs.webkit.org/show_bug.cgi?id=174016
+
+ Reviewed by Chris Dumez.
+
+ Address Dan's review comments.
+
+ * loader/NavigationDisabler.h:
+ (WebCore::NavigationDisabler::NavigationDisabler):
+ (WebCore::NavigationDisabler::~NavigationDisabler):
+
2017-06-30 Wenson Hsieh <[email protected]>
[iOS DnD] Text indicators for dragged links should always be legible if the link is legible
Modified: trunk/Source/WebCore/loader/NavigationDisabler.h (219038 => 219039)
--- trunk/Source/WebCore/loader/NavigationDisabler.h 2017-07-01 03:35:47 UTC (rev 219038)
+++ trunk/Source/WebCore/loader/NavigationDisabler.h 2017-07-01 03:39:09 UTC (rev 219039)
@@ -35,9 +35,9 @@
: m_frame(frame)
{
if (frame)
- m_frame->mainFrame().m_navigationDisableCount++;
+ ++frame->mainFrame().m_navigationDisableCount;
else // Disable all navigations when destructing a frame-less document.
- s_globalNavigationDisableCount++;
+ ++s_globalNavigationDisableCount;
}
~NavigationDisabler()
@@ -45,10 +45,10 @@
if (m_frame) {
auto& mainFrame = m_frame->mainFrame();
ASSERT(mainFrame.m_navigationDisableCount);
- mainFrame.m_navigationDisableCount--;
+ --mainFrame.m_navigationDisableCount;
} else {
ASSERT(s_globalNavigationDisableCount);
- s_globalNavigationDisableCount--;
+ --s_globalNavigationDisableCount;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
