Title: [219041] trunk/Source/WebInspectorUI
- Revision
- 219041
- Author
- [email protected]
- Date
- 2017-06-30 22:06:40 -0700 (Fri, 30 Jun 2017)
Log Message
Web Inspector: Type token background color in debugger looks poor
https://bugs.webkit.org/show_bug.cgi?id=174063
Patch by Joseph Pecoraro <[email protected]> on 2017-06-30
Reviewed by Devin Rousso.
* UserInterface/Views/TextEditor.css:
CodeMirror widgets do not get range styles like our (.execution-range-highlight).
Make a best effort to carry over the styles to widgets. It isn't perfect, but it
covers all common situations unless a selection ends inside the widget. The
ultimate solution would be to get the expected range styles.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (219040 => 219041)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-07-01 04:53:14 UTC (rev 219040)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-07-01 05:06:40 UTC (rev 219041)
@@ -1,5 +1,18 @@
2017-06-30 Joseph Pecoraro <[email protected]>
+ Web Inspector: Type token background color in debugger looks poor
+ https://bugs.webkit.org/show_bug.cgi?id=174063
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/TextEditor.css:
+ CodeMirror widgets do not get range styles like our (.execution-range-highlight).
+ Make a best effort to carry over the styles to widgets. It isn't perfect, but it
+ covers all common situations unless a selection ends inside the widget. The
+ ultimate solution would be to get the expected range styles.
+
+2017-06-30 Joseph Pecoraro <[email protected]>
+
Web Inspector: Initial search is sometimes performed twice, produces duplicate results
https://bugs.webkit.org/show_bug.cgi?id=174047
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.css (219040 => 219041)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.css 2017-07-01 04:53:14 UTC (rev 219040)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.css 2017-07-01 05:06:40 UTC (rev 219041)
@@ -107,7 +107,8 @@
border-bottom: 1px dotted hsl(78, 18%, 58%);
}
-.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext) {
+.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext),
+.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext) + .CodeMirror-widget {
background-color: hsl(90, 30%, 82%);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
