Title: [219217] trunk
- Revision
- 219217
- Author
- jlew...@apple.com
- Date
- 2017-07-06 14:20:18 -0700 (Thu, 06 Jul 2017)
Log Message
Unreviewed, rolling out r219193.
The tests added with this revision were extreamly flaky on all
platforms.
Reverted changeset:
"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219193
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (219216 => 219217)
--- trunk/LayoutTests/ChangeLog 2017-07-06 21:13:24 UTC (rev 219216)
+++ trunk/LayoutTests/ChangeLog 2017-07-06 21:20:18 UTC (rev 219217)
@@ -1,5 +1,18 @@
2017-07-06 Matt Lewis <jlew...@apple.com>
+ Unreviewed, rolling out r219193.
+
+ The tests added with this revision were extreamly flaky on all
+ platforms.
+
+ Reverted changeset:
+
+ "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+ https://bugs.webkit.org/show_bug.cgi?id=172545
+ http://trac.webkit.org/changeset/219193
+
+2017-07-06 Matt Lewis <jlew...@apple.com>
+
Marked js/slow-stress/Int32Array-alloc-huge.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173010
Deleted: trunk/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt (219216 => 219217)
--- trunk/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt 2017-07-06 21:13:24 UTC (rev 219216)
+++ trunk/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt 2017-07-06 21:20:18 UTC (rev 219217)
@@ -1,3 +0,0 @@
-This test checks that transform animations in SVG elements do not cause the whole SVGDocument to leak.
-
-PASS
Deleted: trunk/LayoutTests/svg/animations/animation-leak-list-property-instances.html (219216 => 219217)
--- trunk/LayoutTests/svg/animations/animation-leak-list-property-instances.html 2017-07-06 21:13:24 UTC (rev 219216)
+++ trunk/LayoutTests/svg/animations/animation-leak-list-property-instances.html 2017-07-06 21:20:18 UTC (rev 219217)
@@ -1,53 +0,0 @@
-<!DOCTYPE html>
-<script>
- function log(message) {
- var logDiv = document.getElementById('log');
- logDiv.appendChild(document.createTextNode(message));
- }
- var originalLiveElements = 0;
-
- function finishTest() {
- GCController.collect();
- var liveDelta = originalLiveElements - window.internals.numberOfLiveNodes();
- if (liveDelta == 4)
- log("PASS");
- else
- log("FAIL: not enough live nodes freed: " + liveDelta + " vs 4 expected");
-
- testRunner.notifyDone();
- }
-
- function continueTest() {
- GCController.collect();
- originalLiveElements = window.internals.numberOfLiveNodes();
- document.getElementById("container").removeChild(document.getElementById("rootSVG"));
- }
-
- function applyTransform(root, id) {
- var svgroot = document.getElementById(root);
- var transformList = document.getElementById(id).transform.baseVal;
- var rotate = svgroot.createSVGTransform();
- rotate.setRotate(10,0,0);
- transformList.appendItem(rotate);
- }
-
- function load() {
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
-
- applyTransform("rootSVG", "rect");
- continueTest();
- finishTest();
- }
-</script>
-
-<body _onload_="load()">
- <p>This test checks that transform animations in SVG elements do not cause the whole SVGDocument to leak.</p>
- <div id="container">
- <svg id="rootSVG" width="300" height="300" xmlns="http://www.w3.org/2000/svg" version="1.1">
- <rect id="rect" x="100" y="100" width="100" height="100" fill="yellow"/>
- </svg>
- </div>
- <div id="log"></div>
-</body>
-
Modified: trunk/Source/WebCore/ChangeLog (219216 => 219217)
--- trunk/Source/WebCore/ChangeLog 2017-07-06 21:13:24 UTC (rev 219216)
+++ trunk/Source/WebCore/ChangeLog 2017-07-06 21:20:18 UTC (rev 219217)
@@ -1,3 +1,16 @@
+2017-07-06 Matt Lewis <jlew...@apple.com>
+
+ Unreviewed, rolling out r219193.
+
+ The tests added with this revision were extreamly flaky on all
+ platforms.
+
+ Reverted changeset:
+
+ "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+ https://bugs.webkit.org/show_bug.cgi?id=172545
+ http://trac.webkit.org/changeset/219193
+
2017-07-06 Zalan Bujtas <za...@apple.com>
Use WTFLogAlways for debug logging so that it shows up in device system logs
Modified: trunk/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h (219216 => 219217)
--- trunk/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h 2017-07-06 21:13:24 UTC (rev 219216)
+++ trunk/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h 2017-07-06 21:20:18 UTC (rev 219217)
@@ -73,8 +73,6 @@
m_baseVal = nullptr;
else if (&property == m_animVal)
m_animVal = nullptr;
- if (!m_baseVal && !m_animVal)
- detachListWrappers(m_values.size());
}
int findItem(SVGProperty* property)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
