Title: [219278] trunk
- Revision
- 219278
- Author
- [email protected]
- Date
- 2017-07-08 16:59:04 -0700 (Sat, 08 Jul 2017)
Log Message
REGRESSION: "visibility:hidden" does not hide play button for video elements
https://bugs.webkit.org/show_bug.cgi?id=174258
<rdar://problem/33181452>
Patch by Antoine Quint <[email protected]> on 2017-07-08
Reviewed by Dean Jackson.
Source/WebCore:
In order to not have most styles from the page affect the shadow root, we set "all: initial" on the
media controls container. However, we need to still make the "visibility" property inherit from its
host such that "visibility: hidden" on the host won't be overridden by setting the property back to
its initial value, which is "visible".
Test: media/modern-media-controls/css/visibility-hidden.html
* Modules/modern-media-controls/controls/media-controls.css:
(.media-controls-container):
LayoutTests:
Add a test that checks that <video controls style="visibility:hidden"> does not render anything.
* media/modern-media-controls/css/visibility-hidden-expected.html: Added.
* media/modern-media-controls/css/visibility-hidden.html: Added.
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (219277 => 219278)
--- trunk/LayoutTests/ChangeLog 2017-07-08 23:11:16 UTC (rev 219277)
+++ trunk/LayoutTests/ChangeLog 2017-07-08 23:59:04 UTC (rev 219278)
@@ -1,3 +1,18 @@
+2017-07-08 Antoine Quint <[email protected]>
+
+ REGRESSION: "visibility:hidden" does not hide play button for video elements
+ https://bugs.webkit.org/show_bug.cgi?id=174258
+ <rdar://problem/33181452>
+
+ Reviewed by Dean Jackson.
+
+ Add a test that checks that <video controls style="visibility:hidden"> does not render anything.
+
+ * media/modern-media-controls/css/visibility-hidden-expected.html: Added.
+ * media/modern-media-controls/css/visibility-hidden.html: Added.
+ * platform/ios-simulator/TestExpectations:
+ * platform/mac/TestExpectations:
+
2017-07-08 Chris Dumez <[email protected]>
Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
Added: trunk/LayoutTests/media/modern-media-controls/css/visibility-hidden.html (0 => 219278)
--- trunk/LayoutTests/media/modern-media-controls/css/visibility-hidden.html (rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/css/visibility-hidden.html 2017-07-08 23:59:04 UTC (rev 219278)
@@ -0,0 +1 @@
+<video controls style="visibility: hidden"></video>
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (219277 => 219278)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-07-08 23:11:16 UTC (rev 219277)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2017-07-08 23:59:04 UTC (rev 219278)
@@ -74,6 +74,7 @@
media/modern-media-controls/buttons-container [ Pass ]
media/modern-media-controls/controls-bar [ Pass ]
media/modern-media-controls/controls-visibility-support [ Pass ]
+media/modern-media-controls/css [ Pass ]
media/modern-media-controls/forward-button [ Pass ]
media/modern-media-controls/fullscreen-button [ Pass ]
media/modern-media-controls/fullscreen-support [ Pass ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (219277 => 219278)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-07-08 23:11:16 UTC (rev 219277)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-07-08 23:59:04 UTC (rev 219278)
@@ -1549,6 +1549,7 @@
media/modern-media-controls/buttons-container [ Pass ]
media/modern-media-controls/controls-bar [ Pass ]
media/modern-media-controls/controls-visibility-support [ Pass ]
+media/modern-media-controls/css [ Pass ]
media/modern-media-controls/forward-button [ Pass ]
media/modern-media-controls/fullscreen-button [ Pass ]
media/modern-media-controls/fullscreen-support [ Pass ]
Modified: trunk/Source/WebCore/ChangeLog (219277 => 219278)
--- trunk/Source/WebCore/ChangeLog 2017-07-08 23:11:16 UTC (rev 219277)
+++ trunk/Source/WebCore/ChangeLog 2017-07-08 23:59:04 UTC (rev 219278)
@@ -1,3 +1,21 @@
+2017-07-08 Antoine Quint <[email protected]>
+
+ REGRESSION: "visibility:hidden" does not hide play button for video elements
+ https://bugs.webkit.org/show_bug.cgi?id=174258
+ <rdar://problem/33181452>
+
+ Reviewed by Dean Jackson.
+
+ In order to not have most styles from the page affect the shadow root, we set "all: initial" on the
+ media controls container. However, we need to still make the "visibility" property inherit from its
+ host such that "visibility: hidden" on the host won't be overridden by setting the property back to
+ its initial value, which is "visible".
+
+ Test: media/modern-media-controls/css/visibility-hidden.html
+
+ * Modules/modern-media-controls/controls/media-controls.css:
+ (.media-controls-container):
+
2017-07-08 Yusuke Suzuki <[email protected]>
Drop NOSNIFF compile flag
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css (219277 => 219278)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css 2017-07-08 23:11:16 UTC (rev 219277)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css 2017-07-08 23:59:04 UTC (rev 219278)
@@ -53,6 +53,7 @@
.media-controls-container {
all: initial;
display: block;
+ visibility: inherit;
position: relative;
will-change: z-index;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
