Title: [219282] trunk/Source/_javascript_Core
- Revision
- 219282
- Author
- [email protected]
- Date
- 2017-07-09 13:19:47 -0700 (Sun, 09 Jul 2017)
Log Message
[Xcode] ICU headers aren’t treated as system headers after r219155
https://bugs.webkit.org/show_bug.cgi?id=174299
Reviewed by Sam Weinig.
* Configurations/_javascript_Core.xcconfig: Pass --system-header-prefix=unicode/ to the C and
C++ compilers.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (219281 => 219282)
--- trunk/Source/_javascript_Core/ChangeLog 2017-07-09 12:22:58 UTC (rev 219281)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-07-09 20:19:47 UTC (rev 219282)
@@ -1,3 +1,18 @@
+2017-07-09 Dan Bernstein <[email protected]>
+
+ [Xcode] ICU headers aren’t treated as system headers after r219155
+ https://bugs.webkit.org/show_bug.cgi?id=174299
+
+ Reviewed by Sam Weinig.
+
+ * Configurations/_javascript_Core.xcconfig: Pass --system-header-prefix=unicode/ to the C and
+ C++ compilers.
+
+* runtime/IntlCollator.cpp: Removed documentation warning suppression.
+ * runtime/IntlDateTimeFormat.cpp: Ditto.
+ * runtime/JSGlobalObject.cpp: Ditto.
+ * runtime/StringPrototype.cpp: Ditto.
+
2017-07-09 Yusuke Suzuki <[email protected]>
[JSC] Use fastMalloc / fastFree for STL containers
Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (219281 => 219282)
--- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2017-07-09 12:22:58 UTC (rev 219281)
+++ trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2017-07-09 20:19:47 UTC (rev 219282)
@@ -47,6 +47,8 @@
GCC_PREFIX_HEADER = _javascript_CorePrefix.h;
GCC_SYMBOLS_PRIVATE_EXTERN = YES;
+OTHER_CFLAGS = $(inherited) --system-header-prefix=unicode/;
+OTHER_CPLUSPLUSFLAGS = $(inherited) --system-header-prefix=unicode/;
HEADER_SEARCH_PATHS = "${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core" $(HEADER_SEARCH_PATHS);
INFOPLIST_FILE = Info.plist;
INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR);
Modified: trunk/Source/_javascript_Core/runtime/IntlCollator.cpp (219281 => 219282)
--- trunk/Source/_javascript_Core/runtime/IntlCollator.cpp 2017-07-09 12:22:58 UTC (rev 219281)
+++ trunk/Source/_javascript_Core/runtime/IntlCollator.cpp 2017-07-09 20:19:47 UTC (rev 219282)
@@ -39,14 +39,7 @@
#include "ObjectConstructor.h"
#include "SlotVisitorInlines.h"
#include "StructureInlines.h"
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdocumentation"
-#endif
#include <unicode/ucol.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
#include <wtf/unicode/Collator.h>
namespace JSC {
Modified: trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp (219281 => 219282)
--- trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp 2017-07-09 12:22:58 UTC (rev 219281)
+++ trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp 2017-07-09 20:19:47 UTC (rev 219282)
@@ -37,14 +37,7 @@
#include "JSCInlines.h"
#include "ObjectConstructor.h"
#include <unicode/ucal.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdocumentation"
-#endif
#include <unicode/udatpg.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
#include <unicode/uenum.h>
#include <wtf/text/StringBuilder.h>
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp (219281 => 219282)
--- trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp 2017-07-09 12:22:58 UTC (rev 219281)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp 2017-07-09 20:19:47 UTC (rev 219282)
@@ -169,14 +169,7 @@
#if ENABLE(INTL)
#include "IntlObject.h"
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdocumentation"
-#endif
#include <unicode/ucol.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
#include <unicode/udat.h>
#include <unicode/unum.h>
#endif // ENABLE(INTL)
Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (219281 => 219282)
--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2017-07-09 12:22:58 UTC (rev 219281)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp 2017-07-09 20:19:47 UTC (rev 219282)
@@ -46,14 +46,7 @@
#include "SuperSampler.h"
#include <algorithm>
#include <unicode/uconfig.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdocumentation"
-#endif
#include <unicode/unorm.h>
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
#include <unicode/ustring.h>
#include <wtf/ASCIICType.h>
#include <wtf/MathExtras.h>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
