Title: [219327] trunk
- Revision
- 219327
- Author
- [email protected]
- Date
- 2017-07-11 06:29:40 -0700 (Tue, 11 Jul 2017)
Log Message
Unreviewed, rolling out r219325.
The test is still flaky
Reverted changeset:
"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219325
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (219326 => 219327)
--- trunk/LayoutTests/ChangeLog 2017-07-11 13:15:33 UTC (rev 219326)
+++ trunk/LayoutTests/ChangeLog 2017-07-11 13:29:40 UTC (rev 219327)
@@ -1,3 +1,15 @@
+2017-07-11 Sergio Villar Senin <[email protected]>
+
+ Unreviewed, rolling out r219325.
+
+ The test is still flaky
+
+ Reverted changeset:
+
+ "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+ https://bugs.webkit.org/show_bug.cgi?id=172545
+ http://trac.webkit.org/changeset/219325
+
2017-07-11 Charlie Turner <[email protected]>
[GTK] media/video-restricted-invisible-autoplay-not-allowed.html is flaky
Deleted: trunk/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt (219326 => 219327)
--- trunk/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt 2017-07-11 13:15:33 UTC (rev 219326)
+++ trunk/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt 2017-07-11 13:29:40 UTC (rev 219327)
@@ -1,7 +0,0 @@
-This test checks that adding an animation to a SVG element does not leak the whole SVGDocument.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS 0 is 0
-
Deleted: trunk/LayoutTests/svg/animations/animation-leak-list-property-instances.html (219326 => 219327)
--- trunk/LayoutTests/svg/animations/animation-leak-list-property-instances.html 2017-07-11 13:15:33 UTC (rev 219326)
+++ trunk/LayoutTests/svg/animations/animation-leak-list-property-instances.html 2017-07-11 13:29:40 UTC (rev 219327)
@@ -1,59 +0,0 @@
-<!DOCTYPE html>
-<script src=""
-
-<body _onload_="test()">
- <svg id="rootSVG" width="300" height="300" xmlns="http://www.w3.org/2000/svg" version="1.1"></svg>
-</body>
-
-<script>
- description("This test checks that adding an animation to a SVG element does not leak the whole SVGDocument.")
-
- function addRect()
- {
- var elem = document.createElementNS("http://www.w3.org/2000/svg", "rect");
- elem.setAttribute("id", "rect");
- elem.setAttribute("x", 50);
- elem.setAttribute("y", 50);
- elem.setAttribute("width", 50);
- elem.setAttribute("height", 50);
- elem.setAttribute("fill", "blue");
-
- document.getElementById("rootSVG").appendChild(elem);
- }
-
- function applyTransform()
- {
- var svgroot = document.getElementById("rootSVG");
- var transformList = document.getElementById("rect").transform.baseVal;
- var rotate = svgroot.createSVGTransform();
- rotate.setRotate(15,0,0);
- transformList.appendItem(rotate);
- }
-
- function removeRect()
- {
- document.getElementById("rootSVG").removeChild(document.getElementById("rect"));
- }
-
- function test()
- {
- if (!window.internals || !window.GCController) {
- testFailed("This test requires internals and GCController");
- return;
- }
-
- testRunner.dumpAsText();
-
- gc();
- var originalLiveElements = internals.numberOfLiveNodes();
-
- addRect();
- applyTransform();
- removeRect();
-
- gc();
- var delta = internals.numberOfLiveNodes() - originalLiveElements;
- shouldBeZero(delta.toString());
- var successfullyParsed = true;
- }
-</script>
Modified: trunk/Source/WebCore/ChangeLog (219326 => 219327)
--- trunk/Source/WebCore/ChangeLog 2017-07-11 13:15:33 UTC (rev 219326)
+++ trunk/Source/WebCore/ChangeLog 2017-07-11 13:29:40 UTC (rev 219327)
@@ -1,3 +1,15 @@
+2017-07-11 Sergio Villar Senin <[email protected]>
+
+ Unreviewed, rolling out r219325.
+
+ The test is still flaky
+
+ Reverted changeset:
+
+ "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+ https://bugs.webkit.org/show_bug.cgi?id=172545
+ http://trac.webkit.org/changeset/219325
+
2017-05-24 Sergio Villar Senin <[email protected]>
[SVG] Leak in SVGAnimatedListPropertyTearOff
Modified: trunk/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h (219326 => 219327)
--- trunk/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h 2017-07-11 13:15:33 UTC (rev 219326)
+++ trunk/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h 2017-07-11 13:29:40 UTC (rev 219327)
@@ -73,8 +73,6 @@
m_baseVal = nullptr;
else if (&property == m_animVal)
m_animVal = nullptr;
- if (!m_baseVal && !m_animVal)
- detachListWrappers(m_values.size());
}
int findItem(SVGProperty* property)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
