Title: [219333] trunk/Source/WebInspectorUI
- Revision
- 219333
- Author
- [email protected]
- Date
- 2017-07-11 09:15:11 -0700 (Tue, 11 Jul 2017)
Log Message
Web Inspector: Node Sidebar - Improve wording for Potential Custom Element lacking a Custom definition
https://bugs.webkit.org/show_bug.cgi?id=174346
Patch by Joseph Pecoraro <[email protected]> on 2017-07-11
Reviewed by Matt Baker.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._customElementState):
The text "Waiting to be upgraded" is poor. Any non-standard element with dashes
in the name is considered custom, but does not need to be upgraded. Lets use
different wording to indicate that it is detected as custom, and lacks a
specific Custom Element definition.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (219332 => 219333)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-07-11 15:34:41 UTC (rev 219332)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-07-11 16:15:11 UTC (rev 219333)
@@ -1,3 +1,18 @@
+2017-07-11 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Node Sidebar - Improve wording for Potential Custom Element lacking a Custom definition
+ https://bugs.webkit.org/show_bug.cgi?id=174346
+
+ Reviewed by Matt Baker.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+ (WebInspector.DOMNodeDetailsSidebarPanel.prototype._customElementState):
+ The text "Waiting to be upgraded" is poor. Any non-standard element with dashes
+ in the name is considered custom, but does not need to be upgraded. Lets use
+ different wording to indicate that it is detected as custom, and lacks a
+ specific Custom Element definition.
+
2017-07-10 Devin Rousso <[email protected]>
Web Inspector: Highlight matching CSS canvas clients when hovering contexts in the Resources tab
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (219332 => 219333)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-07-11 15:34:41 UTC (rev 219332)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2017-07-11 16:15:11 UTC (rev 219333)
@@ -634,7 +634,6 @@
localizedStrings["Partial Garbage Collection"] = "Partial Garbage Collection";
localizedStrings["Passive"] = "Passive";
localizedStrings["Path"] = "Path";
-localizedStrings["Pause Playback"] = "Pause Playback";
localizedStrings["Pause Reason"] = "Pause Reason";
localizedStrings["Pause script execution (%s or %s)"] = "Pause script execution (%s or %s)";
localizedStrings["Ping Frame"] = "Ping Frame";
@@ -812,8 +811,6 @@
localizedStrings["Spread"] = "Spread";
localizedStrings["Spring"] = "Spring";
localizedStrings["Stalled"] = "Stalled";
-localizedStrings["Start Playback"] = "Start Playback";
-localizedStrings["Start Recording"] = "Start Recording";
localizedStrings["Start Time"] = "Start Time";
localizedStrings["Start element selection (%s)"] = "Start element selection (%s)";
localizedStrings["Start recording (%s)\nCreate new recording (%s)"] = "Start recording (%s)\nCreate new recording (%s)";
@@ -899,6 +896,7 @@
localizedStrings["Unchanged"] = "Unchanged";
localizedStrings["Uncomment All Properties"] = "Uncomment All Properties";
localizedStrings["Uncomment rule"] = "Uncomment rule";
+localizedStrings["Undefined custom element"] = "Undefined custom element";
localizedStrings["Unique"] = "Unique";
localizedStrings["Unknown error"] = "Unknown error";
localizedStrings["Unknown node"] = "Unknown node";
@@ -918,7 +916,6 @@
localizedStrings["Vertical"] = "Vertical";
localizedStrings["View variable value"] = "View variable value";
localizedStrings["Visibility"] = "Visibility";
-localizedStrings["Waiting to be upgraded"] = "Waiting to be upgraded";
localizedStrings["Warning: "] = "Warning: ";
localizedStrings["Warnings"] = "Warnings";
localizedStrings["Watch Expressions"] = "Watch Expressions";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (219332 => 219333)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2017-07-11 15:34:41 UTC (rev 219332)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2017-07-11 16:15:11 UTC (rev 219333)
@@ -809,7 +809,7 @@
case WebInspector.DOMNode.CustomElementState.Custom:
return WebInspector.UIString("Custom");
case WebInspector.DOMNode.CustomElementState.Waiting:
- return WebInspector.UIString("Waiting to be upgraded");
+ return WebInspector.UIString("Undefined custom element");
case WebInspector.DOMNode.CustomElementState.Failed:
return WebInspector.UIString("Failed to upgrade");
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
