Modified: trunk/Websites/perf.webkit.org/ChangeLog (219369 => 219370)
--- trunk/Websites/perf.webkit.org/ChangeLog 2017-07-11 22:48:40 UTC (rev 219369)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2017-07-11 22:54:55 UTC (rev 219370)
@@ -1,3 +1,23 @@
+2017-07-11 Ryosuke Niwa <[email protected]>
+
+ Show the roots built by perf try bots on results page
+ https://bugs.webkit.org/show_bug.cgi?id=174305
+
+ Reviewed by Joseph Pecoraro.
+
+ Show build products created by a perf try bots so that we can download them for local testing.
+
+ * public/v3/components/test-group-revision-table.js:
+ (TestGroupRevisionTable.prototype._renderTable): Find the set of repositories for which a patch is applied.
+ Show build products for all commit sets for such a repository since when WebKit is built with a patch in
+ one configuration, the other configuration also needs to be built for consistency.
+ (TestGroupRevisionTable.prototype._buildCommitCell): Added the hyperlink for build products.
+ (TestGroupRevisionTable.prototype._buildFileInfo): Takes a string to override the file's label. Since all
+ build products made by bots tend to have the same filename, we show the label of "Build product" instead.
+ (TestGroupRevisionTable.prototype._mergeCellsWithSameCommitsAcrossRows): Fixed a bug that any entry with
+ a patch wasn't getting merged since it was comparing against the result commit set, which does not contain
+ the patch (only requested commit set contains a patch).
+
2017-07-10 Ryosuke Niwa <[email protected]>
Address Antti's review comment.
Modified: trunk/Websites/perf.webkit.org/public/v3/components/test-group-revision-table.js (219369 => 219370)
--- trunk/Websites/perf.webkit.org/public/v3/components/test-group-revision-table.js 2017-07-11 22:48:40 UTC (rev 219369)
+++ trunk/Websites/perf.webkit.org/public/v3/components/test-group-revision-table.js 2017-07-11 22:54:55 UTC (rev 219370)
@@ -34,9 +34,13 @@
const requestedRepositorySet = new Set;
const additionalRepositorySet = new Set;
+ const patchedPepositorySet = new Set;
for (const commitSet of commitSets) {
- for (const repository of commitSet.repositories())
+ for (const repository of commitSet.repositories()) {
requestedRepositorySet.add(repository);
+ if (commitSet.patchForRepository(repository))
+ patchedPepositorySet.add(repository);
+ }
}
const rowEntries = [];
@@ -99,7 +103,7 @@
const request = entry.request;
return element('tr', [
entry.groupHeader ? element('td', {rowspan: entry.groupRowCount}, entry.groupHeader) : [],
- requestedRepositoryList.map((repository) => this._buildCommitCell(entry, repository)),
+ requestedRepositoryList.map((repository) => this._buildCommitCell(entry, repository, patchedPepositorySet.has(repository))),
hasCustomRoots ? this._buildCustomRootsCell(entry) : [],
element('td', entry.label),
element('td', request.statusUrl() ? link(request.statusLabel(), request.statusUrl()) : request.statusLabel()),
@@ -108,7 +112,7 @@
}))]);
}
- _buildCommitCell(entry, repository)
+ _buildCommitCell(entry, repository, showRoot = false)
{
const element = ComponentBase.createElement;
const link = ComponentBase.createLink;
@@ -117,16 +121,18 @@
return [];
const commit = entry.commitSet.commitForRepository(repository);
- let content = '';
- if (commit) {
- content = commit.label();
- if (commit.url())
- content = link(content, commit.url());
- }
+ let content = [];
+ if (commit)
+ content = commit.url() ? [link(commit.label(), commit.url())] : [commit.label()];
const patch = entry.requestedCommitSet.patchForRepository(repository);
if (patch)
- content = [content, ' with ', this._buildFileInfo(patch)];
+ content.push(' with ', this._buildFileInfo(patch));
+ if (showRoot) {
+ const root = entry.requestedCommitSet.rootForRepository(repository);
+ if (root)
+ content.push(' (', this._buildFileInfo(root, 'Build product') ,')');
+ }
return element('td', {rowspan: entry.rowCountByRepository.get(repository)}, content);
}
@@ -147,14 +153,15 @@
}).map((content) => element('li', content))));
}
- _buildFileInfo(file)
+ _buildFileInfo(file, labelOverride = null)
{
const element = ComponentBase.createElement;
const link = ComponentBase.createLink;
+ let label = labelOverride || file.label();
if (file.deletedAt())
- return [file.label(), ' ', element('span', {class: 'purged'}, '(Purged)')];
- return link(file.label(), file.url());
+ return [label, ' ', element('span', {class: 'purged'}, '(Purged)')];
+ return link(label, file.url());
}
_mergeCellsWithSameCommitsAcrossRows(rowEntries)
@@ -165,12 +172,12 @@
if (entry.repositoriesToSkip.has(repository))
continue;
const commit = entry.commitSet.commitForRepository(repository);
- const patch = entry.commitSet.patchForRepository(repository);
+ const patch = entry.requestedCommitSet.patchForRepository(repository);
let rowCount = 1;
for (let otherRowIndex = rowIndex + 1; otherRowIndex < rowEntries.length; otherRowIndex++) {
const otherEntry = rowEntries[otherRowIndex];
const otherCommit = otherEntry.commitSet.commitForRepository(repository);
- const otherPatch = otherEntry.commitSet.patchForRepository(repository);
+ const otherPatch = otherEntry.requestedCommitSet.patchForRepository(repository);
if (commit != otherCommit || patch != otherPatch)
break;
otherEntry.repositoriesToSkip.add(repository);
