Title: [219380] trunk/Websites/perf.webkit.org
Revision
219380
Author
[email protected]
Date
2017-07-11 19:38:03 -0700 (Tue, 11 Jul 2017)

Log Message

Build fix. It looks like the code here is racy.

* public/v3/components/chart-pane-base.js:
(ChartPaneBase.prototype.configure):
(ChartPaneBase.prototype.setOpenRepository):

Modified Paths

Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (219379 => 219380)


--- trunk/Websites/perf.webkit.org/ChangeLog	2017-07-12 02:18:48 UTC (rev 219379)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2017-07-12 02:38:03 UTC (rev 219380)
@@ -1,5 +1,13 @@
 2017-07-11  Ryosuke Niwa  <[email protected]>
 
+        Build fix. It looks like the code here is racy.
+
+        * public/v3/components/chart-pane-base.js:
+        (ChartPaneBase.prototype.configure):
+        (ChartPaneBase.prototype.setOpenRepository):
+
+2017-07-11  Ryosuke Niwa  <[email protected]>
+
         Show the roots built by perf try bots on results page
         https://bugs.webkit.org/show_bug.cgi?id=174305
 

Modified: trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js (219379 => 219380)


--- trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js	2017-07-12 02:18:48 UTC (rev 219379)
+++ trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js	2017-07-12 02:38:03 UTC (rev 219380)
@@ -57,6 +57,7 @@
         this._revisionRange = new ChartRevisionRange(this._mainChart);
 
         this._mainChartStatus = new ChartPaneStatusView(result.metric, this._mainChart);
+        this._mainChartStatus.setCurrentRepository(this._openRepository);
         this._mainChartStatus.listenToAction('openRepository', this.openNewRepository.bind(this));
         this.renderReplace(this.content().querySelector('.chart-pane-details'), this._mainChartStatus);
 
@@ -132,7 +133,8 @@
     setOpenRepository(repository)
     {
         this._openRepository = repository;
-        this._mainChartStatus.setCurrentRepository(repository);
+        if (this._mainChartStatus)
+            this._mainChartStatus.setCurrentRepository(repository);
         this._updateCommitLogViewer();
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to