Title: [219517] trunk/Source/WebCore
- Revision
- 219517
- Author
- [email protected]
- Date
- 2017-07-14 12:34:33 -0700 (Fri, 14 Jul 2017)
Log Message
Increase CoreAudio render audio buffer sizes for WebRTC
https://bugs.webkit.org/show_bug.cgi?id=174508
Patch by Youenn Fablet <[email protected]> on 2017-07-14
Reviewed by Eric Carlson.
Covered by manually testing audio rendering through WebRTC sites.
* platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
(WebCore::AudioTrackPrivateMediaStreamCocoa::createAudioUnit): Setting audio buffer size equivalent to 20 ms.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (219516 => 219517)
--- trunk/Source/WebCore/ChangeLog 2017-07-14 19:16:40 UTC (rev 219516)
+++ trunk/Source/WebCore/ChangeLog 2017-07-14 19:34:33 UTC (rev 219517)
@@ -1,3 +1,15 @@
+2017-07-14 Youenn Fablet <[email protected]>
+
+ Increase CoreAudio render audio buffer sizes for WebRTC
+ https://bugs.webkit.org/show_bug.cgi?id=174508
+
+ Reviewed by Eric Carlson.
+
+ Covered by manually testing audio rendering through WebRTC sites.
+
+ * platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
+ (WebCore::AudioTrackPrivateMediaStreamCocoa::createAudioUnit): Setting audio buffer size equivalent to 20 ms.
+
2017-07-14 Brady Eidson <[email protected]>
Make sure all CFHTTPCookieStorageRefs we create are scheduled.
Modified: trunk/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp (219516 => 219517)
--- trunk/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp 2017-07-14 19:16:40 UTC (rev 219516)
+++ trunk/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp 2017-07-14 19:34:33 UTC (rev 219517)
@@ -38,8 +38,6 @@
namespace WebCore {
-const int renderBufferSize = 128;
-
AudioTrackPrivateMediaStreamCocoa::AudioTrackPrivateMediaStreamCocoa(MediaStreamTrackPrivate& track)
: AudioTrackPrivateMediaStream(track)
{
@@ -163,7 +161,7 @@
return nullptr;
}
- AudioSession::sharedSession().setPreferredBufferSize(renderBufferSize);
+ AudioSession::sharedSession().setPreferredBufferSize(AudioSession::sharedSession().sampleRate() / 50);
return remoteIOUnit;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
