Title: [219604] trunk/Source/WebKit
- Revision
- 219604
- Author
- [email protected]
- Date
- 2017-07-17 23:28:58 -0700 (Mon, 17 Jul 2017)
Log Message
Web Automation: link and partial link queries don't work if text link contains trailing or leading whitespaces
https://bugs.webkit.org/show_bug.cgi?id=174499
Reviewed by Brian Burg.
This is causing test test_Driver_Can_Get_Link_By_Link_Test_Ignoring_Trailing_Whitespace to fail.
* UIProcess/Automation/atoms/FindNodes.js:
(switch): Use normalize-space() in in the links xpath expressions.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (219603 => 219604)
--- trunk/Source/WebKit/ChangeLog 2017-07-18 05:57:00 UTC (rev 219603)
+++ trunk/Source/WebKit/ChangeLog 2017-07-18 06:28:58 UTC (rev 219604)
@@ -1,3 +1,15 @@
+2017-07-17 Carlos Garcia Campos <[email protected]>
+
+ Web Automation: link and partial link queries don't work if text link contains trailing or leading whitespaces
+ https://bugs.webkit.org/show_bug.cgi?id=174499
+
+ Reviewed by Brian Burg.
+
+ This is causing test test_Driver_Can_Get_Link_By_Link_Test_Ignoring_Trailing_Whitespace to fail.
+
+ * UIProcess/Automation/atoms/FindNodes.js:
+ (switch): Use normalize-space() in in the links xpath expressions.
+
2017-07-17 Darin Adler <[email protected]>
Improve use of NeverDestroyed
Modified: trunk/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js (219603 => 219604)
--- trunk/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js 2017-07-18 05:57:00 UTC (rev 219603)
+++ trunk/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js 2017-07-18 06:28:58 UTC (rev 219604)
@@ -37,11 +37,11 @@
break;
case "link text":
strategy = "xpath";
- query = ".//a[@href][descendant-or-self::text() = \"" + escape(query) + "\"]";
+ query = ".//a[@href][normalize-space(descendant-or-self::text()) = \"" + escape(query) + "\"]";
break;
case "partial link text":
strategy = "xpath";
- query = ".//a[@href][contains(descendant-or-self::text(), \"" + escape(query) + "\")]";
+ query = ".//a[@href][contains(normalize-space(descendant-or-self::text()), \"" + escape(query) + "\")]";
break;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
