Title: [219642] trunk
- Revision
- 219642
- Author
- [email protected]
- Date
- 2017-07-18 16:54:44 -0700 (Tue, 18 Jul 2017)
Log Message
Align quirky number parsing with other browsers
https://bugs.webkit.org/show_bug.cgi?id=155874
Patch by Ali Juma <[email protected]> on 2017-07-18
Reviewed by Simon Fraser.
Source/WebCore:
Parse unit-less non-zero values for animation-duration and transition-duration
as invalid time values in quirks mode.
Test: fast/css/animation-transition-duration-quirksmode.html
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeAnimationValue):
LayoutTests:
* animations/animation-add-events-in-handler.html:
* fast/css/animation-transition-duration-quirksmode-expected.txt: Added.
* fast/css/animation-transition-duration-quirksmode.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (219641 => 219642)
--- trunk/LayoutTests/ChangeLog 2017-07-18 23:32:58 UTC (rev 219641)
+++ trunk/LayoutTests/ChangeLog 2017-07-18 23:54:44 UTC (rev 219642)
@@ -1,3 +1,14 @@
+2017-07-18 Ali Juma <[email protected]>
+
+ Align quirky number parsing with other browsers
+ https://bugs.webkit.org/show_bug.cgi?id=155874
+
+ Reviewed by Simon Fraser.
+
+ * animations/animation-add-events-in-handler.html:
+ * fast/css/animation-transition-duration-quirksmode-expected.txt: Added.
+ * fast/css/animation-transition-duration-quirksmode.html: Added.
+
2017-07-18 Joseph Pecoraro <[email protected]>
Web Inspector: Modernize InjectedScriptSource
Modified: trunk/LayoutTests/animations/animation-add-events-in-handler.html (219641 => 219642)
--- trunk/LayoutTests/animations/animation-add-events-in-handler.html 2017-07-18 23:32:58 UTC (rev 219641)
+++ trunk/LayoutTests/animations/animation-add-events-in-handler.html 2017-07-18 23:54:44 UTC (rev 219642)
@@ -34,7 +34,7 @@
.padding {
-webkit-animation-name: keyframes;
-webkit-animation-iteration-count: infinite;
- -webkit-animation-duration: 0.001;
+ -webkit-animation-duration: 0.001ms;
}
</style>
<div id="results">
Added: trunk/LayoutTests/fast/css/animation-transition-duration-quirksmode-expected.txt (0 => 219642)
--- trunk/LayoutTests/fast/css/animation-transition-duration-quirksmode-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/animation-transition-duration-quirksmode-expected.txt 2017-07-18 23:54:44 UTC (rev 219642)
@@ -0,0 +1,4 @@
+
+PASS Unit-less non-zero animation-duration should be invalid
+PASS Unit-less non-zero transition-duration should be invalid
+
Added: trunk/LayoutTests/fast/css/animation-transition-duration-quirksmode.html (0 => 219642)
--- trunk/LayoutTests/fast/css/animation-transition-duration-quirksmode.html (rev 0)
+++ trunk/LayoutTests/fast/css/animation-transition-duration-quirksmode.html 2017-07-18 23:54:44 UTC (rev 219642)
@@ -0,0 +1,20 @@
+<html>
+<head>
+<script src=""
+<script src=""
+</head>
+<body>
+<div id="test"></div>
+<script>
+ var element = document.getElementById("test");
+ test(function() {
+ element.style.animationDuration = "3";
+ assert_equals(element.style.animationDuration, "");
+ }, "Unit-less non-zero animation-duration should be invalid")
+ test(function() {
+ element.style.transitionDuration = "3";
+ assert_equals(element.style.transitionDuration, "");
+ }, "Unit-less non-zero transition-duration should be invalid")
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (219641 => 219642)
--- trunk/Source/WebCore/ChangeLog 2017-07-18 23:32:58 UTC (rev 219641)
+++ trunk/Source/WebCore/ChangeLog 2017-07-18 23:54:44 UTC (rev 219642)
@@ -1,3 +1,18 @@
+2017-07-18 Ali Juma <[email protected]>
+
+ Align quirky number parsing with other browsers
+ https://bugs.webkit.org/show_bug.cgi?id=155874
+
+ Reviewed by Simon Fraser.
+
+ Parse unit-less non-zero values for animation-duration and transition-duration
+ as invalid time values in quirks mode.
+
+ Test: fast/css/animation-transition-duration-quirksmode.html
+
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::consumeAnimationValue):
+
2017-07-18 Chris Dumez <[email protected]>
HysteresisActivity cannot be used in the UIProcess
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (219641 => 219642)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2017-07-18 23:32:58 UTC (rev 219641)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2017-07-18 23:54:44 UTC (rev 219642)
@@ -1603,7 +1603,7 @@
return consumeIdent<CSSValueNormal, CSSValueAlternate, CSSValueReverse, CSSValueAlternateReverse>(range);
case CSSPropertyAnimationDuration:
case CSSPropertyTransitionDuration:
- return consumeTime(range, context.mode, ValueRangeNonNegative, UnitlessQuirk::Allow);
+ return consumeTime(range, context.mode, ValueRangeNonNegative, UnitlessQuirk::Forbid);
case CSSPropertyAnimationFillMode:
return consumeIdent<CSSValueNone, CSSValueForwards, CSSValueBackwards, CSSValueBoth>(range);
case CSSPropertyAnimationIterationCount:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
