Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (219647 => 219648)
--- trunk/Source/_javascript_Core/ChangeLog 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1,3 +1,18 @@
+2017-07-18 Andy Estes <[email protected]>
+
+ [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
+ https://bugs.webkit.org/show_bug.cgi?id=174631
+
+ Reviewed by Tim Horton.
+
+ * Configurations/Base.xcconfig:
+ * b3/B3FoldPathConstants.cpp:
+ * b3/B3LowerMacros.cpp:
+ * b3/air/AirAllocateRegistersByGraphColoring.cpp:
+ * dfg/DFGByteCodeParser.cpp:
+ (JSC::DFG::ByteCodeParser::check):
+ (JSC::DFG::ByteCodeParser::planLoad):
+
2017-07-18 Yusuke Suzuki <[email protected]>
WTF::Thread should have the threads stack bounds.
Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -42,6 +42,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COMBINE_HIDPI_IMAGES = NO;
Modified: trunk/Source/_javascript_Core/b3/B3FoldPathConstants.cpp (219647 => 219648)
--- trunk/Source/_javascript_Core/b3/B3FoldPathConstants.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/_javascript_Core/b3/B3FoldPathConstants.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -103,11 +103,11 @@
SwitchValue* switchValue = branch->as<SwitchValue>();
HashMap<BasicBlock*, unsigned> targetUses;
- for (const SwitchCase& switchCase : switchValue->cases(block))
+ for (SwitchCase switchCase : switchValue->cases(block))
targetUses.add(switchCase.targetBlock(), 0).iterator->value++;
targetUses.add(switchValue->fallThrough(block), 0).iterator->value++;
- for (const SwitchCase& switchCase : switchValue->cases(block)) {
+ for (SwitchCase switchCase : switchValue->cases(block)) {
if (targetUses.find(switchCase.targetBlock())->value != 1)
continue;
Modified: trunk/Source/_javascript_Core/b3/B3LowerMacros.cpp (219647 => 219648)
--- trunk/Source/_javascript_Core/b3/B3LowerMacros.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/_javascript_Core/b3/B3LowerMacros.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -180,7 +180,7 @@
case Switch: {
SwitchValue* switchValue = m_value->as<SwitchValue>();
Vector<SwitchCase> cases;
- for (const SwitchCase& switchCase : switchValue->cases(m_block))
+ for (SwitchCase switchCase : switchValue->cases(m_block))
cases.append(switchCase);
std::sort(
cases.begin(), cases.end(),
Modified: trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersByGraphColoring.cpp (219647 => 219648)
--- trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersByGraphColoring.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersByGraphColoring.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1653,7 +1653,7 @@
}
};
- for (const Tmp& liveTmp : localCalc.live())
+ for (Tmp liveTmp : localCalc.live())
considerEdge(liveTmp);
for (const Tmp& pinnedRegTmp : m_pinnedRegs)
considerEdge(pinnedRegTmp);
@@ -1699,7 +1699,7 @@
if (argBank != bank)
return;
- for (const Tmp& liveTmp : liveTmps) {
+ for (Tmp liveTmp : liveTmps) {
ASSERT(liveTmp.isGP() == (bank == GP));
if (traceDebug)
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (219647 => 219648)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -3492,7 +3492,7 @@
bool ByteCodeParser::check(const ObjectPropertyConditionSet& conditionSet)
{
- for (const ObjectPropertyCondition condition : conditionSet) {
+ for (const ObjectPropertyCondition& condition : conditionSet) {
if (!check(condition))
return false;
}
@@ -3505,7 +3505,7 @@
dataLog("conditionSet = ", conditionSet, "\n");
GetByOffsetMethod result;
- for (const ObjectPropertyCondition condition : conditionSet) {
+ for (const ObjectPropertyCondition& condition : conditionSet) {
switch (condition.kind()) {
case PropertyCondition::Presence:
RELEASE_ASSERT(!result); // Should only see exactly one of these.
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (219647 => 219648)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1,5 +1,14 @@
2017-07-18 Andy Estes <[email protected]>
+ [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
+ https://bugs.webkit.org/show_bug.cgi?id=174631
+
+ Reviewed by Tim Horton.
+
+ * Configurations/Base.xcconfig:
+
+2017-07-18 Andy Estes <[email protected]>
+
[Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
https://bugs.webkit.org/show_bug.cgi?id=174631
Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -17,6 +17,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
Modified: trunk/Source/WTF/ChangeLog (219647 => 219648)
--- trunk/Source/WTF/ChangeLog 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WTF/ChangeLog 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1,3 +1,12 @@
+2017-07-18 Andy Estes <[email protected]>
+
+ [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
+ https://bugs.webkit.org/show_bug.cgi?id=174631
+
+ Reviewed by Tim Horton.
+
+ * Configurations/Base.xcconfig:
+
2017-07-18 Yusuke Suzuki <[email protected]>
WTF::Thread should have the threads stack bounds.
Modified: trunk/Source/WTF/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Source/WTF/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WTF/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -42,6 +42,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Modified: trunk/Source/WebCore/ChangeLog (219647 => 219648)
--- trunk/Source/WebCore/ChangeLog 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebCore/ChangeLog 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1,3 +1,18 @@
+2017-07-18 Andy Estes <[email protected]>
+
+ [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
+ https://bugs.webkit.org/show_bug.cgi?id=174631
+
+ Reviewed by Tim Horton.
+
+ * Configurations/Base.xcconfig:
+ * rendering/Grid.cpp:
+ (WebCore::Grid::insert):
+ * rendering/RenderTreeAsText.cpp:
+ (WebCore::write):
+ * rendering/SimpleLineLayoutCoverage.cpp:
+ (WebCore::SimpleLineLayout::printSimpleLineLayoutCoverage):
+
2017-07-18 Yusuke Suzuki <[email protected]>
WTF::Thread should have the threads stack bounds.
Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Source/WebCore/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -42,6 +42,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Modified: trunk/Source/WebCore/PAL/ChangeLog (219647 => 219648)
--- trunk/Source/WebCore/PAL/ChangeLog 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebCore/PAL/ChangeLog 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1,5 +1,14 @@
2017-07-18 Andy Estes <[email protected]>
+ [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
+ https://bugs.webkit.org/show_bug.cgi?id=174631
+
+ Reviewed by Tim Horton.
+
+ * Configurations/Base.xcconfig:
+
+2017-07-18 Andy Estes <[email protected]>
+
[Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
https://bugs.webkit.org/show_bug.cgi?id=174631
Modified: trunk/Source/WebCore/PAL/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Source/WebCore/PAL/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebCore/PAL/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -42,6 +42,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Modified: trunk/Source/WebCore/rendering/Grid.cpp (219647 => 219648)
--- trunk/Source/WebCore/rendering/Grid.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebCore/rendering/Grid.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -66,8 +66,8 @@
ASSERT(area.rows.isTranslatedDefinite() && area.columns.isTranslatedDefinite());
ensureGridSize(area.rows.endLine(), area.columns.endLine());
- for (const auto& row : area.rows) {
- for (const auto& column : area.columns)
+ for (auto row : area.rows) {
+ for (auto column : area.columns)
m_grid[row][column].append(&child);
}
Modified: trunk/Source/WebCore/rendering/RenderTreeAsText.cpp (219647 => 219648)
--- trunk/Source/WebCore/rendering/RenderTreeAsText.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebCore/rendering/RenderTreeAsText.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -571,7 +571,7 @@
if (auto layout = text.simpleLineLayout()) {
ASSERT(!text.firstTextBox());
auto resolver = runResolver(downcast<RenderBlockFlow>(*text.parent()), *layout);
- for (const auto& run : resolver.rangeForRenderer(text)) {
+ for (auto run : resolver.rangeForRenderer(text)) {
writeIndent(ts, indent + 1);
writeSimpleLine(ts, text, run);
}
Modified: trunk/Source/WebCore/rendering/SimpleLineLayoutCoverage.cpp (219647 => 219648)
--- trunk/Source/WebCore/rendering/SimpleLineLayoutCoverage.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebCore/rendering/SimpleLineLayoutCoverage.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -351,7 +351,7 @@
stream << "---------------------------------------------------\n";
stream << "Number of blocks: total(" << leafRenderers.size() << ") non-simple(" << numberOfUnsupportedLeafBlocks << ")\nContent length: total(" <<
textLength << ") non-simple(" << unsupportedTextLength << ")\n";
- for (const auto reasonEntry : flowStatistics) {
+ for (const auto& reasonEntry : flowStatistics) {
printReason(reasonEntry.key, stream);
stream << ": " << (float)reasonEntry.value / (float)textLength * 100 << "%\n";
}
Modified: trunk/Source/WebInspectorUI/ChangeLog (219647 => 219648)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1,5 +1,14 @@
2017-07-18 Andy Estes <[email protected]>
+ [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
+ https://bugs.webkit.org/show_bug.cgi?id=174631
+
+ Reviewed by Tim Horton.
+
+ * Configurations/Base.xcconfig:
+
+2017-07-18 Andy Estes <[email protected]>
+
[Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
https://bugs.webkit.org/show_bug.cgi?id=174631
Modified: trunk/Source/WebInspectorUI/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Source/WebInspectorUI/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebInspectorUI/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -23,6 +23,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
ENABLE_STRICT_OBJC_MSGSEND = YES;
Modified: trunk/Source/WebKit/ChangeLog (219647 => 219648)
--- trunk/Source/WebKit/ChangeLog 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebKit/ChangeLog 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1,5 +1,26 @@
2017-07-18 Andy Estes <[email protected]>
+ [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
+ https://bugs.webkit.org/show_bug.cgi?id=174631
+
+ Reviewed by Tim Horton.
+
+ * Configurations/Base.xcconfig:
+ * Shared/API/APIArray.cpp:
+ (API::Array::toStringVector):
+ * UIProcess/Plugins/PlugInAutoStartProvider.cpp:
+ (WebKit::PlugInAutoStartProvider::setAutoStartOriginsArray):
+ * UIProcess/UserContent/WebUserContentControllerProxy.cpp:
+ (WebKit::WebUserContentControllerProxy::addProcess):
+ (WebKit::WebUserContentControllerProxy::removeAllUserScripts):
+ (WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
+ * UIProcess/ios/forms/WKFileUploadPanel.mm:
+ (-[WKFileUploadPanel presentWithParameters:resultListener:]):
+ * WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
+ (WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):
+
+2017-07-18 Andy Estes <[email protected]>
+
[Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
https://bugs.webkit.org/show_bug.cgi?id=174631
Modified: trunk/Source/WebKit/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Source/WebKit/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebKit/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -42,6 +42,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Modified: trunk/Source/WebKit/Shared/API/APIArray.cpp (219647 => 219648)
--- trunk/Source/WebKit/Shared/API/APIArray.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebKit/Shared/API/APIArray.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -60,7 +60,7 @@
return patternsVector;
patternsVector.reserveInitialCapacity(size);
- for (const auto& entry : elementsOfType<API::String>())
+ for (auto entry : elementsOfType<API::String>())
patternsVector.uncheckedAppend(entry->string());
return patternsVector;
}
Modified: trunk/Source/WebKit/UIProcess/Plugins/PlugInAutoStartProvider.cpp (219647 => 219648)
--- trunk/Source/WebKit/UIProcess/Plugins/PlugInAutoStartProvider.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebKit/UIProcess/Plugins/PlugInAutoStartProvider.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -160,7 +160,7 @@
void PlugInAutoStartProvider::setAutoStartOriginsArray(API::Array& originList)
{
m_autoStartOrigins.clear();
- for (const auto& string : originList.elementsOfType<API::String>())
+ for (auto string : originList.elementsOfType<API::String>())
m_autoStartOrigins.append(string->string());
}
Modified: trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp (219647 => 219648)
--- trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -80,11 +80,11 @@
parameters.userContentWorlds.append(std::make_pair(world.key->identifier(), world.key->name()));
ASSERT(parameters.userScripts.isEmpty());
- for (const auto& userScript : m_userScripts->elementsOfType<API::UserScript>())
+ for (auto userScript : m_userScripts->elementsOfType<API::UserScript>())
parameters.userScripts.append({ userScript->identifier(), userScript->userContentWorld().identifier(), userScript->userScript() });
ASSERT(parameters.userStyleSheets.isEmpty());
- for (const auto& userStyleSheet : m_userStyleSheets->elementsOfType<API::UserStyleSheet>())
+ for (auto userStyleSheet : m_userStyleSheets->elementsOfType<API::UserStyleSheet>())
parameters.userStyleSheets.append({ userStyleSheet->identifier(), userStyleSheet->userContentWorld().identifier(), userStyleSheet->userStyleSheet() });
ASSERT(parameters.messageHandlers.isEmpty());
@@ -193,7 +193,7 @@
void WebUserContentControllerProxy::removeAllUserScripts()
{
HashCountedSet<RefPtr<API::UserContentWorld>> worlds;
- for (const auto& userScript : m_userScripts->elementsOfType<API::UserScript>())
+ for (auto userScript : m_userScripts->elementsOfType<API::UserScript>())
worlds.add(const_cast<API::UserContentWorld*>(&userScript->userContentWorld()));
Vector<uint64_t> worldIdentifiers;
@@ -248,7 +248,7 @@
void WebUserContentControllerProxy::removeAllUserStyleSheets()
{
HashCountedSet<RefPtr<API::UserContentWorld>> worlds;
- for (const auto& userStyleSheet : m_userStyleSheets->elementsOfType<API::UserStyleSheet>())
+ for (auto userStyleSheet : m_userStyleSheets->elementsOfType<API::UserStyleSheet>())
worlds.add(const_cast<API::UserContentWorld*>(&userStyleSheet->userContentWorld()));
Vector<uint64_t> worldIdentifiers;
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm (219647 => 219648)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2017-07-19 05:47:23 UTC (rev 219648)
@@ -246,7 +246,7 @@
Ref<API::Array> acceptMimeTypes = parameters->acceptMIMETypes();
NSMutableArray *mimeTypes = [NSMutableArray arrayWithCapacity:acceptMimeTypes->size()];
- for (const auto& mimeType : acceptMimeTypes->elementsOfType<API::String>())
+ for (auto mimeType : acceptMimeTypes->elementsOfType<API::String>())
[mimeTypes addObject:mimeType->string()];
_mimeTypes = adoptNS([mimeTypes copy]);
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp (219647 => 219648)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp 2017-07-19 05:47:23 UTC (rev 219648)
@@ -163,10 +163,10 @@
ASSERT(typesArray->size() == dataArray->size());
- for (const auto& type : typesArray->elementsOfType<API::String>())
+ for (auto type : typesArray->elementsOfType<API::String>())
pasteboardTypes.append(type->string());
- for (const auto& item : dataArray->elementsOfType<API::Data>()) {
+ for (auto item : dataArray->elementsOfType<API::Data>()) {
RefPtr<SharedBuffer> buffer = SharedBuffer::create(item->bytes(), item->size());
pasteboardData.append(buffer);
}
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (219647 => 219648)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1,5 +1,14 @@
2017-07-18 Andy Estes <[email protected]>
+ [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
+ https://bugs.webkit.org/show_bug.cgi?id=174631
+
+ Reviewed by Tim Horton.
+
+ * Configurations/Base.xcconfig:
+
+2017-07-18 Andy Estes <[email protected]>
+
[Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
https://bugs.webkit.org/show_bug.cgi?id=174631
Modified: trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -42,6 +42,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Modified: trunk/Source/bmalloc/ChangeLog (219647 => 219648)
--- trunk/Source/bmalloc/ChangeLog 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/bmalloc/ChangeLog 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1,5 +1,14 @@
2017-07-18 Andy Estes <[email protected]>
+ [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
+ https://bugs.webkit.org/show_bug.cgi?id=174631
+
+ Reviewed by Tim Horton.
+
+ * Configurations/Base.xcconfig:
+
+2017-07-18 Andy Estes <[email protected]>
+
[Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
https://bugs.webkit.org/show_bug.cgi?id=174631
Modified: trunk/Source/bmalloc/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Source/bmalloc/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Source/bmalloc/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -42,6 +42,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
Modified: trunk/Tools/ChangeLog (219647 => 219648)
--- trunk/Tools/ChangeLog 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Tools/ChangeLog 2017-07-19 05:47:23 UTC (rev 219648)
@@ -1,5 +1,18 @@
2017-07-18 Andy Estes <[email protected]>
+ [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
+ https://bugs.webkit.org/show_bug.cgi?id=174631
+
+ Reviewed by Tim Horton.
+
+ * DumpRenderTree/mac/Configurations/Base.xcconfig:
+ * MiniBrowser/Configurations/Base.xcconfig:
+ * MobileMiniBrowser/Configurations/Base.xcconfig:
+ * TestWebKitAPI/Configurations/Base.xcconfig:
+ * WebKitTestRunner/Configurations/Base.xcconfig:
+
+2017-07-18 Andy Estes <[email protected]>
+
[Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
https://bugs.webkit.org/show_bug.cgi?id=174631
Modified: trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Tools/DumpRenderTree/mac/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -65,6 +65,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
Modified: trunk/Tools/MiniBrowser/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Tools/MiniBrowser/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Tools/MiniBrowser/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -46,6 +46,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
Modified: trunk/Tools/MobileMiniBrowser/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Tools/MobileMiniBrowser/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Tools/MobileMiniBrowser/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -34,6 +34,7 @@
CLANG_WARN_CXX0X_EXTENSIONS = NO;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include;
DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
PREBINDING = NO
Modified: trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Tools/TestWebKitAPI/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -54,6 +54,7 @@
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO
Modified: trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig (219647 => 219648)
--- trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2017-07-19 04:53:59 UTC (rev 219647)
+++ trunk/Tools/WebKitTestRunner/Configurations/Base.xcconfig 2017-07-19 05:47:23 UTC (rev 219648)
@@ -35,6 +35,7 @@
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
+CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
HEADER_SEARCH_PATHS = $(BUILT_PRODUCTS_DIR)/usr/local/include $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport $(WEBCORE_PRIVATE_HEADERS_DIR)/ForwardingHeaders $(NEXT_ROOT)/usr/local/include/WebCoreTestSupport;
GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) U_DISABLE_RENAMING=1 U_SHOW_CPLUSPLUS_API=0 ENABLE_DASHBOARD_SUPPORT;
