Title: [219651] trunk/Source/WebKit
- Revision
- 219651
- Author
- [email protected]
- Date
- 2017-07-18 23:10:12 -0700 (Tue, 18 Jul 2017)
Log Message
Web Automation: error details not passed to DidEvaluateJavaScriptFunction message when callback was not called before page unload
https://bugs.webkit.org/show_bug.cgi?id=174624
Reviewed by Brian Burg.
There's a variable errorMessage, but it's unused.
* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::didClearWindowObjectForFrame): Pass errorMessage instead of String() to DidEvaluateJavaScriptFunction.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (219650 => 219651)
--- trunk/Source/WebKit/ChangeLog 2017-07-19 06:08:29 UTC (rev 219650)
+++ trunk/Source/WebKit/ChangeLog 2017-07-19 06:10:12 UTC (rev 219651)
@@ -1,5 +1,17 @@
2017-07-18 Carlos Garcia Campos <[email protected]>
+ Web Automation: error details not passed to DidEvaluateJavaScriptFunction message when callback was not called before page unload
+ https://bugs.webkit.org/show_bug.cgi?id=174624
+
+ Reviewed by Brian Burg.
+
+ There's a variable errorMessage, but it's unused.
+
+ * WebProcess/Automation/WebAutomationSessionProxy.cpp:
+ (WebKit::WebAutomationSessionProxy::didClearWindowObjectForFrame): Pass errorMessage instead of String() to DidEvaluateJavaScriptFunction.
+
+2017-07-18 Carlos Garcia Campos <[email protected]>
+
Web Automation: evaluateJavaScriptFunction should always notify the web process before returning early
https://bugs.webkit.org/show_bug.cgi?id=174623
Modified: trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp (219650 => 219651)
--- trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp 2017-07-19 06:08:29 UTC (rev 219650)
+++ trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp 2017-07-19 06:10:12 UTC (rev 219651)
@@ -224,7 +224,7 @@
auto pendingFrameCallbacks = m_webFramePendingEvaluateJavaScriptCallbacksMap.take(frameID);
for (uint64_t callbackID : pendingFrameCallbacks)
- WebProcess::singleton().parentProcessConnection()->send(Messages::WebAutomationSession::DidEvaluateJavaScriptFunction(callbackID, String(), errorType), 0);
+ WebProcess::singleton().parentProcessConnection()->send(Messages::WebAutomationSession::DidEvaluateJavaScriptFunction(callbackID, errorMessage, errorType), 0);
}
void WebAutomationSessionProxy::evaluateJavaScriptFunction(uint64_t pageID, uint64_t frameID, const String& function, Vector<String> arguments, bool expectsImplicitCallbackArgument, int callbackTimeout, uint64_t callbackID)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
