Title: [99901] trunk/Tools
- Revision
- 99901
- Author
- [email protected]
- Date
- 2011-11-10 14:52:30 -0800 (Thu, 10 Nov 2011)
Log Message
ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
https://bugs.webkit.org/show_bug.cgi?id=72057
Reviewed by Eric Seidel.
Make the regular _expression_ more explicit.
* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (99900 => 99901)
--- trunk/Tools/ChangeLog 2011-11-10 22:43:46 UTC (rev 99900)
+++ trunk/Tools/ChangeLog 2011-11-10 22:52:30 UTC (rev 99901)
@@ -1,3 +1,15 @@
+2011-11-10 Ryosuke Niwa <[email protected]>
+
+ ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
+ https://bugs.webkit.org/show_bug.cgi?id=72057
+
+ Reviewed by Eric Seidel.
+
+ Make the regular _expression_ more explicit.
+
+ * Scripts/webkitpy/common/checkout/changelog.py:
+ * Scripts/webkitpy/common/checkout/changelog_unittest.py:
+
2011-11-10 Balazs Kelemen <[email protected]>
[Qt] X11 plugins need to be reworked for Qt5
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py (99900 => 99901)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2011-11-10 22:43:46 UTC (rev 99900)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2011-11-10 22:52:30 UTC (rev 99901)
@@ -75,7 +75,7 @@
date_line_regexp = r'^(?P<date>\d{4}-\d{2}-\d{2})\s+(?P<name>.+?)\s+<(?P<email>[^<>]+)>$'
# e.g. * Source/WebCore/page/EventHandler.cpp: Implement FooBarQuux.
- touched_files_regexp = r'\s*\*\s*(?P<file>.+)\:'
+ touched_files_regexp = r'^\s*\*\s*(?P<file>[A-Za-z0-9_\-\./\\]+)\s*\:'
# e.g. Reviewed by Darin Adler.
# (Discard everything after the first period to match more invalid lines.)
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py (99900 => 99901)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2011-11-10 22:43:46 UTC (rev 99900)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2011-11-10 22:52:30 UTC (rev 99901)
@@ -88,6 +88,31 @@
tests. The close method can be called on a window that's already closed
so we can't assert here.
+2011-11-04 Benjamin Poulain <[email protected]>
+
+ [Mac] ResourceRequest's nsURLRequest() does not differentiate null and empty URLs with CFNetwork
+ https://bugs.webkit.org/show_bug.cgi?id=71539
+
+ Reviewed by David Kilzer.
+
+ In order to have CFURL and NSURL to be consistent when both are used on Mac,
+ KURL::createCFURL() is changed to support empty URL values.
+
+ * This change log entry is made up to test _parse_entry:
+ * a list of things
+
+ * platform/cf/KURLCFNet.cpp:
+ (WebCore::createCFURLFromBuffer):
+ (WebCore::KURL::createCFURL):
+ * platform/mac/KURLMac.mm :
+ (WebCore::KURL::operator NSURL *):
+ (WebCore::KURL::createCFURL):
+ * WebCoreSupport/ChromeClientEfl.cpp:
+ (WebCore::ChromeClientEfl::closeWindowSoon): call new function and moves its
+ previous functionality there.
+ * ewk/ewk_private.h:
+ * ewk/ewk_view.cpp:
+
== Rolled over to ChangeLog-2009-06-16 ==
"""
@@ -156,10 +181,13 @@
def test_parse_log_entries_from_changelog(self):
changelog_file = StringIO(self._example_changelog)
parsed_entries = list(ChangeLog.parse_entries_from_file(changelog_file))
- self.assertEquals(len(parsed_entries), 3)
+ self.assertEquals(len(parsed_entries), 4)
self.assertEquals(parsed_entries[0].reviewer_text(), "David Levin")
self.assertEquals(parsed_entries[1].author_email(), "[email protected]")
self.assertEquals(parsed_entries[2].touched_files(), ["DumpRenderTree/mac/DumpRenderTreeWindow.mm"])
+ self.assertEquals(parsed_entries[3].author_name(), "Benjamin Poulain")
+ self.assertEquals(parsed_entries[3].touched_files(), ["platform/cf/KURLCFNet.cpp", "platform/mac/KURLMac.mm",
+ "WebCoreSupport/ChromeClientEfl.cpp", "ewk/ewk_private.h", "ewk/ewk_view.cpp"])
def test_latest_entry_parse(self):
changelog_contents = u"%s\n%s" % (self._example_entry, self._example_changelog)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
