Title: [219753] trunk/Source/WebCore
Revision
219753
Author
[email protected]
Date
2017-07-21 17:13:11 -0700 (Fri, 21 Jul 2017)

Log Message

Remove an inaccurate comment from RenderTextLineBoxes

* rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::absoluteRectsForRange):
This comment has been wrong for at least 4 years.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (219752 => 219753)


--- trunk/Source/WebCore/ChangeLog	2017-07-21 23:34:18 UTC (rev 219752)
+++ trunk/Source/WebCore/ChangeLog	2017-07-22 00:13:11 UTC (rev 219753)
@@ -1,5 +1,13 @@
 2017-07-21  Timothy Horton  <[email protected]>
 
+        Remove an inaccurate comment from RenderTextLineBoxes
+
+        * rendering/RenderTextLineBoxes.cpp:
+        (WebCore::RenderTextLineBoxes::absoluteRectsForRange):
+        This comment has been wrong for at least 4 years.
+
+2017-07-21  Timothy Horton  <[email protected]>
+
         TextIndicator::estimatedTextColorsForRange asserts inside HashSet code (inserting reserved value)
         https://bugs.webkit.org/show_bug.cgi?id=174733
 

Modified: trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp (219752 => 219753)


--- trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp	2017-07-21 23:34:18 UTC (rev 219752)
+++ trunk/Source/WebCore/rendering/RenderTextLineBoxes.cpp	2017-07-22 00:13:11 UTC (rev 219753)
@@ -553,7 +553,6 @@
             rects.append(renderer.localToAbsoluteQuad(boundaries, UseTransforms, wasFixed).enclosingBoundingBox());
             continue;
         }
-        // FIXME: This code is wrong. It's converting local to absolute twice. http://webkit.org/b/65722
         FloatRect rect = localQuadForTextBox(*box, start, end, useSelectionHeight);
         if (!rect.isZero())
             rects.append(renderer.localToAbsoluteQuad(rect, UseTransforms, wasFixed).enclosingBoundingBox());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to