Title: [219778] branches/safari-604-branch/Source/WebCore
- Revision
- 219778
- Author
- [email protected]
- Date
- 2017-07-22 23:51:05 -0700 (Sat, 22 Jul 2017)
Log Message
Cherry-pick r219645. rdar://problem/33464440
Modified Paths
Diff
Modified: branches/safari-604-branch/Source/WebCore/ChangeLog (219777 => 219778)
--- branches/safari-604-branch/Source/WebCore/ChangeLog 2017-07-23 06:51:03 UTC (rev 219777)
+++ branches/safari-604-branch/Source/WebCore/ChangeLog 2017-07-23 06:51:05 UTC (rev 219778)
@@ -1,5 +1,27 @@
2017-07-22 Jason Marcell <[email protected]>
+ Cherry-pick r219645. rdar://problem/33464440
+
+ 2017-07-18 Zalan Bujtas <[email protected]>
+
+ Media controls are missing content in fullscreen when document has scroll offset.
+ https://bugs.webkit.org/show_bug.cgi?id=174644
+ <rdar://problem/32415323>
+
+ Reviewed by Simon Fraser.
+
+ If a non-user initiated scrolling (result of resize for example) is processed asynchronously, it might
+ leapfrog other, programatic scrollings and trigger unintentional scroll offsets (and turn into unwanted clippings).
+ This patch ensures that both resize and top content inset change are translated into programatic scrolling.
+
+ Unable to test full screen video.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::setFrameRect):
+ (WebCore::FrameView::topContentInsetDidChange):
+
+2017-07-22 Jason Marcell <[email protected]>
+
Cherry-pick r219641. rdar://problem/33464325
2017-07-18 Chris Dumez <[email protected]>
Modified: branches/safari-604-branch/Source/WebCore/page/FrameView.cpp (219777 => 219778)
--- branches/safari-604-branch/Source/WebCore/page/FrameView.cpp 2017-07-23 06:51:03 UTC (rev 219777)
+++ branches/safari-604-branch/Source/WebCore/page/FrameView.cpp 2017-07-23 06:51:05 UTC (rev 219778)
@@ -528,7 +528,8 @@
IntRect oldRect = frameRect();
if (newRect == oldRect)
return;
-
+ // Every scroll that happens as the result of frame size change is programmatic.
+ SetForScope<bool> changeInProgrammaticScroll(m_inProgrammaticScroll, true);
ScrollView::setFrameRect(newRect);
updateScrollableAreaSet();
@@ -1175,7 +1176,8 @@
platformSetTopContentInset(newTopContentInset);
layout();
-
+ // Every scroll that happens as the result of content inset change is programmatic.
+ SetForScope<bool> changeInProgrammaticScroll(m_inProgrammaticScroll, true);
updateScrollbars(scrollPosition());
if (renderView->usesCompositing())
renderView->compositor().frameViewDidChangeSize();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes