Title: [219881] trunk/Source/WebKit
Revision
219881
Author
[email protected]
Date
2017-07-25 13:47:00 -0700 (Tue, 25 Jul 2017)

Log Message

Fix API tests after r219871.
https://bugs.webkit.org/show_bug.cgi?id=174807

WebKit2.OpenAndCloseWindowAsync and WebKit2.OpenAsyncWithNil API tests are fixed.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
createNewPageAsync or createNewPage should be called, not both.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (219880 => 219881)


--- trunk/Source/WebKit/ChangeLog	2017-07-25 20:45:53 UTC (rev 219880)
+++ trunk/Source/WebKit/ChangeLog	2017-07-25 20:47:00 UTC (rev 219881)
@@ -1,3 +1,14 @@
+2017-07-25  Alex Christensen  <[email protected]>
+
+        Fix API tests after r219871.
+        https://bugs.webkit.org/show_bug.cgi?id=174807
+
+        WebKit2.OpenAndCloseWindowAsync and WebKit2.OpenAsyncWithNil API tests are fixed.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::createNewPage):
+        createNewPageAsync or createNewPage should be called, not both.
+
 2017-07-25  Said Abou-Hallawa  <[email protected]>
 
         Async image decoding for large images should be disabled after the first time a tile is painted

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (219880 => 219881)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2017-07-25 20:45:53 UTC (rev 219880)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2017-07-25 20:47:00 UTC (rev 219881)
@@ -3857,6 +3857,7 @@
         m_uiClient->createNewPageAsync(this, originatingFrameInfo, WTFMove(request), windowFeatures, WTFMove(navigationActionData), [completionHandler = WTFMove(completionHandler)](RefPtr<WebPageProxy> newPage) {
             completionHandler(newPage);
         });
+        return;
     }
 
     RefPtr<WebPageProxy> newPage = m_uiClient->createNewPage(this, originatingFrameInfo, WTFMove(request), windowFeatures, WTFMove(navigationActionData));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to