Title: [219913] trunk/LayoutTests
Revision
219913
Author
[email protected]
Date
2017-07-26 02:22:49 -0700 (Wed, 26 Jul 2017)

Log Message

Fix an incorrect check in 2d.missingargs.html.
https://bugs.webkit.org/show_bug.cgi?id=174854

Patch by Ms2ger <[email protected]> on 2017-07-26
Reviewed by Carlos Garcia Campos.

The check was introduced without explanation in r168302. This change reverts
it to the previous, correct check.

* canvas/philip/tests/2d.missingargs-expected.txt:
* canvas/philip/tests/2d.missingargs.html:
* platform/gtk/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt: Removed.
* platform/wpe/TestExpectations:

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (219912 => 219913)


--- trunk/LayoutTests/ChangeLog	2017-07-26 09:01:34 UTC (rev 219912)
+++ trunk/LayoutTests/ChangeLog	2017-07-26 09:22:49 UTC (rev 219913)
@@ -1,3 +1,20 @@
+2017-07-26  Ms2ger  <[email protected]>
+
+        Fix an incorrect check in 2d.missingargs.html.
+        https://bugs.webkit.org/show_bug.cgi?id=174854
+
+        Reviewed by Carlos Garcia Campos.
+
+        The check was introduced without explanation in r168302. This change reverts
+        it to the previous, correct check.
+
+        * canvas/philip/tests/2d.missingargs-expected.txt:
+        * canvas/philip/tests/2d.missingargs.html:
+        * platform/gtk/TestExpectations:
+        * platform/ios/TestExpectations:
+        * platform/mac/canvas/philip/tests/2d.missingargs-expected.txt: Removed.
+        * platform/wpe/TestExpectations:
+
 2017-07-26  Claudio Saavedra  <[email protected]>
 
         [WPE] Enable KeyboardEvent key and code attributes

Modified: trunk/LayoutTests/canvas/philip/tests/2d.missingargs-expected.txt (219912 => 219913)


--- trunk/LayoutTests/canvas/philip/tests/2d.missingargs-expected.txt	2017-07-26 09:01:34 UTC (rev 219912)
+++ trunk/LayoutTests/canvas/philip/tests/2d.missingargs-expected.txt	2017-07-26 09:22:49 UTC (rev 219913)
@@ -1,2 +1 @@
 Passed
-

Modified: trunk/LayoutTests/canvas/philip/tests/2d.missingargs.html (219912 => 219913)


--- trunk/LayoutTests/canvas/philip/tests/2d.missingargs.html	2017-07-26 09:01:34 UTC (rev 219912)
+++ trunk/LayoutTests/canvas/philip/tests/2d.missingargs.html	2017-07-26 09:22:49 UTC (rev 219913)
@@ -313,7 +313,7 @@
 } catch (e) { if (!(e instanceof TypeError)) _fail("Failed assertion: expected exception of type TypeError, got: "+e); _thrown = true; } finally { _assert(_thrown, "should throw exception of type TypeError: g.addColorStop()"); }
 try { var _thrown = false;
   g.addColorStop(0);
-} catch (e) { if ((e.message != "SyntaxError (DOM Exception 12): The string did not match the expected pattern.")) _fail("Failed assertion: expected exception of type SyntaxError, got: "+e); _thrown = true; } finally { _assert(_thrown, "should throw exception of type SyntaxError: g.addColorStop(0)"); }
+} catch (e) { if (!(e instanceof TypeError)) _fail("Failed assertion: expected exception of type TypeError, got: "+e); _thrown = true; } finally { _assert(_thrown, "should throw exception of type TypeError: g.addColorStop(0)"); }
 
 
 });

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (219912 => 219913)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-07-26 09:01:34 UTC (rev 219912)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-07-26 09:22:49 UTC (rev 219913)
@@ -2547,7 +2547,6 @@
 Bug(GTK) canvas/philip/tests/2d.drawImage.broken.html [ Failure ]
 Bug(GTK) canvas/philip/tests/2d.fillStyle.parse.rgb-eof.html [ Failure ]
 Bug(GTK) canvas/philip/tests/2d.fillStyle.parse.rgba-eof.html [ Failure ]
-Bug(GTK) canvas/philip/tests/2d.missingargs.html [ Failure ]
 Bug(GTK) canvas/philip/tests/2d.text.draw.baseline.bottom.html [ Failure ]
 Bug(GTK) canvas/philip/tests/2d.text.draw.baseline.hanging.html [ Failure ]
 Bug(GTK) canvas/philip/tests/2d.text.draw.baseline.ideographic.html [ Failure ]

Modified: trunk/LayoutTests/platform/ios/TestExpectations (219912 => 219913)


--- trunk/LayoutTests/platform/ios/TestExpectations	2017-07-26 09:01:34 UTC (rev 219912)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2017-07-26 09:22:49 UTC (rev 219913)
@@ -433,7 +433,6 @@
 webkit.org/b/137530 canvas/philip/tests/2d.drawImage.animated.poster.html [ Failure ]
 webkit.org/b/137530 canvas/philip/tests/2d.drawImage.broken.html [ Failure ]
 webkit.org/b/137530 canvas/philip/tests/2d.drawImage.outsidesource.html [ Failure ]
-webkit.org/b/137530 canvas/philip/tests/2d.missingargs.html [ Failure ]
 webkit.org/b/137530 canvas/philip/tests/2d.path.rect.winding.html [ Failure ]
 webkit.org/b/137530 canvas/philip/tests/2d.text.draw.baseline.bottom.html [ Failure ]
 webkit.org/b/137530 canvas/philip/tests/2d.text.draw.baseline.hanging.html [ Failure ]

Deleted: trunk/LayoutTests/platform/mac/canvas/philip/tests/2d.missingargs-expected.txt (219912 => 219913)


--- trunk/LayoutTests/platform/mac/canvas/philip/tests/2d.missingargs-expected.txt	2017-07-26 09:01:34 UTC (rev 219912)
+++ trunk/LayoutTests/platform/mac/canvas/philip/tests/2d.missingargs-expected.txt	2017-07-26 09:22:49 UTC (rev 219913)
@@ -1 +0,0 @@
-Failed assertion: expected exception of type SyntaxError, got: TypeError: Not enough arguments

Modified: trunk/LayoutTests/platform/wpe/TestExpectations (219912 => 219913)


--- trunk/LayoutTests/platform/wpe/TestExpectations	2017-07-26 09:01:34 UTC (rev 219912)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2017-07-26 09:22:49 UTC (rev 219913)
@@ -76,7 +76,6 @@
 Bug(WPE) canvas/philip/tests/2d.drawImage.animated.poster.html [ Failure ]
 Bug(WPE) canvas/philip/tests/2d.drawImage.broken.html [ Failure ]
 Bug(WPE) canvas/philip/tests/2d.drawImage.outsidesource.html [ Failure ]
-Bug(WPE) canvas/philip/tests/2d.missingargs.html [ Failure ]
 Bug(WPE) canvas/philip/tests/2d.pattern.animated.gif.html [ Failure ]
 Bug(WPE) canvas/philip/tests/2d.text.draw.baseline.bottom.html [ Failure ]
 Bug(WPE) canvas/philip/tests/2d.text.draw.baseline.hanging.html [ Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to