Title: [219918] branches/safari-604-branch/Source/WebCore
- Revision
- 219918
- Author
- [email protected]
- Date
- 2017-07-26 02:51:34 -0700 (Wed, 26 Jul 2017)
Log Message
Cherry-pick r219736. rdar://problem/33523835
Modified Paths
Diff
Modified: branches/safari-604-branch/Source/WebCore/ChangeLog (219917 => 219918)
--- branches/safari-604-branch/Source/WebCore/ChangeLog 2017-07-26 09:51:31 UTC (rev 219917)
+++ branches/safari-604-branch/Source/WebCore/ChangeLog 2017-07-26 09:51:34 UTC (rev 219918)
@@ -1,5 +1,23 @@
2017-07-26 Jason Marcell <[email protected]>
+ Cherry-pick r219736. rdar://problem/33523835
+
+ 2017-07-21 Jeremy Jones <[email protected]>
+
+ Noise when AudioChannel lengths don't match.
+ https://bugs.webkit.org/show_bug.cgi?id=174706
+ rdar://problem/33389856
+
+ Reviewed by Eric Carlson.
+
+ When AudioChannel lengths don't match, copyFrom() returns early leaving uninitialized data in the audio buffer.
+ This change zeros out the data, so there isn't objectionable noise sent to the speaker.
+
+ * platform/audio/AudioChannel.cpp:
+ (WebCore::AudioChannel::copyFrom):
+
+2017-07-26 Jason Marcell <[email protected]>
+
Cherry-pick r219638. rdar://problem/33523787
2017-07-18 Ryosuke Niwa <[email protected]>
Modified: branches/safari-604-branch/Source/WebCore/platform/audio/AudioChannel.cpp (219917 => 219918)
--- branches/safari-604-branch/Source/WebCore/platform/audio/AudioChannel.cpp 2017-07-26 09:51:31 UTC (rev 219917)
+++ branches/safari-604-branch/Source/WebCore/platform/audio/AudioChannel.cpp 2017-07-26 09:51:34 UTC (rev 219918)
@@ -59,10 +59,8 @@
{
bool isSafe = (sourceChannel && sourceChannel->length() >= length());
ASSERT(isSafe);
- if (!isSafe)
- return;
- if (sourceChannel->isSilent()) {
+ if (!isSafe || sourceChannel->isSilent()) {
zero();
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
