Title: [219919] branches/safari-604-branch/Source/WebCore
- Revision
- 219919
- Author
- [email protected]
- Date
- 2017-07-26 02:51:36 -0700 (Wed, 26 Jul 2017)
Log Message
Cherry-pick r219737. rdar://problem/33523854
Modified Paths
Diff
Modified: branches/safari-604-branch/Source/WebCore/ChangeLog (219918 => 219919)
--- branches/safari-604-branch/Source/WebCore/ChangeLog 2017-07-26 09:51:34 UTC (rev 219918)
+++ branches/safari-604-branch/Source/WebCore/ChangeLog 2017-07-26 09:51:36 UTC (rev 219919)
@@ -1,5 +1,34 @@
2017-07-26 Jason Marcell <[email protected]>
+ Cherry-pick r219737. rdar://problem/33523854
+
+ 2017-07-21 Jeremy Jones <[email protected]>
+
+ AudioTrackPrivateMediaStreamCocoa shouldn't set AudioSession::setPreferredBufferSize
+ https://bugs.webkit.org/show_bug.cgi?id=174707
+ rdar://problem/33446809
+
+ Reviewed by Eric Carlson.
+
+ Manually tested for audio side effects.
+
+ AudioChannel::copyFrom fails when AudioChannel lengths don't match.
+
+ This happens because PlatformMediaSessionManager::updateSessionState() owns and sets
+ AudioSession::setPreferredBufferSize().
+
+ However, AudioTrackPrivateMediaStreamCocoa::createAudioUnit, when it creates an input
+ audio unit is setting AudioSession::setPreferredBufferSize() directly to its own arbitrary value.
+
+ AudioSession::setPreferredBufferSize() should be managed by the higher level
+ PlatformMediaSessionManager, and not modified by audio unit creation, in order to keep harmony
+ within the audio pipeline.
+
+ * platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
+ (WebCore::AudioTrackPrivateMediaStreamCocoa::createAudioUnit):
+
+2017-07-26 Jason Marcell <[email protected]>
+
Cherry-pick r219736. rdar://problem/33523835
2017-07-21 Jeremy Jones <[email protected]>
Modified: branches/safari-604-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp (219918 => 219919)
--- branches/safari-604-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp 2017-07-26 09:51:34 UTC (rev 219918)
+++ branches/safari-604-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp 2017-07-26 09:51:36 UTC (rev 219919)
@@ -161,8 +161,6 @@
return nullptr;
}
- AudioSession::sharedSession().setPreferredBufferSize(AudioSession::sharedSession().sampleRate() / 50);
-
return remoteIOUnit;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
