Title: [219963] trunk/Tools
- Revision
- 219963
- Author
- [email protected]
- Date
- 2017-07-26 14:38:04 -0700 (Wed, 26 Jul 2017)
Log Message
Remove duplicate code from Buildbot.js in dashboard
https://bugs.webkit.org/show_bug.cgi?id=174870
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype._javascript_CoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
(Buildbot.prototype._javascript_CoreTestStdioUrlForIteration): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
(MockBuildbot.prototype._javascript_CoreTestStdioUrlForIteration): Ditto for tests.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js (219962 => 219963)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js 2017-07-26 21:02:01 UTC (rev 219962)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js 2017-07-26 21:38:04 UTC (rev 219963)
@@ -153,12 +153,12 @@
_javascript_CoreTestFailuresURLForIteration: function(iteration, name)
{
- return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/" + name + "/logs/json/text";
+ return this.buildPageURLForIteration(iteration) + "/steps/" + name + "/logs/json/text";
},
_javascript_CoreTestStdioUrlForIteration: function(iteration, name)
{
- return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/" + name + "/logs/stdio";
+ return this.buildPageURLForIteration(iteration) + "/steps/" + name + "/logs/stdio";
},
layoutTestResultsDirectoryURLForIteration: function(iteration)
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js (219962 => 219963)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js 2017-07-26 21:02:01 UTC (rev 219962)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js 2017-07-26 21:38:04 UTC (rev 219963)
@@ -40,7 +40,6 @@
_javascript_CoreTestStdioUrlForIteration: function(iteration, name)
{
- return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/" + name + "/logs/stdio";
-
+ return this.buildPageURLForIteration(iteration) + "/steps/" + name + "/logs/stdio";
},
}
Modified: trunk/Tools/ChangeLog (219962 => 219963)
--- trunk/Tools/ChangeLog 2017-07-26 21:02:01 UTC (rev 219962)
+++ trunk/Tools/ChangeLog 2017-07-26 21:38:04 UTC (rev 219963)
@@ -1,3 +1,16 @@
+2017-07-26 Aakash Jain <[email protected]>
+
+ Remove duplicate code from Buildbot.js in dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=174870
+
+ Reviewed by Daniel Bates.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
+ (Buildbot.prototype._javascript_CoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
+ (Buildbot.prototype._javascript_CoreTestStdioUrlForIteration): Ditto.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
+ (MockBuildbot.prototype._javascript_CoreTestStdioUrlForIteration): Ditto for tests.
+
2017-07-26 Brady Eidson <[email protected]>
Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
