Title: [219973] trunk/Source/WebKit
- Revision
- 219973
- Author
- [email protected]
- Date
- 2017-07-26 18:49:44 -0700 (Wed, 26 Jul 2017)
Log Message
REGRESSION (r211160): Can't pinch to zoom unlocked encrypted PDFs in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=174881
<rdar://problem/33556312>
Reviewed by Andy Estes.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _hidePasswordView]):
WKPasswordView saves and restores a bunch of scroll view properties, including
those relating to zoom limits. The restoration happens in -[WKPasswordView hide],
which is never called. Instead, the code added in r211160 just calls
removeFromSuperview after unlocking, never restoring the old zoom limits,
causing the then fully unlocked PDF to not be zoomable. Fix this by calling
-hide instead of -removeFromSuperview (which -hide also calls).
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (219972 => 219973)
--- trunk/Source/WebKit/ChangeLog 2017-07-27 00:13:20 UTC (rev 219972)
+++ trunk/Source/WebKit/ChangeLog 2017-07-27 01:49:44 UTC (rev 219973)
@@ -1,3 +1,20 @@
+2017-07-26 Tim Horton <[email protected]>
+
+ REGRESSION (r211160): Can't pinch to zoom unlocked encrypted PDFs in WKWebView
+ https://bugs.webkit.org/show_bug.cgi?id=174881
+ <rdar://problem/33556312>
+
+ Reviewed by Andy Estes.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _hidePasswordView]):
+ WKPasswordView saves and restores a bunch of scroll view properties, including
+ those relating to zoom limits. The restoration happens in -[WKPasswordView hide],
+ which is never called. Instead, the code added in r211160 just calls
+ removeFromSuperview after unlocking, never restoring the old zoom limits,
+ causing the then fully unlocked PDF to not be zoomable. Fix this by calling
+ -hide instead of -removeFromSuperview (which -hide also calls).
+
2017-07-26 Brady Eidson <[email protected]>
Rename {Web/UI}Process/Storage to {Web/UI}Process/WebStorage.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (219972 => 219973)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2017-07-27 00:13:20 UTC (rev 219972)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2017-07-27 01:49:44 UTC (rev 219973)
@@ -2695,7 +2695,7 @@
return;
self._currentContentView.hidden = NO;
- [_passwordView removeFromSuperview];
+ [_passwordView hide];
_passwordView = nil;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
