Title: [219979] trunk/Source/WebCore
Revision
219979
Author
[email protected]
Date
2017-07-27 03:18:18 -0700 (Thu, 27 Jul 2017)

Log Message

[GStreamer][EME] Fix phony debug output in player base for supported key system
https://bugs.webkit.org/show_bug.cgi?id=174888

Reviewed by Žan Doberšek.

The debug output was returning always false because that method
was not checking anything before. Now it is and should reflect it.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (219978 => 219979)


--- trunk/Source/WebCore/ChangeLog	2017-07-27 08:55:09 UTC (rev 219978)
+++ trunk/Source/WebCore/ChangeLog	2017-07-27 10:18:18 UTC (rev 219979)
@@ -1,3 +1,16 @@
+2017-07-27  Xabier Rodriguez Calvar  <[email protected]>
+
+        [GStreamer][EME] Fix phony debug output in player base for supported key system
+        https://bugs.webkit.org/show_bug.cgi?id=174888
+
+        Reviewed by Žan Doberšek.
+
+        The debug output was returning always false because that method
+        was not checking anything before. Now it is and should reflect it.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+        (WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):
+
 2017-07-27  Zan Dobersek  <[email protected]>
 
         [EME][GStreamer] Add barebones CDM interface implementations for ClearKey

Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (219978 => 219979)


--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2017-07-27 08:55:09 UTC (rev 219978)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2017-07-27 10:18:18 UTC (rev 219979)
@@ -1033,14 +1033,15 @@
 
 bool MediaPlayerPrivateGStreamerBase::supportsKeySystem(const String& keySystem, const String& mimeType)
 {
-    GST_INFO("Checking for KeySystem support with %s and type %s: false.", keySystem.utf8().data(), mimeType.utf8().data());
+    bool result = false;
 
 #if ENABLE(ENCRYPTED_MEDIA)
     if (equalLettersIgnoringASCIICase(keySystem, "org.w3.clearkey"))
-        return true;
+        result = true;
 #endif
 
-    return false;
+    GST_DEBUG("checking for KeySystem support with %s and type %s: %s", keySystem.utf8().data(), mimeType.utf8().data(), result ? "true" : "false");
+    return result;
 }
 
 MediaPlayer::SupportsType MediaPlayerPrivateGStreamerBase::extendedSupportsType(const MediaEngineSupportParameters& parameters, MediaPlayer::SupportsType result)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to