Title: [219985] trunk/Source/WebKit
- Revision
- 219985
- Author
- [email protected]
- Date
- 2017-07-27 10:06:11 -0700 (Thu, 27 Jul 2017)
Log Message
PDF page number indicator is very flashy when scrolling
https://bugs.webkit.org/show_bug.cgi?id=174882
<rdar://problem/23760981>
Reviewed by Andy Estes.
* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/WKPDFPageNumberIndicator.mm:
(-[WKPDFPageNumberIndicator initWithFrame:]):
Increase the backdrop rendering resolution to reduce flashiness.
It's still not perfect, but it's quite visibly better.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (219984 => 219985)
--- trunk/Source/WebKit/ChangeLog 2017-07-27 16:48:48 UTC (rev 219984)
+++ trunk/Source/WebKit/ChangeLog 2017-07-27 17:06:11 UTC (rev 219985)
@@ -1,3 +1,17 @@
+2017-07-27 Tim Horton <[email protected]>
+
+ PDF page number indicator is very flashy when scrolling
+ https://bugs.webkit.org/show_bug.cgi?id=174882
+ <rdar://problem/23760981>
+
+ Reviewed by Andy Estes.
+
+ * Platform/spi/ios/UIKitSPI.h:
+ * UIProcess/ios/WKPDFPageNumberIndicator.mm:
+ (-[WKPDFPageNumberIndicator initWithFrame:]):
+ Increase the backdrop rendering resolution to reduce flashiness.
+ It's still not perfect, but it's quite visibly better.
+
2017-07-26 Brady Eidson <[email protected]>
ResourceLoadStatistics API tests fail on El Capitan.
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (219984 => 219985)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2017-07-27 16:48:48 UTC (rev 219984)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2017-07-27 17:06:11 UTC (rev 219985)
@@ -72,6 +72,7 @@
#import <UIKit/UIWebTiledView.h>
#import <UIKit/UIWebTouchEventsGestureRecognizer.h>
#import <UIKit/UIWindow_Private.h>
+#import <UIKit/_UIBackdropViewSettings.h>
#import <UIKit/_UIBackdropView_Private.h>
#import <UIKit/_UIHighlightView.h>
#import <UIKit/_UINavigationInteractiveTransition.h>
@@ -727,11 +728,20 @@
_UIBackdropViewStyle_Dark = 2030
};
+@interface _UIBackdropViewSettings : NSObject
+@end
+
+@interface _UIBackdropViewSettings ()
++ (_UIBackdropViewSettings *)settingsForPrivateStyle:(_UIBackdropViewStylePrivate)style;
+@property (nonatomic, assign) CGFloat scale;
+@end
+
@interface _UIBackdropView : UIView
@end
-@interface _UIBackdropView (_UIBackdropViewDetails)
+@interface _UIBackdropView ()
- (instancetype)initWithPrivateStyle:(_UIBackdropViewStylePrivate)style;
+- (instancetype)initWithSettings:(_UIBackdropViewSettings *)settings;
- (instancetype)initWithFrame:(CGRect)frame privateStyle:(_UIBackdropViewStylePrivate)style;
@property (nonatomic, strong, readonly) UIView *contentView;
@end
Modified: trunk/Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm (219984 => 219985)
--- trunk/Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm 2017-07-27 16:48:48 UTC (rev 219984)
+++ trunk/Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm 2017-07-27 17:06:11 UTC (rev 219985)
@@ -63,7 +63,10 @@
self.layer.allowsGroupOpacity = NO;
self.layer.allowsGroupBlending = NO;
- _backdropView = adoptNS([[_UIBackdropView alloc] initWithPrivateStyle:_UIBackdropViewStyle_Light]);
+ _UIBackdropViewSettings *backdropViewSettings = [_UIBackdropViewSettings settingsForPrivateStyle:_UIBackdropViewStyle_Light];
+ backdropViewSettings.scale = 0.5;
+
+ _backdropView = adoptNS([[_UIBackdropView alloc] initWithSettings:backdropViewSettings]);
[_backdropView setAutoresizingMask:UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight];
[self addSubview:_backdropView.get()];
[self _makeRoundedCorners];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
