Title: [219991] trunk/Source/WebCore
- Revision
- 219991
- Author
- [email protected]
- Date
- 2017-07-27 21:20:53 -0700 (Thu, 27 Jul 2017)
Log Message
MediaDocument fullscreen pinch gesture should trigger navigate back.
https://bugs.webkit.org/show_bug.cgi?id=174914
Patch by Jeremy Jones <[email protected]> on 2017-07-27
Reviewed by Jon Lee.
No new tests because only effect is from interaction with platform.
For media documents, pressing the "done" button on fullscreen video navigates back
to the previous page. The same should happen for other gestures that pause playback
when returning to inline. This allows the gesture to have the same behavior as the
button.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (219990 => 219991)
--- trunk/Source/WebCore/ChangeLog 2017-07-28 03:32:33 UTC (rev 219990)
+++ trunk/Source/WebCore/ChangeLog 2017-07-28 04:20:53 UTC (rev 219991)
@@ -1,3 +1,20 @@
+2017-07-27 Jeremy Jones <[email protected]>
+
+ MediaDocument fullscreen pinch gesture should trigger navigate back.
+ https://bugs.webkit.org/show_bug.cgi?id=174914
+
+ Reviewed by Jon Lee.
+
+ No new tests because only effect is from interaction with platform.
+
+ For media documents, pressing the "done" button on fullscreen video navigates back
+ to the previous page. The same should happen for other gestures that pause playback
+ when returning to inline. This allows the gesture to have the same behavior as the
+ button.
+
+ * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+ (WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason):
+
2017-07-27 Aaron Chu <[email protected]>
AX: VoiceOver silent or skipping over time values on media player.
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (219990 => 219991)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2017-07-28 03:32:33 UTC (rev 219990)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2017-07-28 04:20:53 UTC (rev 219991)
@@ -989,9 +989,10 @@
if (webPlaybackSessionModel() && (reason == ExitFullScreenReason::DoneButtonTapped || reason == ExitFullScreenReason::RemoteControlStopEventReceived))
webPlaybackSessionModel()->pause();
-
- m_videoFullscreenModel->requestFullscreenMode(HTMLMediaElementEnums::VideoFullscreenModeNone, reason == ExitFullScreenReason::DoneButtonTapped);
+ BOOL finished = reason == ExitFullScreenReason::DoneButtonTapped || reason == ExitFullScreenReason::PinchGestureHandled;
+ m_videoFullscreenModel->requestFullscreenMode(HTMLMediaElementEnums::VideoFullscreenModeNone, finished);
+
if (!m_watchdogTimer.isActive())
m_watchdogTimer.startOneShot(defaultWatchdogTimerInterval);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
