Title: [220004] trunk/Source/WebInspectorUI
Revision
220004
Author
[email protected]
Date
2017-07-28 10:27:43 -0700 (Fri, 28 Jul 2017)

Log Message

Web Inspector: Cleanup unused/invalid parameters for TreeElements
https://bugs.webkit.org/show_bug.cgi?id=173987

Reviewed by Brian Burg.

* UserInterface/Views/TreeElement.js:
* UserInterface/Views/GeneralTreeElement.js:

* UserInterface/Views/ApplicationCacheFrameTreeElement.js:
* UserInterface/Views/BreakpointTreeElement.js:
* UserInterface/Views/CSSStyleSheetTreeElement.js:
* UserInterface/Views/CallFrameTreeElement.js:
* UserInterface/Views/ContentFlowTreeElement.js:
* UserInterface/Views/DOMNodeTreeElement.js:
* UserInterface/Views/DatabaseTableTreeElement.js:
* UserInterface/Views/DatabaseTreeElement.js:
* UserInterface/Views/FolderTreeElement.js:
* UserInterface/Views/FolderizedTreeElement.js:
* UserInterface/Views/FrameTreeElement.js:
* UserInterface/Views/IndexedDatabaseObjectStoreIndexTreeElement.js:
* UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js:
* UserInterface/Views/IndexedDatabaseTreeElement.js:
* UserInterface/Views/IssueTreeElement.js:
* UserInterface/Views/ObjectTreeBaseTreeElement.js:
* UserInterface/Views/ProfileNodeTreeElement.js:
* UserInterface/Views/ResourceTreeElement.js:
* UserInterface/Views/ScriptTreeElement.js:
* UserInterface/Views/SearchResultTreeElement.js:
* UserInterface/Views/SourceCodeTreeElement.js:
* UserInterface/Views/SourceMapResourceTreeElement.js:
* UserInterface/Views/StorageTreeElement.js:
* UserInterface/Views/TimelineRecordTreeElement.js:
* UserInterface/Views/TypeTreeElement.js:

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (220003 => 220004)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-07-28 17:27:43 UTC (rev 220004)
@@ -1,3 +1,39 @@
+2017-07-28  Devin Rousso  <[email protected]>
+
+        Web Inspector: Cleanup unused/invalid parameters for TreeElements
+        https://bugs.webkit.org/show_bug.cgi?id=173987
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/TreeElement.js:
+        * UserInterface/Views/GeneralTreeElement.js:
+
+        * UserInterface/Views/ApplicationCacheFrameTreeElement.js:
+        * UserInterface/Views/BreakpointTreeElement.js:
+        * UserInterface/Views/CSSStyleSheetTreeElement.js:
+        * UserInterface/Views/CallFrameTreeElement.js:
+        * UserInterface/Views/ContentFlowTreeElement.js:
+        * UserInterface/Views/DOMNodeTreeElement.js:
+        * UserInterface/Views/DatabaseTableTreeElement.js:
+        * UserInterface/Views/DatabaseTreeElement.js:
+        * UserInterface/Views/FolderTreeElement.js:
+        * UserInterface/Views/FolderizedTreeElement.js:
+        * UserInterface/Views/FrameTreeElement.js:
+        * UserInterface/Views/IndexedDatabaseObjectStoreIndexTreeElement.js:
+        * UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js:
+        * UserInterface/Views/IndexedDatabaseTreeElement.js:
+        * UserInterface/Views/IssueTreeElement.js:
+        * UserInterface/Views/ObjectTreeBaseTreeElement.js:
+        * UserInterface/Views/ProfileNodeTreeElement.js:
+        * UserInterface/Views/ResourceTreeElement.js:
+        * UserInterface/Views/ScriptTreeElement.js:
+        * UserInterface/Views/SearchResultTreeElement.js:
+        * UserInterface/Views/SourceCodeTreeElement.js:
+        * UserInterface/Views/SourceMapResourceTreeElement.js:
+        * UserInterface/Views/StorageTreeElement.js:
+        * UserInterface/Views/TimelineRecordTreeElement.js:
+        * UserInterface/Views/TypeTreeElement.js:
+
 2017-07-26  Devin Rousso  <[email protected]>
 
         Uncaught Exception: undefined is not an object (evaluating 'this._memoryRow.value = Number.bytesToString(this._canvas.memoryCost)')

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -29,7 +29,9 @@
     {
         console.assert(representedObject instanceof WebInspector.ApplicationCacheFrame);
 
-        super("application-cache-frame", "", "", representedObject, false);
+        const title = null;
+        const subtitle = null;
+        super("application-cache-frame", title, subtitle, representedObject);
 
         this.updateTitles();
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -32,7 +32,8 @@
         if (!className)
             className = WebInspector.BreakpointTreeElement.GenericLineIconStyleClassName;
 
-        super(["breakpoint", className], title, null, breakpoint, false);
+        const subtitle = null;
+        super(["breakpoint", className], title, subtitle, breakpoint);
 
         this._breakpoint = breakpoint;
         this._probeSet = null;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleSheetTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleSheetTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleSheetTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -30,10 +30,6 @@
         console.assert(styleSheet instanceof WebInspector.CSSStyleSheet);
         console.assert(styleSheet.isInspectorStyleSheet());
 
-        const classNames = ["stylesheet", "stylesheet-icon"];
-        const title = WebInspector.UIString("Inspector Style Sheet");
-        const subtitle = null;
-        const hasChildren = false;
-        super(styleSheet, classNames, title, subtitle, styleSheet, hasChildren);
+        super(styleSheet, ["stylesheet", "stylesheet-icon"], WebInspector.UIString("Inspector Style Sheet"));
     }
 };

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -31,9 +31,9 @@
 
         let className = WebInspector.CallFrameView.iconClassNameForCallFrame(callFrame);
         let title = callFrame.functionName || WebInspector.UIString("(anonymous function)");
+        const subtitle = null;
+        super(["call-frame", className], title, subtitle, callFrame);
 
-        super(["call-frame", className], title, null, callFrame, false);
-
         this._callFrame = callFrame;
         this._isActiveCallFrame = false;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentFlowTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentFlowTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentFlowTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -34,6 +34,7 @@
     {
         console.assert(representedObject instanceof WebInspector.ContentFlow);
 
-        super("content-flow-icon", representedObject.name, null, representedObject, false);
+        const subtitle = null;
+        super("content-flow-icon", representedObject.name, subtitle, representedObject);
     }
 };

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -29,7 +29,8 @@
     {
         console.assert(domNode instanceof WebInspector.DOMNode);
 
-        super("dom-node", domNode.displayName, null, domNode, true);
+        const subtitle = null;
+        super("dom-node", domNode.displayName, subtitle, domNode, {hasChildren: true});
 
         this.status = WebInspector.linkifyNodeReferenceElement(domNode, WebInspector.createGoToArrowButton());
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -29,6 +29,7 @@
     {
         console.assert(representedObject instanceof WebInspector.DatabaseTableObject);
 
-        super("database-table-icon", representedObject.name, null, representedObject, false);
+        const subtitle = null;
+        super("database-table-icon", representedObject.name, subtitle, representedObject);
     }
 };

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -29,7 +29,8 @@
     {
         console.assert(representedObject instanceof WebInspector.DatabaseObject);
 
-        super("database-icon", representedObject.name, null, representedObject, true);
+        const subtitle = null;
+        super("database-icon", representedObject.name, subtitle, representedObject, {hasChildren: true});
 
         this.hasChildren = false;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FolderTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/FolderTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FolderTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -31,8 +31,7 @@
 
         const classNames = [WebInspector.FolderTreeElement.FolderIconStyleClassName];
         const subtitle = null;
-        const hasChildren = true;
-        super(classNames, title, subtitle, representedObject, hasChildren);
+        super(classNames, title, subtitle, representedObject, {hasChildren: true});
     }
 };
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -25,9 +25,9 @@
 
 WebInspector.FolderizedTreeElement = class FolderizedTreeElement extends WebInspector.GeneralTreeElement
 {
-    constructor(classNames, title, subtitle, representedObject, hasChildren)
+    constructor(classNames, title, subtitle, representedObject)
     {
-        super(classNames, title, subtitle, representedObject, hasChildren);
+        super(classNames, title, subtitle, representedObject);
 
         this.shouldRefreshChildren = true;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FrameTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/FrameTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FrameTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -25,11 +25,11 @@
 
 WebInspector.FrameTreeElement = class FrameTreeElement extends WebInspector.ResourceTreeElement
 {
-    constructor(frame, representedObject)
+    constructor(frame)
     {
         console.assert(frame instanceof WebInspector.Frame);
 
-        super(frame.mainResource, representedObject || frame);
+        super(frame.mainResource, frame);
 
         this._frame = frame;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -25,9 +25,9 @@
 
 WebInspector.GeneralTreeElement = class GeneralTreeElement extends WebInspector.TreeElement
 {
-    constructor(classNames, title, subtitle, representedObject, hasChildren)
+    constructor(classNames, title, subtitle, representedObject, options)
     {
-        super("", representedObject, hasChildren);
+        super("", representedObject, options);
 
         this.classNames = classNames;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreIndexTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreIndexTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreIndexTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -29,7 +29,8 @@
     {
         console.assert(objectStoreIndex instanceof WebInspector.IndexedDatabaseObjectStoreIndex);
 
-        super("database-table-icon", objectStoreIndex.name, null, objectStoreIndex, false);
+        const subtitle = null;
+        super("database-table-icon", objectStoreIndex.name, subtitle, objectStoreIndex);
 
         this._objectStoreIndex = objectStoreIndex;
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -29,7 +29,8 @@
     {
         console.assert(objectStore instanceof WebInspector.IndexedDatabaseObjectStore);
 
-        super("database-table-icon", objectStore.name, null, objectStore, !!objectStore.indexes.length);
+        const subtitle = null;
+        super("database-table-icon", objectStore.name, subtitle, objectStore, {hasChildren: !!objectStore.indexes.length});
 
         this._objectStore = objectStore;
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -29,7 +29,8 @@
     {
         console.assert(indexedDatabase instanceof WebInspector.IndexedDatabase);
 
-        super("database-icon", indexedDatabase.name, null, indexedDatabase, !!indexedDatabase.objectStores.length);
+        const subtitle = null;
+        super("database-icon", indexedDatabase.name, subtitle, indexedDatabase, {hasChildren: !!indexedDatabase.objectStores.length});
 
         this._indexedDatabase = indexedDatabase;
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -37,7 +37,9 @@
             break;
         }
 
-        super([WebInspector.IssueTreeElement.StyleClassName, levelStyleClassName], null, null, issueMessage, false);
+        const title = null;
+        const subtitle = null;
+        super([WebInspector.IssueTreeElement.StyleClassName, levelStyleClassName], title, subtitle, issueMessage);
 
         this._issueMessage = issueMessage;
         this._updateTitles();

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeBaseTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -31,7 +31,10 @@
         console.assert(propertyPath instanceof WebInspector.PropertyPath);
         console.assert(!property || property instanceof WebInspector.PropertyDescriptor);
 
-        super(null, null, null, representedObject, false);
+        const classNames = null;
+        const title = null;
+        const subtitle = null;
+        super(classNames, title, subtitle, representedObject);
 
         this._property = property;
         this._propertyPath = propertyPath;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProfileNodeTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ProfileNodeTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProfileNodeTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -72,10 +72,8 @@
         if (profileNode.functionName && profileNode.functionName.startsWith("on") && profileNode.functionName.length >= 5)
             className = WebInspector.CallFrameView.EventListenerIconStyleClassName;
 
-        var hasChildren = !!profileNode.childNodes.length;
+        super([className], title, subtitle, profileNode, {hasChildren: !!profileNode.childNodes.length});
 
-        super([className], title, subtitle, profileNode, hasChildren);
-
         this._profileNode = profileNode;
         this._delegate = delegate || null;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -29,7 +29,9 @@
     {
         console.assert(resource instanceof WebInspector.Resource);
 
-        super(resource, ["resource", WebInspector.ResourceTreeElement.ResourceIconStyleClassName, resource.type], "", "", representedObject || resource, false);
+        const title = null;
+        const subtitle = null;
+        super(resource, ["resource", WebInspector.ResourceTreeElement.ResourceIconStyleClassName, resource.type], title, subtitle, representedObject || resource);
 
         this._updateResource(resource);
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -29,14 +29,16 @@
     {
         console.assert(script instanceof WebInspector.Script);
 
-        super(script, "script", null, null, script, false);
+        const title = null;
+        const subtitle = null;
+        super(script, "script", title, subtitle);
 
         this.mainTitle = script.displayName;
 
         if (script.url && !script.dynamicallyAddedScriptElement) {
             // Show the host as the subtitle if it is different from the main title.
-            var subtitle = WebInspector.displayNameForHost(script.urlComponents.host);
-            this.subtitle = this.mainTitle !== subtitle ? subtitle : null;
+            let host = WebInspector.displayNameForHost(script.urlComponents.host);
+            this.subtitle = this.mainTitle !== host ? host : null;
 
             this.tooltip = script.url;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchResultTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -30,8 +30,8 @@
         console.assert(representedObject instanceof WebInspector.DOMSearchMatchObject || representedObject instanceof WebInspector.SourceCodeSearchMatchObject);
 
         var title = WebInspector.SearchResultTreeElement.truncateAndHighlightTitle(representedObject.title, representedObject.searchTerm, representedObject.sourceCodeTextRange);
-
-        super(representedObject.className, title, null, representedObject, false);
+        const subtitle = null;
+        super(representedObject.className, title, subtitle, representedObject);
     }
 
     // Static

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -25,11 +25,11 @@
 
 WebInspector.SourceCodeTreeElement = class SourceCodeTreeElement extends WebInspector.FolderizedTreeElement
 {
-    constructor(sourceCode, classNames, title, subtitle, representedObject, hasChildren)
+    constructor(sourceCode, classNames, title, subtitle, representedObject)
     {
         console.assert(sourceCode instanceof WebInspector.SourceCode);
 
-        super(classNames, title, subtitle, representedObject || sourceCode, hasChildren);
+        super(classNames, title, subtitle, representedObject || sourceCode);
 
         this._updateSourceCode(sourceCode);
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceMapResourceTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceMapResourceTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceMapResourceTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -25,7 +25,7 @@
 
 WebInspector.SourceMapResourceTreeElement = class SourceMapResourceTreeElement extends WebInspector.ResourceTreeElement
 {
-    constructor(sourceMapResource, representedObject)
+    constructor(sourceMapResource)
     {
         console.assert(sourceMapResource instanceof WebInspector.SourceMapResource);
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/StorageTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/StorageTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/StorageTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -27,7 +27,8 @@
 {
     constructor(classNames, title, representedObject)
     {
-        super(classNames, title, null, representedObject, false);
+        const subtitle = null;
+        super(classNames, title, subtitle, representedObject);
 
         this.flattened = false;
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -55,7 +55,7 @@
         let iconStyleClass = WebInspector.TimelineTabContentView.iconClassNameForRecord(timelineRecord);
         let title = WebInspector.TimelineTabContentView.displayNameForRecord(timelineRecord);
 
-        super([iconStyleClass], title, subtitle, representedObject || timelineRecord, false);
+        super([iconStyleClass], title, subtitle, representedObject || timelineRecord);
 
         this._record = timelineRecord;
         this._sourceCodeLocation = sourceCodeLocation;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -28,12 +28,12 @@
 
 WebInspector.TreeElement = class TreeElement extends WebInspector.Object
 {
-    constructor(title, representedObject, hasChildren)
+    constructor(title, representedObject, options = {})
     {
         super();
 
         this._title = title;
-        this.representedObject = (representedObject || {});
+        this.representedObject = representedObject || {};
 
         if (this.representedObject.__treeElementIdentifier)
             this.identifier = this.representedObject.__treeElementIdentifier;
@@ -46,7 +46,7 @@
         this._selectable = true;
         this.expanded = false;
         this.selected = false;
-        this.hasChildren = hasChildren;
+        this.hasChildren = options.hasChildren;
         this.children = [];
         this.treeOutline = null;
         this.parent = null;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.js (220003 => 220004)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.js	2017-07-28 17:06:29 UTC (rev 220003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.js	2017-07-28 17:27:43 UTC (rev 220004)
@@ -27,7 +27,10 @@
 {
     constructor(name, structureDescription, isPrototype)
     {
-        super(null, null, null, structureDescription || null, false);
+        const classNames = null;
+        const title = null;
+        const subtitle = null;
+        super(classNames, title, subtitle, structureDescription || null);
 
         console.assert(!structureDescription || structureDescription instanceof WebInspector.StructureDescription);
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to