Title: [220032] trunk/Tools
- Revision
- 220032
- Author
- dba...@webkit.org
- Date
- 2017-07-28 15:31:37 -0700 (Fri, 28 Jul 2017)
Log Message
prepare-ChangeLog should not list added layout tests in PAL ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=174876
Reviewed by Alex Christensen.
Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
they provide a more direct way to test the platform abstraction.
As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
* Scripts/prepare-ChangeLog:
(generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
of the current working directory.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (220031 => 220032)
--- trunk/Tools/ChangeLog 2017-07-28 22:21:02 UTC (rev 220031)
+++ trunk/Tools/ChangeLog 2017-07-28 22:31:37 UTC (rev 220032)
@@ -1,3 +1,20 @@
+2017-07-28 Daniel Bates <daba...@apple.com>
+
+ prepare-ChangeLog should not list added layout tests in PAL ChangeLog
+ https://bugs.webkit.org/show_bug.cgi?id=174876
+
+ Reviewed by Alex Christensen.
+
+ Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
+ to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
+ they provide a more direct way to test the platform abstraction.
+
+ As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
+
+ * Scripts/prepare-ChangeLog:
+ (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
+ of the current working directory.
+
2017-07-28 Jonathan Bedard <jbed...@apple.com>
Using "auto <function()> -> returnType" breaks prepare-ChangeLog
Modified: trunk/Tools/Scripts/prepare-ChangeLog (220031 => 220032)
--- trunk/Tools/Scripts/prepare-ChangeLog 2017-07-28 22:21:02 UTC (rev 220031)
+++ trunk/Tools/Scripts/prepare-ChangeLog 2017-07-28 22:31:37 UTC (rev 220032)
@@ -688,7 +688,7 @@
print CHANGE_LOG normalizeLineEndings(" Reviewed by $reviewer.\n\n", $endl);
print CHANGE_LOG normalizeLineEndings($description . "\n", $endl) if $description;
- if ($prefix =~ m/WebCore/ || `pwd` =~ m/WebCore/ || @$requiresTests) {
+ if (unixPath($prefix) =~ m|/WebCore/$| || @$requiresTests) {
if (@$addedRegressionTests) {
print CHANGE_LOG normalizeLineEndings(testListForChangeLog(sort @$addedRegressionTests), $endl);
} else {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
