Diff
Modified: trunk/Source/WebCore/ChangeLog (220150 => 220151)
--- trunk/Source/WebCore/ChangeLog 2017-08-02 20:01:32 UTC (rev 220150)
+++ trunk/Source/WebCore/ChangeLog 2017-08-02 20:45:42 UTC (rev 220151)
@@ -1,3 +1,17 @@
+2017-08-02 Jeremy Jones <[email protected]>
+
+ Remove unused and obsolete setting mediaDocumentEntersFullscreenAutomatically
+ https://bugs.webkit.org/show_bug.cgi?id=175080
+
+ Reviewed by Jon Lee.
+
+ No new tests because this only removes unused code.
+
+ This is obsolete because of the alternate solution in
+ https://bugs.webkit.org/show_bug.cgi?id=174850
+
+ * page/Settings.in:
+
2017-08-02 Filip Pizlo <[email protected]>
GPUBuffer::length() should return the size of the array buffer backing the GPU buffer, not the rounded-up GPU buffer length
Modified: trunk/Source/WebCore/page/Settings.in (220150 => 220151)
--- trunk/Source/WebCore/page/Settings.in 2017-08-02 20:01:32 UTC (rev 220150)
+++ trunk/Source/WebCore/page/Settings.in 2017-08-02 20:45:42 UTC (rev 220151)
@@ -216,7 +216,6 @@
allowMultiElementImplicitSubmission initial=false
allowsAirPlayForMediaPlayback initial=true, conditional=WIRELESS_PLAYBACK_TARGET
-mediaDocumentEntersFullscreenAutomatically initial=false
shouldConvertPositionStyleOnCopy initial=false
Modified: trunk/Source/WebKit/ChangeLog (220150 => 220151)
--- trunk/Source/WebKit/ChangeLog 2017-08-02 20:01:32 UTC (rev 220150)
+++ trunk/Source/WebKit/ChangeLog 2017-08-02 20:45:42 UTC (rev 220151)
@@ -1,3 +1,21 @@
+2017-08-02 Jeremy Jones <[email protected]>
+
+ Remove unused and obsolete setting mediaDocumentEntersFullscreenAutomatically
+ https://bugs.webkit.org/show_bug.cgi?id=175080
+
+ Reviewed by Jon Lee.
+
+ This is obsolete because of the alternate solution in
+ https://bugs.webkit.org/show_bug.cgi?id=174850
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences _setMediaDocumentEntersFullscreenAutomatically:]): Deleted.
+ (-[WKPreferences _mediaDocumentEntersFullscreenAutomatically]): Deleted.
+ * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences):
+
2017-08-02 Filip Pizlo <[email protected]>
We should be OK with the gigacage being disabled on gmalloc
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefinitions.h (220150 => 220151)
--- trunk/Source/WebKit/Shared/WebPreferencesDefinitions.h 2017-08-02 20:01:32 UTC (rev 220150)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefinitions.h 2017-08-02 20:45:42 UTC (rev 220151)
@@ -195,7 +195,6 @@
macro(AllowsPictureInPictureMediaPlayback, allowsPictureInPictureMediaPlayback, Bool, bool, DEFAULT_ALLOWS_PICTURE_IN_PICTURE_MEDIA_PLAYBACK, "", "") \
macro(AllowsAirPlayForMediaPlayback, allowsAirPlayForMediaPlayback, Bool, bool, true, "", "") \
macro(MediaControlsScaleWithPageZoom, mediaControlsScaleWithPageZoom, Bool, bool, DEFAULT_MEDIA_CONTROLS_SCALE_WITH_PAGE_ZOOM, "", "") \
- macro(MediaDocumentEntersFullscreenAutomatically, mediaDocumentEntersFullscreenAutomatically, Bool, bool, false, "", "") \
macro(InspectorStartsAttached, inspectorStartsAttached, Bool, bool, true, "", "") \
macro(ShowsToolTipOverTruncatedText, showsToolTipOverTruncatedText, Bool, bool, false, "", "") \
macro(MockScrollbarsEnabled, mockScrollbarsEnabled, Bool, bool, false, "", "") \
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (220150 => 220151)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2017-08-02 20:01:32 UTC (rev 220150)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2017-08-02 20:45:42 UTC (rev 220151)
@@ -637,16 +637,6 @@
return _preferences->domPasteAllowed();
}
-- (void)_setMediaDocumentEntersFullscreenAutomatically:(BOOL)mediaDocumentEntersFullscreenAutomatically
-{
- _preferences->setMediaDocumentEntersFullscreenAutomatically(mediaDocumentEntersFullscreenAutomatically);
-}
-
-- (BOOL)_mediaDocumentEntersFullscreenAutomatically
-{
- return _preferences->mediaDocumentEntersFullscreenAutomatically();
-}
-
@end
#endif // WK_API_ENABLED
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h (220150 => 220151)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2017-08-02 20:01:32 UTC (rev 220150)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2017-08-02 20:45:42 UTC (rev 220151)
@@ -109,8 +109,6 @@
@property (nonatomic, setter=_setJavaScriptCanAccessClipboard:) BOOL _javaScriptCanAccessClipboard WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
@property (nonatomic, setter=_setDOMPasteAllowed:) BOOL _domPasteAllowed WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
-@property (nonatomic, setter=_setMediaDocumentEntersFullscreenAutomatically:) BOOL _mediaDocumentEntersFullscreenAutomatically WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
-
+ (NSArray<_WKExperimentalFeature *> *)_experimentalFeatures WK_API_AVAILABLE(macosx(10.12), ios(10.0));
- (BOOL)_isEnabledForFeature:(_WKExperimentalFeature *)feature WK_API_AVAILABLE(macosx(10.12), ios(10.0));
- (void)_setEnabled:(BOOL)value forFeature:(_WKExperimentalFeature *)feature WK_API_AVAILABLE(macosx(10.12), ios(10.0));
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (220150 => 220151)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2017-08-02 20:01:32 UTC (rev 220150)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2017-08-02 20:45:42 UTC (rev 220151)
@@ -3378,8 +3378,6 @@
settings.setMediaContentTypesRequiringHardwareSupport(store.getStringValueForKey(WebPreferencesKey::mediaContentTypesRequiringHardwareSupportKey()));
settings.setAllowMediaContentTypesRequiringHardwareSupportAsFallback(store.getBoolValueForKey(WebPreferencesKey::allowMediaContentTypesRequiringHardwareSupportAsFallbackKey()));
- settings.setMediaDocumentEntersFullscreenAutomatically(store.getBoolValueForKey(WebPreferencesKey::mediaDocumentEntersFullscreenAutomaticallyKey()));
-
#if ENABLE(LEGACY_ENCRYPTED_MEDIA)
RuntimeEnabledFeatures::sharedFeatures().setLegacyEncryptedMediaAPIEnabled(store.getBoolValueForKey(WebPreferencesKey::legacyEncryptedMediaAPIEnabledKey()));
#endif
