Title: [220153] trunk/Source/WebCore
- Revision
- 220153
- Author
- [email protected]
- Date
- 2017-08-02 14:50:13 -0700 (Wed, 02 Aug 2017)
Log Message
[MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
https://bugs.webkit.org/show_bug.cgi?id=175091
Reviewed by Eric Carlson.
Address follow-up comments to r219519.
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removeCodedFrames):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (220152 => 220153)
--- trunk/Source/WebCore/ChangeLog 2017-08-02 20:51:49 UTC (rev 220152)
+++ trunk/Source/WebCore/ChangeLog 2017-08-02 21:50:13 UTC (rev 220153)
@@ -1,3 +1,15 @@
+2017-08-02 Jer Noble <[email protected]>
+
+ [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
+ https://bugs.webkit.org/show_bug.cgi?id=175091
+
+ Reviewed by Eric Carlson.
+
+ Address follow-up comments to r219519.
+
+ * Modules/mediasource/SourceBuffer.cpp:
+ (WebCore::SourceBuffer::removeCodedFrames):
+
2017-08-02 Jeremy Jones <[email protected]>
Remove unused and obsolete setting mediaDocumentEntersFullscreenAutomatically
Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp (220152 => 220153)
--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2017-08-02 20:51:49 UTC (rev 220152)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2017-08-02 21:50:13 UTC (rev 220153)
@@ -768,7 +768,7 @@
auto removePresentationStart = trackBuffer.samples.presentationOrder().findSampleContainingOrAfterPresentationTime(start);
auto removePresentationEnd = trackBuffer.samples.presentationOrder().findSampleStartingAfterPresentationTime(end);
- if (start == end)
+ if (removePresentationStart == removePresentationEnd)
continue;
// 3.3 Remove all media data, from this track buffer, that contain starting timestamps greater than or equal to
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
