Title: [220251] trunk/Source/WebInspectorUI
- Revision
- 220251
- Author
- [email protected]
- Date
- 2017-08-03 20:57:29 -0700 (Thu, 03 Aug 2017)
Log Message
JSContext Inspector: Scripts sometimes do not show in resources tab
https://bugs.webkit.org/show_bug.cgi?id=175153
<rdar://problem/33708683>
Patch by Joseph Pecoraro <[email protected]> on 2017-08-03
Reviewed by Matt Baker.
* UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel.prototype.initialLayout):
When the ResourceSidebar is lazily created, be sure to add any scripts
to the sidebar that are not backed by Resources.
(WI.ResourceSidebarPanel.prototype._scriptWasAdded):
(WI.ResourceSidebarPanel.prototype._addScript):
Extract so it can be used outside of an event handler.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (220250 => 220251)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-08-04 02:41:16 UTC (rev 220250)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-08-04 03:57:29 UTC (rev 220251)
@@ -1,3 +1,20 @@
+2017-08-03 Joseph Pecoraro <[email protected]>
+
+ JSContext Inspector: Scripts sometimes do not show in resources tab
+ https://bugs.webkit.org/show_bug.cgi?id=175153
+ <rdar://problem/33708683>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/ResourceSidebarPanel.js:
+ (WI.ResourceSidebarPanel.prototype.initialLayout):
+ When the ResourceSidebar is lazily created, be sure to add any scripts
+ to the sidebar that are not backed by Resources.
+
+ (WI.ResourceSidebarPanel.prototype._scriptWasAdded):
+ (WI.ResourceSidebarPanel.prototype._addScript):
+ Extract so it can be used outside of an event handler.
+
2017-08-03 Devin Rousso <[email protected]>
Web Inspector: add button to open Inspector^2
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js (220250 => 220251)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2017-08-04 02:41:16 UTC (rev 220250)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2017-08-04 03:57:29 UTC (rev 220251)
@@ -201,6 +201,13 @@
if (WI.frameResourceManager.mainFrame)
this._mainFrameMainResourceDidChange(WI.frameResourceManager.mainFrame);
+
+ for (let script of WI.debuggerManager.knownNonResourceScripts) {
+ this._addScript(script);
+
+ if (script.sourceMaps.length && WI.debuggableType === WI.DebuggableType._javascript_)
+ this.contentTreeOutline.disclosureButtons = true;
+ }
}
hasCustomFilters()
@@ -298,8 +305,11 @@
_scriptWasAdded(event)
{
- var script = event.data.script;
+ this._addScript(event.data.script);
+ }
+ _addScript(script)
+ {
// We don't add scripts without URLs here. Those scripts can quickly clutter the interface and
// are usually more transient. They will get added if/when they need to be shown in a content view.
if (!script.url && !script.sourceURL)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
