Title: [220287] trunk/Tools
- Revision
- 220287
- Author
- [email protected]
- Date
- 2017-08-04 13:01:16 -0700 (Fri, 04 Aug 2017)
Log Message
Dashboard bubbles sometimes show failure count instead of crash count
https://bugs.webkit.org/show_bug.cgi?id=175157
<rdar://problem/33709009>
Reviewed by Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
(BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js (220286 => 220287)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js 2017-08-04 19:50:23 UTC (rev 220286)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js 2017-08-04 20:01:16 UTC (rev 220287)
@@ -75,10 +75,11 @@
function resultSummarizer(matchString, sum, outputLine)
{
- var match = /^(\d+)\s/.exec(outputLine);
+ // Sample outputLine: "53 failures 37 new passes 1 crashes"
+ var regex = new RegExp("(\\d+)\\s" + matchString);
+ match = regex.exec(outputLine);
if (!match) {
- var regex = new RegExp("(\\d+)\\s" + matchString);
- match = regex.exec(outputLine);
+ match = /^(\d+)\s/.exec(outputLine);
}
if (!match)
return sum;
Modified: trunk/Tools/ChangeLog (220286 => 220287)
--- trunk/Tools/ChangeLog 2017-08-04 19:50:23 UTC (rev 220286)
+++ trunk/Tools/ChangeLog 2017-08-04 20:01:16 UTC (rev 220287)
@@ -1,3 +1,14 @@
+2017-08-04 Aakash Jain <[email protected]>
+
+ Dashboard bubbles sometimes show failure count instead of crash count
+ https://bugs.webkit.org/show_bug.cgi?id=175157
+ <rdar://problem/33709009>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
+ (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
+
2017-08-04 Joseph Pecoraro <[email protected]>
Add tests for NeverDestroyed
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
