Title: [220337] trunk/Source/WebCore
- Revision
- 220337
- Author
- [email protected]
- Date
- 2017-08-07 09:32:24 -0700 (Mon, 07 Aug 2017)
Log Message
Cleanup: simplify WebSockets code for RuntimeEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=175190
Reviewed by Sam Weinig.
This runtime enabled flag is not used by anything. It was added
for V8 in <https://bugs.webkit.org/show_bug.cgi?id=29896>.
* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::setIsAvailable): Deleted.
(WebCore::WebSocket::isAvailable): Deleted.
* Modules/websockets/WebSocket.h:
* Modules/websockets/WebSocket.idl:
* page/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::webSocketEnabled const): Deleted.
* page/RuntimeEnabledFeatures.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (220336 => 220337)
--- trunk/Source/WebCore/ChangeLog 2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/ChangeLog 2017-08-07 16:32:24 UTC (rev 220337)
@@ -1,5 +1,24 @@
2017-08-07 Brian Burg <[email protected]>
+ Cleanup: simplify WebSockets code for RuntimeEnabledFeatures
+ https://bugs.webkit.org/show_bug.cgi?id=175190
+
+ Reviewed by Sam Weinig.
+
+ This runtime enabled flag is not used by anything. It was added
+ for V8 in <https://bugs.webkit.org/show_bug.cgi?id=29896>.
+
+ * Modules/websockets/WebSocket.cpp:
+ (WebCore::WebSocket::setIsAvailable): Deleted.
+ (WebCore::WebSocket::isAvailable): Deleted.
+ * Modules/websockets/WebSocket.h:
+ * Modules/websockets/WebSocket.idl:
+ * page/RuntimeEnabledFeatures.cpp:
+ (WebCore::RuntimeEnabledFeatures::webSocketEnabled const): Deleted.
+ * page/RuntimeEnabledFeatures.h:
+
+2017-08-07 Brian Burg <[email protected]>
+
Remove CANVAS_PATH compilation guard
https://bugs.webkit.org/show_bug.cgi?id=175207
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.cpp (220336 => 220337)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.cpp 2017-08-07 16:32:24 UTC (rev 220337)
@@ -126,18 +126,6 @@
return a + b;
}
-static bool webSocketsAvailable = true;
-
-void WebSocket::setIsAvailable(bool available)
-{
- webSocketsAvailable = available;
-}
-
-bool WebSocket::isAvailable()
-{
- return webSocketsAvailable;
-}
-
const char* WebSocket::subprotocolSeparator()
{
return ", ";
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.h (220336 => 220337)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.h 2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.h 2017-08-07 16:32:24 UTC (rev 220337)
@@ -52,9 +52,6 @@
class WebSocket final : public RefCounted<WebSocket>, public EventTargetWithInlineData, public ActiveDOMObject, private WebSocketChannelClient {
public:
- static void setIsAvailable(bool);
- static bool isAvailable();
-
static const char* subprotocolSeparator();
static ExceptionOr<Ref<WebSocket>> create(ScriptExecutionContext&, const String& url);
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.idl (220336 => 220337)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.idl 2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.idl 2017-08-07 16:32:24 UTC (rev 220337)
@@ -35,7 +35,6 @@
Constructor(USVString url, DOMString protocol),
ConstructorMayThrowException,
ConstructorCallWith=ScriptExecutionContext,
- EnabledAtRuntime=WebSocket,
Exposed=(Window,Worker),
] interface WebSocket : EventTarget {
readonly attribute USVString URL; // Lowercased .url is the one in the spec, but leaving .URL for compatibility reasons.
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp (220336 => 220337)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp 2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp 2017-08-07 16:32:24 UTC (rev 220337)
@@ -33,7 +33,6 @@
#include "RuntimeEnabledFeatures.h"
#include "MediaPlayer.h"
-#include "WebSocket.h"
#include <wtf/NeverDestroyed.h>
namespace WebCore {
@@ -59,9 +58,4 @@
}
#endif
-bool RuntimeEnabledFeatures::webSocketEnabled() const
-{
- return WebSocket::isAvailable();
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (220336 => 220337)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2017-08-07 16:32:24 UTC (rev 220337)
@@ -207,8 +207,6 @@
bool audioEnabled() const;
#endif
- bool webSocketEnabled() const;
-
WEBCORE_EXPORT static RuntimeEnabledFeatures& sharedFeatures();
private:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
