Title: [220381] trunk/Source/WebCore
- Revision
- 220381
- Author
- simon.fra...@apple.com
- Date
- 2017-08-07 19:52:06 -0700 (Mon, 07 Aug 2017)
Log Message
Re-order the tests in RenderLayerCompositor::requiresCompositingLayer() for performance
https://bugs.webkit.org/show_bug.cgi?id=175306
Reviewed by Tim Horton.
Re-order the tests for compositing reasons so that reasons more likely to happen are higher in the list.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (220380 => 220381)
--- trunk/Source/WebCore/ChangeLog 2017-08-08 02:52:05 UTC (rev 220380)
+++ trunk/Source/WebCore/ChangeLog 2017-08-08 02:52:06 UTC (rev 220381)
@@ -1,5 +1,18 @@
2017-08-07 Simon Fraser <simon.fra...@apple.com>
+ Re-order the tests in RenderLayerCompositor::requiresCompositingLayer() for performance
+ https://bugs.webkit.org/show_bug.cgi?id=175306
+
+ Reviewed by Tim Horton.
+
+ Re-order the tests for compositing reasons so that reasons more likely to happen are higher in the list.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::requiresCompositingLayer const):
+ (WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
+
+2017-08-07 Simon Fraser <simon.fra...@apple.com>
+
Avoid a hash lookup in FilterInfo::remove()
https://bugs.webkit.org/show_bug.cgi?id=175301
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (220380 => 220381)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2017-08-08 02:52:05 UTC (rev 220380)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2017-08-08 02:52:06 UTC (rev 220381)
@@ -2173,16 +2173,16 @@
// The root layer always has a compositing layer, but it may not have backing.
return requiresCompositingForTransform(renderer)
- || requiresCompositingForVideo(renderer)
+ || requiresCompositingForAnimation(renderer)
+ || clipsCompositingDescendants(*renderer.layer())
+ || requiresCompositingForPosition(renderer, *renderer.layer(), viewportConstrainedNotCompositedReason)
|| requiresCompositingForCanvas(renderer)
- || requiresCompositingForPlugin(renderer)
- || requiresCompositingForFrame(renderer)
- || requiresCompositingForBackfaceVisibility(renderer)
- || clipsCompositingDescendants(*renderer.layer())
- || requiresCompositingForAnimation(renderer)
|| requiresCompositingForFilters(renderer)
|| requiresCompositingForWillChange(renderer)
- || requiresCompositingForPosition(renderer, *renderer.layer(), viewportConstrainedNotCompositedReason)
+ || requiresCompositingForBackfaceVisibility(renderer)
+ || requiresCompositingForVideo(renderer)
+ || requiresCompositingForFrame(renderer)
+ || requiresCompositingForPlugin(renderer)
#if PLATFORM(IOS)
|| requiresCompositingForScrolling(*renderer.layer())
#endif
@@ -2217,15 +2217,15 @@
if (layer.isRootLayer()
|| layer.transform() // note: excludes perspective and transformStyle3D.
- || requiresCompositingForVideo(renderer)
+ || requiresCompositingForAnimation(renderer)
+ || requiresCompositingForPosition(renderer, layer)
|| requiresCompositingForCanvas(renderer)
- || requiresCompositingForPlugin(renderer)
- || requiresCompositingForFrame(renderer)
- || requiresCompositingForBackfaceVisibility(renderer)
- || requiresCompositingForAnimation(renderer)
|| requiresCompositingForFilters(renderer)
|| requiresCompositingForWillChange(renderer)
- || requiresCompositingForPosition(renderer, layer)
+ || requiresCompositingForBackfaceVisibility(renderer)
+ || requiresCompositingForVideo(renderer)
+ || requiresCompositingForFrame(renderer)
+ || requiresCompositingForPlugin(renderer)
|| requiresCompositingForOverflowScrolling(layer)
|| renderer.isTransparent()
|| renderer.hasMask()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
