Title: [220465] trunk/Source
Revision
220465
Author
ryanhad...@apple.com
Date
2017-08-09 10:58:12 -0700 (Wed, 09 Aug 2017)

Log Message

Unreviewed, rolling out r220457.

This change introduced API test failures.

Reverted changeset:

"WTF::Function does not allow for reference / non-default
constructible return types"
https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220457

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (220464 => 220465)


--- trunk/Source/_javascript_Core/ChangeLog	2017-08-09 17:53:09 UTC (rev 220464)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-08-09 17:58:12 UTC (rev 220465)
@@ -1,3 +1,16 @@
+2017-08-09  Ryan Haddad  <ryanhad...@apple.com>
+
+        Unreviewed, rolling out r220457.
+
+        This change introduced API test failures.
+
+        Reverted changeset:
+
+        "WTF::Function does not allow for reference / non-default
+        constructible return types"
+        https://bugs.webkit.org/show_bug.cgi?id=175244
+        http://trac.webkit.org/changeset/220457
+
 2017-08-09  Sam Weinig  <s...@webkit.org>
 
         WTF::Function does not allow for reference / non-default constructible return types

Modified: trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp (220464 => 220465)


--- trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp	2017-08-09 17:53:09 UTC (rev 220464)
+++ trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp	2017-08-09 17:58:12 UTC (rev 220465)
@@ -132,7 +132,7 @@
     other.m_sizeInBytes = m_sizeInBytes;
     other.m_destructor = WTFMove(m_destructor);
     other.m_shared = m_shared;
-    reset();
+    clear();
 }
 
 void ArrayBufferContents::copyTo(ArrayBufferContents& other)

Modified: trunk/Source/WTF/ChangeLog (220464 => 220465)


--- trunk/Source/WTF/ChangeLog	2017-08-09 17:53:09 UTC (rev 220464)
+++ trunk/Source/WTF/ChangeLog	2017-08-09 17:58:12 UTC (rev 220465)
@@ -1,3 +1,16 @@
+2017-08-09  Ryan Haddad  <ryanhad...@apple.com>
+
+        Unreviewed, rolling out r220457.
+
+        This change introduced API test failures.
+
+        Reverted changeset:
+
+        "WTF::Function does not allow for reference / non-default
+        constructible return types"
+        https://bugs.webkit.org/show_bug.cgi?id=175244
+        http://trac.webkit.org/changeset/220457
+
 2017-08-09  Sam Weinig  <s...@webkit.org>
 
         WTF::Function does not allow for reference / non-default constructible return types

Modified: trunk/Source/WTF/wtf/Function.h (220464 => 220465)


--- trunk/Source/WTF/wtf/Function.h	2017-08-09 17:53:09 UTC (rev 220464)
+++ trunk/Source/WTF/wtf/Function.h	2017-08-09 17:58:12 UTC (rev 220465)
@@ -52,8 +52,9 @@
 
     Out operator()(In... in) const
     {
-        ASSERT(m_callableWrapper);
-        return m_callableWrapper->call(std::forward<In>(in)...);
+        if (m_callableWrapper)
+            return m_callableWrapper->call(std::forward<In>(in)...);
+        return Out();
     }
 
     explicit operator bool() const { return !!m_callableWrapper; }

Modified: trunk/Source/WebCore/ChangeLog (220464 => 220465)


--- trunk/Source/WebCore/ChangeLog	2017-08-09 17:53:09 UTC (rev 220464)
+++ trunk/Source/WebCore/ChangeLog	2017-08-09 17:58:12 UTC (rev 220465)
@@ -1,3 +1,16 @@
+2017-08-09  Ryan Haddad  <ryanhad...@apple.com>
+
+        Unreviewed, rolling out r220457.
+
+        This change introduced API test failures.
+
+        Reverted changeset:
+
+        "WTF::Function does not allow for reference / non-default
+        constructible return types"
+        https://bugs.webkit.org/show_bug.cgi?id=175244
+        http://trac.webkit.org/changeset/220457
+
 2017-08-09  Don Olmstead  <don.olmst...@sony.com>
 
         [WinCairo] Fix build after rev 220399

Modified: trunk/Source/WebCore/bindings/js/JSCustomElementInterface.h (220464 => 220465)


--- trunk/Source/WebCore/bindings/js/JSCustomElementInterface.h	2017-08-09 17:53:09 UTC (rev 220464)
+++ trunk/Source/WebCore/bindings/js/JSCustomElementInterface.h	2017-08-09 17:58:12 UTC (rev 220465)
@@ -94,7 +94,7 @@
 
     RefPtr<Element> tryToConstructCustomElement(Document&, const AtomicString&);
 
-    void invokeCallback(Element&, JSC::JSObject* callback, const WTF::Function<void(JSC::ExecState*, JSDOMGlobalObject*, JSC::MarkedArgumentBuffer&)>& addArguments = [](JSC::ExecState*, JSDOMGlobalObject*, JSC::MarkedArgumentBuffer&) { });
+    void invokeCallback(Element&, JSC::JSObject* callback, const WTF::Function<void(JSC::ExecState*, JSDOMGlobalObject*, JSC::MarkedArgumentBuffer&)>& addArguments = { });
 
     QualifiedName m_name;
     JSC::Weak<JSC::JSObject> m_constructor;

Modified: trunk/Source/WebKit/ChangeLog (220464 => 220465)


--- trunk/Source/WebKit/ChangeLog	2017-08-09 17:53:09 UTC (rev 220464)
+++ trunk/Source/WebKit/ChangeLog	2017-08-09 17:58:12 UTC (rev 220465)
@@ -1,3 +1,16 @@
+2017-08-09  Ryan Haddad  <ryanhad...@apple.com>
+
+        Unreviewed, rolling out r220457.
+
+        This change introduced API test failures.
+
+        Reverted changeset:
+
+        "WTF::Function does not allow for reference / non-default
+        constructible return types"
+        https://bugs.webkit.org/show_bug.cgi?id=175244
+        http://trac.webkit.org/changeset/220457
+
 2017-08-09  Daniel Bates  <daba...@apple.com>
 
         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication

Modified: trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h (220464 => 220465)


--- trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h	2017-08-09 17:53:09 UTC (rev 220464)
+++ trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h	2017-08-09 17:58:12 UTC (rev 220465)
@@ -60,7 +60,7 @@
 class WebResourceLoadStatisticsStore final : public IPC::Connection::WorkQueueMessageReceiver {
 public:
     using UpdateCookiePartitioningForDomainsHandler = WTF::Function<void(const Vector<String>& domainsToRemove, const Vector<String>& domainsToAdd, ShouldClearFirst)>;
-    static Ref<WebResourceLoadStatisticsStore> create(const String& resourceLoadStatisticsDirectory, Function<void (const String&)>&& testingCallback, UpdateCookiePartitioningForDomainsHandler&& updateCookiePartitioningForDomainsHandler = [](const Vector<String>&, const Vector<String>&, ShouldClearFirst) { })
+    static Ref<WebResourceLoadStatisticsStore> create(const String& resourceLoadStatisticsDirectory, Function<void (const String&)>&& testingCallback, UpdateCookiePartitioningForDomainsHandler&& updateCookiePartitioningForDomainsHandler = { })
     {
         return adoptRef(*new WebResourceLoadStatisticsStore(resourceLoadStatisticsDirectory, WTFMove(testingCallback), WTFMove(updateCookiePartitioningForDomainsHandler)));
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to