Title: [220486] trunk/LayoutTests
Revision
220486
Author
n_w...@apple.com
Date
2017-08-09 15:36:04 -0700 (Wed, 09 Aug 2017)

Log Message

LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=175194

Reviewed by Chris Fleizach.

In the test we have no way to control which iframe will be loaded first.
Output the logs at the end of the test so that they are in order.

* accessibility/presentation-role-iframe.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (220485 => 220486)


--- trunk/LayoutTests/ChangeLog	2017-08-09 22:33:27 UTC (rev 220485)
+++ trunk/LayoutTests/ChangeLog	2017-08-09 22:36:04 UTC (rev 220486)
@@ -1,3 +1,15 @@
+2017-08-09  Nan Wang  <n_w...@apple.com>
+
+        LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=175194
+
+        Reviewed by Chris Fleizach.
+
+        In the test we have no way to control which iframe will be loaded first.
+        Output the logs at the end of the test so that they are in order.
+
+        * accessibility/presentation-role-iframe.html:
+
 2017-08-09  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r219334.

Modified: trunk/LayoutTests/accessibility/presentation-role-iframe.html (220485 => 220486)


--- trunk/LayoutTests/accessibility/presentation-role-iframe.html	2017-08-09 22:33:27 UTC (rev 220485)
+++ trunk/LayoutTests/accessibility/presentation-role-iframe.html	2017-08-09 22:36:04 UTC (rev 220486)
@@ -30,6 +30,10 @@
 var test2Ran = false;
 var test3Ran = false;
 
+var test1Log; 
+var test2Log; 
+var test3Log;
+
 // Run the test for a iframe that has presentation role and one that does not.
 // The children should be different.
 function runTest(testNumber)
@@ -36,21 +40,31 @@
 {
   if (window.accessibilityController) {
     var content = accessibilityController.accessibleElementById("content" + testNumber);
-    debug(testNumber + ". Content child: " + content.childAtIndex(0).role);
-    debug(testNumber + ". Content grand child: " + content.childAtIndex(0).childAtIndex(0).role);
     if (testNumber == 1) {
          test1Ran = true;
+         test1Log = testLog(content, testNumber);
     } else if (testNumber == 2) {
          test2Ran = true;
+         test2Log = testLog(content, testNumber);
     } else if (testNumber == 3) {
          test3Ran = true;
+         test3Log = testLog(content, testNumber);
     }
 
     if (test3Ran && test2Ran && test1Ran) {
+        debug(test1Log);
+        debug(test2Log);
+        debug(test3Log);
         finishJSTest();
     }
   }
 }
+
+function testLog(content, testNumber) {
+    var result = testNumber + ". Content child: " + content.childAtIndex(0).role;
+    result += "\n" + testNumber + ". Content grand child: " + content.childAtIndex(0).childAtIndex(0).role;
+    return result;
+}
 </script>
 
 </body>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to