Title: [220566] trunk/Source/WebCore
- Revision
- 220566
- Author
- utatane....@gmail.com
- Date
- 2017-08-10 17:36:23 -0700 (Thu, 10 Aug 2017)
Log Message
[JSC] Use @toNumber in builtins
https://bugs.webkit.org/show_bug.cgi?id=172692
Reviewed by Sam Weinig.
Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
a given argument to a number.
* Modules/streams/ReadableByteStreamInternals.js:
(privateInitializeReadableByteStreamController):
(readableByteStreamControllerRespond):
* Modules/streams/StreamInternals.js:
(validateAndNormalizeQueuingStrategy):
(enqueueValueWithSize):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (220565 => 220566)
--- trunk/Source/WebCore/ChangeLog 2017-08-11 00:29:03 UTC (rev 220565)
+++ trunk/Source/WebCore/ChangeLog 2017-08-11 00:36:23 UTC (rev 220566)
@@ -1,3 +1,20 @@
+2017-08-10 Yusuke Suzuki <utatane....@gmail.com>
+
+ [JSC] Use @toNumber in builtins
+ https://bugs.webkit.org/show_bug.cgi?id=172692
+
+ Reviewed by Sam Weinig.
+
+ Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
+ a given argument to a number.
+
+ * Modules/streams/ReadableByteStreamInternals.js:
+ (privateInitializeReadableByteStreamController):
+ (readableByteStreamControllerRespond):
+ * Modules/streams/StreamInternals.js:
+ (validateAndNormalizeQueuingStrategy):
+ (enqueueValueWithSize):
+
2017-08-10 Nan Wang <n_w...@apple.com>
AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
Modified: trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js (220565 => 220566)
--- trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js 2017-08-11 00:29:03 UTC (rev 220565)
+++ trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js 2017-08-11 00:36:23 UTC (rev 220566)
@@ -64,7 +64,7 @@
this.@started = false;
this.@closeRequested = false;
- let hwm = @Number(highWaterMark);
+ let hwm = @toNumber(highWaterMark);
if (@isNaN(hwm) || hwm < 0)
@throwRangeError("highWaterMark value is negative or not a number");
this.@strategyHWM = hwm;
@@ -71,7 +71,7 @@
let autoAllocateChunkSize = underlyingByteSource.autoAllocateChunkSize;
if (autoAllocateChunkSize !== @undefined) {
- autoAllocateChunkSize = @Number(autoAllocateChunkSize);
+ autoAllocateChunkSize = @toNumber(autoAllocateChunkSize);
if (autoAllocateChunkSize <= 0 || autoAllocateChunkSize === @Number.POSITIVE_INFINITY || autoAllocateChunkSize === @Number.NEGATIVE_INFINITY)
@throwRangeError("autoAllocateChunkSize value is negative or equal to positive or negative infinity");
}
@@ -393,7 +393,7 @@
{
"use strict";
- bytesWritten = @Number(bytesWritten);
+ bytesWritten = @toNumber(bytesWritten);
if (@isNaN(bytesWritten) || bytesWritten === @Number.POSITIVE_INFINITY || bytesWritten < 0 )
@throwRangeError("bytesWritten has an incorrect value");
Modified: trunk/Source/WebCore/Modules/streams/StreamInternals.js (220565 => 220566)
--- trunk/Source/WebCore/Modules/streams/StreamInternals.js 2017-08-11 00:29:03 UTC (rev 220565)
+++ trunk/Source/WebCore/Modules/streams/StreamInternals.js 2017-08-11 00:36:23 UTC (rev 220566)
@@ -84,7 +84,7 @@
const normalizedStrategy = { };
normalizedStrategy.size = size;
- normalizedStrategy.highWaterMark = @Number(highWaterMark);
+ normalizedStrategy.highWaterMark = @toNumber(highWaterMark);
if (@isNaN(normalizedStrategy.highWaterMark) || normalizedStrategy.highWaterMark < 0)
@throwRangeError("highWaterMark value is negative or not a number");
@@ -112,7 +112,7 @@
{
"use strict";
- size = @Number(size);
+ size = @toNumber(size);
if (!@isFinite(size) || size < 0)
@throwRangeError("size has an incorrect value");
queue.content.@push({ value: value, size: size });
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
