Title: [220603] trunk/Source/_javascript_Core
Revision
220603
Author
fpi...@apple.com
Date
2017-08-11 10:26:59 -0700 (Fri, 11 Aug 2017)

Log Message

Unreviewed, add a FIXME.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::caged):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (220602 => 220603)


--- trunk/Source/_javascript_Core/ChangeLog	2017-08-11 17:26:34 UTC (rev 220602)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-08-11 17:26:59 UTC (rev 220603)
@@ -1,3 +1,10 @@
+2017-08-11  Filip Pizlo  <fpi...@apple.com>
+
+        Unreviewed, add a FIXME.
+
+        * ftl/FTLLowerDFGToB3.cpp:
+        (JSC::FTL::DFG::LowerDFGToB3::caged):
+
 2017-08-10  Sam Weinig  <s...@webkit.org>
 
         WTF::Function does not allow for reference / non-default constructible return types

Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (220602 => 220603)


--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2017-08-11 17:26:34 UTC (rev 220602)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2017-08-11 17:26:59 UTC (rev 220603)
@@ -11639,6 +11639,8 @@
         // compute here will get reassociated and folded with Gigacage::basePtr. There's a world in which
         // moveConstants() observes that it needs to reassociate in order to hoist the big constants. But
         // it's much easier to just block B3's badness here. That's what we do for now.
+        // FIXME: It would be better if we didn't have to do this hack.
+        // https://bugs.webkit.org/show_bug.cgi?id=175483
         PatchpointValue* patchpoint = m_out.patchpoint(pointerType());
         patchpoint->appendSomeRegister(basePtr);
         patchpoint->appendSomeRegister(masked);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to