Title: [220609] trunk/Source/WebInspectorUI
Revision
220609
Author
nvasil...@apple.com
Date
2017-08-11 14:08:58 -0700 (Fri, 11 Aug 2017)

Log Message

Web Inspector: Styles: Update the filter icon to match Xcode
https://bugs.webkit.org/show_bug.cgi?id=175458
<rdar://problem/33838660>

Reviewed by Matt Baker.

* UserInterface/Images/FilterFieldGlyph.svg:
Half-pixel transform is necessary for a cleaner rasterisation.

* UserInterface/Views/FilterBar.css:
(.filter-bar > input[type="search"]::-webkit-search-decoration):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
::-webkit-search-decoration is a flexbox item. Remove `vertical-align: bottom`,
since it didn't do anything for it.

* UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
* UserInterface/Views/FilterBar.js:
(WI.FilterBar):
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
* UserInterface/Views/DebuggerSidebarPanel.js:
* UserInterface/Views/LogContentView.js:
(WI.LogContentView):
* UserInterface/Views/NetworkSidebarPanel.js:
(WI.NetworkSidebarPanel):
* UserInterface/Views/RecordingNavigationSidebarPanel.js:
(WI.RecordingNavigationSidebarPanel):
* UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel):
* UserInterface/Views/SearchSidebarPanel.js:
(WI.SearchSidebarPanel):
* UserInterface/Views/StorageSidebarPanel.js:
(WI.StorageSidebarPanel):
* UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView):
* Localizations/en.lproj/localizedStrings.js:
Replace placeholder text for all filter fields with "Filter".

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (220608 => 220609)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-08-11 21:08:58 UTC (rev 220609)
@@ -1,3 +1,43 @@
+2017-08-11  Nikita Vasilyev  <nvasil...@apple.com>
+
+        Web Inspector: Styles: Update the filter icon to match Xcode
+        https://bugs.webkit.org/show_bug.cgi?id=175458
+        <rdar://problem/33838660>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Images/FilterFieldGlyph.svg:
+        Half-pixel transform is necessary for a cleaner rasterisation.
+
+        * UserInterface/Views/FilterBar.css:
+        (.filter-bar > input[type="search"]::-webkit-search-decoration):        
+        (.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
+        ::-webkit-search-decoration is a flexbox item. Remove `vertical-align: bottom`,
+        since it didn't do anything for it.
+
+        * UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
+        * UserInterface/Views/FilterBar.js:
+        (WI.FilterBar):        
+        * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+        (WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
+        * UserInterface/Views/DebuggerSidebarPanel.js:
+        * UserInterface/Views/LogContentView.js:
+        (WI.LogContentView):
+        * UserInterface/Views/NetworkSidebarPanel.js:
+        (WI.NetworkSidebarPanel):
+        * UserInterface/Views/RecordingNavigationSidebarPanel.js:
+        (WI.RecordingNavigationSidebarPanel):
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WI.ResourceSidebarPanel):
+        * UserInterface/Views/SearchSidebarPanel.js:
+        (WI.SearchSidebarPanel):
+        * UserInterface/Views/StorageSidebarPanel.js:
+        (WI.StorageSidebarPanel):
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WI.TimelineRecordingContentView):
+        * Localizations/en.lproj/localizedStrings.js:        
+        Replace placeholder text for all filter fields with "Filter".
+
 2017-08-10  Ross Kirsling  <ross.kirsl...@sony.com>
 
         Web Inspector: Add three.js in preparation for layer visualization.

Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -390,14 +390,7 @@
 localizedStrings["Filename"] = "Filename";
 localizedStrings["Fill"] = "Fill";
 localizedStrings["Fill Mode"] = "Fill Mode";
-localizedStrings["Filter Actions"] = "Filter Actions";
-localizedStrings["Filter Console Log"] = "Filter Console Log";
-localizedStrings["Filter List"] = "Filter List";
-localizedStrings["Filter Records"] = "Filter Records";
-localizedStrings["Filter Resource List"] = "Filter Resource List";
-localizedStrings["Filter Search Results"] = "Filter Search Results";
-localizedStrings["Filter Storage List"] = "Filter Storage List";
-localizedStrings["Filter Styles"] = "Filter Styles";
+localizedStrings["Filter"] = "Filter";
 localizedStrings["Flexbox"] = "Flexbox";
 localizedStrings["Float"] = "Float";
 localizedStrings["Float and Clear"] = "Float and Clear";

Modified: trunk/Source/WebInspectorUI/UserInterface/Images/FilterFieldGlyph.svg (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Images/FilterFieldGlyph.svg	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/FilterFieldGlyph.svg	2017-08-11 21:08:58 UTC (rev 220609)
@@ -1,5 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
-<!-- Copyright © 2014 Apple Inc. All rights reserved. -->
+<!-- Copyright © 2017 Apple Inc. All rights reserved. -->
 <svg xmlns="http://www.w3.org/2000/svg" id="root" version="1.1" viewBox="0 0 13 13">
-    <path fill="rgb(146, 146, 146)" fill-rule="evenodd" d="M 9.964556 7 C 9.987914 6.836699 10 6.669761 10 6.5 C 10 4.567003 8.432997 3 6.5 3 C 4.567003 3 3 4.567003 3 6.5 C 3 6.669761 3.012086 6.836699 3.035444 7 L 9.964556 7 L 9.964556 7 Z M 6.5 13 C 10.08985 13 13 10.089851 13 6.5 C 13 2.91015 10.08985 0 6.5 0 C 2.910149 0 0 2.91015 0 6.5 C 0 10.089851 2.910149 13 6.5 13 L 6.5 13 Z M 6.5 12 C 9.537566 12 12 9.537566 12 6.5 C 12 3.462434 9.537566 1 6.5 1 C 3.462434 1 1 3.462434 1 6.5 C 1 9.537566 3.462434 12 6.5 12 L 6.5 12 Z"/>
+    <g transform="translate(0.5, 0.5)" stroke="rgb(127, 127, 127)" stroke-width="1" fill="none">
+        <circle cx="6" cy="6" r="6"/>
+        <path d="M3 4 L 9 4" stroke-linecap="square"/>
+        <path d="M4 6 L 8 6" stroke-linecap="square"/>
+        <path d="M5 8 L 7 8" stroke-linecap="square"/>
+    </g>
 </svg>

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -179,7 +179,6 @@
         newRuleButton.addEventListener("contextmenu", this._newRuleButtonContextMenu.bind(this));
 
         this._filterBar = new WI.FilterBar;
-        this._filterBar.placeholder = WI.UIString("Filter Styles");
         this._filterBar.addEventListener(WI.FilterBar.Event.FilterDidChange, this._filterDidChange, this);
         optionsContainer.appendChild(this._filterBar.element);
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.css (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.css	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.css	2017-08-11 21:08:58 UTC (rev 220609)
@@ -25,8 +25,8 @@
 
 .sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter {
     position: relative;
-    width: 14px;
-    height: 14px;
+    width: 13px;
+    height: 13px;
 }
 
 body[dir=ltr] .sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter {

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -116,8 +116,6 @@
 
         this.suppressFilteringOnTreeElements([this._allExceptionsBreakpointTreeElement, this._allUncaughtExceptionsBreakpointTreeElement, this._assertionsBreakpointTreeElement]);
 
-        this.filterBar.placeholder = WI.UIString("Filter List");
-
         function showResourcesWithIssuesOnlyFilterFunction(treeElement)
         {
             // Issues are only shown in the scripts tree outline.

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.css (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.css	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.css	2017-08-11 21:08:58 UTC (rev 220609)
@@ -82,10 +82,9 @@
     width: 13px;
     height: 13px;
 
-    margin-left: 6px;
-    margin-right: 6px;
+    margin: 4px 4px 3px 3px;
 
-    vertical-align: bottom;
+    align-self: center;
 
     background-image: url(../Images/FilterFieldGlyph.svg);
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -39,6 +39,7 @@
 
         this._inputField = document.createElement("input");
         this._inputField.type = "search";
+        this._inputField.placeholder = WI.UIString("Filter");
         this._inputField.spellcheck = false;
         this._inputField.incremental = true;
         this._inputField.addEventListener("search", this._handleFilterChanged.bind(this), false);

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -59,7 +59,6 @@
 
         const fixed = true;
         this._findBanner = new WI.FindBanner(this, "console-find-banner", fixed);
-        this._findBanner.inputField.placeholder = WI.UIString("Filter Console Log");
         this._findBanner.targetElement = this.element;
 
         this._currentSearchQuery = "";

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -33,8 +33,6 @@
 
         this.contentBrowser = contentBrowser;
 
-        this.filterBar.placeholder = WI.UIString("Filter Resource List");
-
         this.contentTreeOutline.element.classList.add("network-grid");
         this.contentTreeOutline.disclosureButtons = false;
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RecordingNavigationSidebarPanel.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/RecordingNavigationSidebarPanel.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RecordingNavigationSidebarPanel.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -32,8 +32,6 @@
         this.contentTreeOutline.customIndent = true;
         this.contentTreeOutline.registerScrollVirtualizer(this.contentView.element, 20);
 
-        this.filterBar.placeholder = WI.UIString("Filter Actions");
-
         this.recording = null;
 
         this._importButton = null;

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -31,8 +31,6 @@
 
         this.contentBrowser = contentBrowser;
 
-        this.filterBar.placeholder = WI.UIString("Filter Resource List");
-
         this._navigationBar = new WI.NavigationBar;
         this.addSubview(this._navigationBar);
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -45,8 +45,6 @@
         this._inputElement.setAttribute("placeholder", WI.UIString("Search Resource Content"));
         searchElement.appendChild(this._inputElement);
 
-        this.filterBar.placeholder = WI.UIString("Filter Search Results");
-
         this._searchQuerySetting = new WI.Setting("search-sidebar-query", "");
         this._inputElement.value = this._searchQuerySetting.value;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -31,8 +31,6 @@
 
         this.contentBrowser = contentBrowser;
 
-        this.filterBar.placeholder = WI.UIString("Filter Storage List");
-
         this._navigationBar = new WI.NavigationBar;
         this.addSubview(this._navigationBar);
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (220608 => 220609)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2017-08-11 20:37:51 UTC (rev 220608)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2017-08-11 21:08:58 UTC (rev 220609)
@@ -52,7 +52,6 @@
         this._selectedTimeRangePathComponent = this._entireRecordingPathComponent;
 
         this._filterBarNavigationItem = new WI.FilterBarNavigationItem;
-        this._filterBarNavigationItem.filterBar.placeholder = WI.UIString("Filter Records");
         this._filterBarNavigationItem.filterBar.addEventListener(WI.FilterBar.Event.FilterDidChange, this._filterDidChange, this);
         this._timelineContentBrowser.navigationBar.addNavigationItem(this._filterBarNavigationItem);
         this.addSubview(this._timelineContentBrowser);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to