Diff
Modified: releases/WebKitGTK/webkit-2.18/ChangeLog (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/ChangeLog 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/ChangeLog 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,3 +1,19 @@
+2017-08-14 Simon Fraser <[email protected]>
+
+ Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
+ https://bugs.webkit.org/show_bug.cgi?id=175557
+
+ Reviewed by Jon Lee.
+
+ No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
+
+ * Source/cmake/OptionsMac.cmake:
+ * Source/cmake/OptionsWPE.cmake:
+ * Source/cmake/OptionsWin.cmake:
+ * Source/cmake/WebKitFeatures.cmake:
+ * Source/cmake/tools/vsprops/FeatureDefines.props:
+ * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
+
2017-08-13 Adrian Perez de Castro <[email protected]>
[WPE] Implement WebCore::standardUserAgent()
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/ChangeLog 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,3 +1,30 @@
+2017-08-14 Simon Fraser <[email protected]>
+
+ Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
+ https://bugs.webkit.org/show_bug.cgi?id=175557
+
+ Reviewed by Jon Lee.
+
+ No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
+
+ * fast/media/media-query-list-02-expected.txt: Removed.
+ * fast/media/media-query-list-02.html: Removed.
+ * fast/media/media-query-list-03-expected.txt: Removed.
+ * fast/media/media-query-list-03.html: Removed.
+ * fast/media/media-query-list-04-expected.txt: Removed.
+ * fast/media/media-query-list-04.html: Removed.
+ * fast/media/media-query-list-05-expected.txt: Removed.
+ * fast/media/media-query-list-05.html: Removed.
+ * fast/media/media-query-list-06-expected.txt: Removed.
+ * fast/media/media-query-list-06.html: Removed.
+ * fast/media/view-mode-media-feature-expected.html: Removed.
+ * fast/media/view-mode-media-feature.html: Removed.
+ * platform/gtk/TestExpectations:
+ * platform/ios-wk2/TestExpectations:
+ * platform/ios/TestExpectations:
+ * platform/mac/TestExpectations:
+ * platform/win/TestExpectations:
+
2017-08-14 Said Abou-Hallawa <[email protected]>
The none smooth stroke applied to an SVG shape breaks its hit testing
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-02-expected.txt (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-02-expected.txt 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-02-expected.txt 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,25 +0,0 @@
-Test the MediaQueryList interface: http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface.
-
-Testing addListener in different MediaQueryList objects and the callback call sequence
-
-------------- minimized -------------
-[1] - query (-webkit-view-mode: windowed) changed to false
-[1] - query (-webkit-view-mode: minimized) changed to true
-[2] - query (-webkit-view-mode: windowed) changed to false
-[2] - query (-webkit-view-mode: minimized) changed to true
-------------- maximized -------------
-[1] - query (-webkit-view-mode: minimized) changed to false
-[1] - query (-webkit-view-mode: maximized) changed to true
-[2] - query (-webkit-view-mode: minimized) changed to false
-[2] - query (-webkit-view-mode: maximized) changed to true
-------------- windowed -------------
-[1] - query (-webkit-view-mode: windowed) changed to true
-[1] - query (-webkit-view-mode: maximized) changed to false
-[2] - query (-webkit-view-mode: windowed) changed to true
-[2] - query (-webkit-view-mode: maximized) changed to false
-------------- floating -------------
-[1] - query (-webkit-view-mode: windowed) changed to false
-[1] - query (-webkit-view-mode: floating) changed to true
-[2] - query (-webkit-view-mode: windowed) changed to false
-[2] - query (-webkit-view-mode: floating) changed to true
-
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-02.html (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-02.html 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-02.html 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,63 +0,0 @@
-<html>
-<head>
-<title>Test CSSOM View module: MediaQueryList interface</title>
-<style type="text/css">
-
-</style>
-<script type="text/_javascript_" charset="utf-8">
- if (window.testRunner)
- testRunner.dumpAsText();
-
- function log(m) {
- document.getElementById('results').innerHTML += m + '<br>';
- }
-
- function callback1(query) {
- log("[1] - query " + query.media + " changed to " + (query.matches ? "true" : "false"));
- }
-
- function callback2(query) {
- log("[2] - query " + query.media + " changed to " + (query.matches ? "true" : "false"));
- }
-
- function runTests()
- {
- if (!window.testRunner)
- return;
-
- testRunner.setViewModeMediaFeature("windowed");
-
- windowedQuery = window.matchMedia("(-webkit-view-mode: windowed)");
- floatingQuery = window.matchMedia("(-webkit-view-mode: floating)");
- minimizedQuery = window.matchMedia("(-webkit-view-mode: minimized)");
- maximizedQuery = window.matchMedia("(-webkit-view-mode: maximized)");
-
- windowedQuery.addListener(callback1);
- floatingQuery.addListener(callback1);
- minimizedQuery.addListener(callback1);
- maximizedQuery.addListener(callback1);
-
- windowedQuery.addListener(callback2);
- floatingQuery.addListener(callback2);
- minimizedQuery.addListener(callback2);
- maximizedQuery.addListener(callback2);
-
- log("------------- minimized -------------");
- testRunner.setViewModeMediaFeature("minimized");
- log("------------- maximized -------------");
- testRunner.setViewModeMediaFeature("maximized");
- log("------------- windowed -------------");
- testRunner.setViewModeMediaFeature("windowed");
- log("------------- floating -------------");
- testRunner.setViewModeMediaFeature("floating");
- }
-
-</script>
-</head>
-<body _onload_="runTests()">
- <p>Test the MediaQueryList interface: <a href="" title="CSSOM View Module">http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface</a>.</p>
- <p>Testing addListener in different MediaQueryList objects and the callback call sequence</p>
- <div id="results">
- </div>
-</body>
-</html>
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-03-expected.txt (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-03-expected.txt 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-03-expected.txt 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,41 +0,0 @@
-Test the MediaQueryList interface: http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface.
-
-Testing removeListener in different MediaQueryList objects and the callback call sequence
-
-adding windowed[1], minimized[1], windowed[2] and minimized[2]
-
-------------- minimized -------------
-[1] - query (-webkit-view-mode: windowed) changed to false
-[1] - query (-webkit-view-mode: minimized) changed to true
-[2] - query (-webkit-view-mode: windowed) changed to false
-[2] - query (-webkit-view-mode: minimized) changed to true
-------------- windowed -------------
-[1] - query (-webkit-view-mode: windowed) changed to true
-[1] - query (-webkit-view-mode: minimized) changed to false
-[2] - query (-webkit-view-mode: windowed) changed to true
-[2] - query (-webkit-view-mode: minimized) changed to false
-
-
-removing windowed[1] and minimized[2]
-
-------------- minimized -------------
-[1] - query (-webkit-view-mode: minimized) changed to true
-[2] - query (-webkit-view-mode: windowed) changed to false
-------------- windowed -------------
-[1] - query (-webkit-view-mode: minimized) changed to false
-[2] - query (-webkit-view-mode: windowed) changed to true
-
-
-adding windowed[1] and minimized[2]
-
-------------- minimized -------------
-[1] - query (-webkit-view-mode: minimized) changed to true
-[2] - query (-webkit-view-mode: windowed) changed to false
-[1] - query (-webkit-view-mode: windowed) changed to false
-[2] - query (-webkit-view-mode: minimized) changed to true
-------------- windowed -------------
-[1] - query (-webkit-view-mode: minimized) changed to false
-[2] - query (-webkit-view-mode: windowed) changed to true
-[1] - query (-webkit-view-mode: windowed) changed to true
-[2] - query (-webkit-view-mode: minimized) changed to false
-
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-03.html (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-03.html 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-03.html 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,72 +0,0 @@
-<html>
-<head>
-<title>Test CSSOM View module: MediaQueryList interface</title>
-<style type="text/css">
-
-</style>
-<script type="text/_javascript_" charset="utf-8">
- if (window.testRunner)
- testRunner.dumpAsText();
-
- function log(m) {
- document.getElementById('results').innerHTML += m + '<br>';
- }
-
- function callback1(query) {
- log("[1] - query " + query.media + " changed to " + (query.matches ? "true" : "false"));
- }
-
- function callback2(query) {
- log("[2] - query " + query.media + " changed to " + (query.matches ? "true" : "false"));
- }
-
- function runTests()
- {
- if (!window.testRunner)
- return;
-
- testRunner.setViewModeMediaFeature("windowed");
-
- windowedQuery = window.matchMedia("(-webkit-view-mode: windowed)");
- minimizedQuery = window.matchMedia("(-webkit-view-mode: minimized)");
-
- log("adding windowed[1], minimized[1], windowed[2] and minimized[2]<br>");
- windowedQuery.addListener(callback1);
- minimizedQuery.addListener(callback1);
- windowedQuery.addListener(callback2);
- minimizedQuery.addListener(callback2);
-
- log("------------- minimized -------------");
- testRunner.setViewModeMediaFeature("minimized");
- log("------------- windowed -------------");
- testRunner.setViewModeMediaFeature("windowed");
-
- log("<br><br>removing windowed[1] and minimized[2]<br>");
- windowedQuery.removeListener(callback1);
- minimizedQuery.removeListener(callback2);
-
- log("------------- minimized -------------");
- testRunner.setViewModeMediaFeature("minimized");
- log("------------- windowed -------------");
- testRunner.setViewModeMediaFeature("windowed");
-
- log("<br><br>adding windowed[1] and minimized[2]<br>");
- windowedQuery.addListener(callback1);
- minimizedQuery.addListener(callback2);
-
- log("------------- minimized -------------");
- testRunner.setViewModeMediaFeature("minimized");
- log("------------- windowed -------------");
- testRunner.setViewModeMediaFeature("windowed");
-
- }
-
-</script>
-</head>
-<body _onload_="runTests()">
- <p>Test the MediaQueryList interface: <a href="" title="CSSOM View Module">http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface</a>.</p>
- <p>Testing removeListener in different MediaQueryList objects and the callback call sequence</p>
- <div id="results">
- </div>
-</body>
-</html>
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-04-expected.txt (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-04-expected.txt 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-04-expected.txt 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,25 +0,0 @@
-Test the MediaQueryList interface: http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface.
-
-Testing page cache
-
-------------- minimized -------------
-[1] - query (-webkit-view-mode: windowed) changed to false
-[1] - query (-webkit-view-mode: minimized) changed to true
-[2] - query (-webkit-view-mode: windowed) changed to false
-[2] - query (-webkit-view-mode: minimized) changed to true
-------------- maximized -------------
-[1] - query (-webkit-view-mode: minimized) changed to false
-[1] - query (-webkit-view-mode: maximized) changed to true
-[2] - query (-webkit-view-mode: minimized) changed to false
-[2] - query (-webkit-view-mode: maximized) changed to true
-------------- windowed -------------
-[1] - query (-webkit-view-mode: windowed) changed to true
-[1] - query (-webkit-view-mode: maximized) changed to false
-[2] - query (-webkit-view-mode: windowed) changed to true
-[2] - query (-webkit-view-mode: maximized) changed to false
-------------- floating -------------
-[1] - query (-webkit-view-mode: windowed) changed to false
-[1] - query (-webkit-view-mode: floating) changed to true
-[2] - query (-webkit-view-mode: windowed) changed to false
-[2] - query (-webkit-view-mode: floating) changed to true
-
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-04.html (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-04.html 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-04.html 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,75 +0,0 @@
-<html>
-<head>
-<title>Test CSSOM View module: MediaQueryList interface</title>
-<script type="text/_javascript_" charset="utf-8">
-
- if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
- testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
- }
-
- function log(m) {
- document.getElementById('results').innerHTML += m + '<br>';
- }
-
- function callback1(query) {
- log("[1] - query " + query.media + " changed to " + (query.matches ? "true" : "false"));
- }
-
- function callback2(query) {
- log("[2] - query " + query.media + " changed to " + (query.matches ? "true" : "false"));
- }
-
- function pageshow(evt)
- {
- if (!evt.persisted) {
- // this will run only when the page is loaded for the first time.
-
- windowedQuery = window.matchMedia("(-webkit-view-mode: windowed)");
- floatingQuery = window.matchMedia("(-webkit-view-mode: floating)");
- minimizedQuery = window.matchMedia("(-webkit-view-mode: minimized)");
- maximizedQuery = window.matchMedia("(-webkit-view-mode: maximized)");
-
- windowedQuery.addListener(callback1);
- floatingQuery.addListener(callback1);
- minimizedQuery.addListener(callback1);
- maximizedQuery.addListener(callback1);
-
- windowedQuery.addListener(callback2);
- floatingQuery.addListener(callback2);
- minimizedQuery.addListener(callback2);
- maximizedQuery.addListener(callback2);
-
- setTimeout('window.location = "data:text/html,<script>history.back()<" + "/script>"', 0);
-
- } else {
- // if this point is reached the page is comming from the page cache.
-
- log("------------- minimized -------------");
- testRunner.setViewModeMediaFeature("minimized");
- log("------------- maximized -------------");
- testRunner.setViewModeMediaFeature("maximized");
- log("------------- windowed -------------");
- testRunner.setViewModeMediaFeature("windowed");
- log("------------- floating -------------");
- testRunner.setViewModeMediaFeature("floating");
-
- setTimeout(function() { if (window.testRunner) testRunner.notifyDone(); }, 0);
-
- }
- }
-
- if (window.testRunner) {
- testRunner.setViewModeMediaFeature("windowed");
- window._onpageshow_ = pageshow;
- }
-
-</script>
-</head>
-<body>
- <p>Test the MediaQueryList interface: <a href="" title="CSSOM View Module">http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface</a>.</p>
- <p>Testing page cache</p>
- <div id="results"></div>
-</body>
-</html>
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-05-expected.txt (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-05-expected.txt 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-05-expected.txt 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,7 +0,0 @@
-Test the MediaQueryList interface: http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface.
-
-Testing listener comparison. Two callbacks are expected.
-
-[1] - query (-webkit-view-mode: windowed) changed to false
-[2] - query (-webkit-view-mode: windowed) changed to false
-
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-05.html (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-05.html 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-05.html 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,47 +0,0 @@
-<html>
-<head>
-<title>Test CSSOM View module: MediaQueryList interface</title>
-<style type="text/css">
-
-</style>
-<script type="text/_javascript_" charset="utf-8">
- if (window.testRunner)
- testRunner.dumpAsText();
-
- function log(m) {
- document.getElementById('results').innerHTML += m + '<br>';
- }
-
- function callback1(query) {
- log("[1] - query " + query.media + " changed to " + (query.matches ? "true" : "false"));
- }
-
- function callback2(query) {
- log("[2] - query " + query.media + " changed to " + (query.matches ? "true" : "false"));
- }
-
- function runTests()
- {
- if (!window.testRunner)
- return;
-
- testRunner.setViewModeMediaFeature("windowed");
-
- var query = window.matchMedia("(-webkit-view-mode: windowed)");
-
- query.addListener(callback1);
- query.addListener(callback1);
- query.addListener(callback2);
-
- testRunner.setViewModeMediaFeature("minimized");
- }
-
-</script>
-</head>
-<body _onload_="runTests()">
- <p>Test the MediaQueryList interface: <a href="" title="CSSOM View Module">http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface</a>.</p>
- <p>Testing listener comparison. Two callbacks are expected.</p>
- <div id="results">
- </div>
-</body>
-</html>
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-06-expected.txt (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-06-expected.txt 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-06-expected.txt 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,7 +0,0 @@
-Test the MediaQueryList interface: http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface.
-
-Testing queries that have no registered listener.
-
-Query result before changing view-mode: true
-Query result after changing view-mode: false
-
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-06.html (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-06.html 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/media-query-list-06.html 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,36 +0,0 @@
-<html>
-<head>
-<title>Test CSSOM View module: MediaQueryList interface</title>
-<style type="text/css">
-
-</style>
-<script type="text/_javascript_" charset="utf-8">
- if (window.testRunner)
- testRunner.dumpAsText();
-
- function log(m) {
- document.getElementById('results').innerHTML += m + '<br>';
- }
-
- function runTests()
- {
- if (!window.testRunner)
- return;
-
- testRunner.setViewModeMediaFeature("windowed");
-
- var query = window.matchMedia("(-webkit-view-mode: windowed)");
- log('Query result before changing view-mode: ' + query.matches);
- testRunner.setViewModeMediaFeature("minimized");
- log('Query result after changing view-mode: ' + query.matches);
- }
-
-</script>
-</head>
-<body _onload_="runTests()">
- <p>Test the MediaQueryList interface: <a href="" title="CSSOM View Module">http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface</a>.</p>
- <p>Testing queries that have no registered listener.</p>
- <div id="results">
- </div>
-</body>
-</html>
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/view-mode-media-feature-expected.html (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/view-mode-media-feature-expected.html 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/view-mode-media-feature-expected.html 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,5 +0,0 @@
-<html>
-<body style="background-color: blue">
-<div style="width: 200px; height: 200px; background-color: green"></div>
-</body>
-</html>
Deleted: releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/view-mode-media-feature.html (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/view-mode-media-feature.html 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/fast/media/view-mode-media-feature.html 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,25 +0,0 @@
-<head>
- <title>Testing the View Mode Media Feature</title>
- <style type="text/css">
- div {
- background-color: red;
- }
- @media (-webkit-view-mode: minimized) {
- body {
- background-color: blue;
- }
- }
- @media (-webkit-view-mode) {
- div {
- background-color: green;
- }
- }
- </style>
- <script>
- if (window.testRunner)
- testRunner.setViewModeMediaFeature("minimized");
- </script>
-</head>
-<body>
- <div style="width: 200; height: 200;"\>
-</body>
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/TestExpectations (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/TestExpectations 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/platform/gtk/TestExpectations 2017-08-17 06:57:33 UTC (rev 220830)
@@ -2066,8 +2066,6 @@
Bug(GTK) plugins/reloadplugins-and-pages.html [ Timeout ]
-Bug(GTK) fast/media/media-query-list-04.html [ Timeout ]
-
webkit.org/b/132128 fast/text/international/embed-bidi-style-in-isolate-crash.html [ Timeout Pass ]
webkit.org/b/132266 js/slow-stress/emscripten-memops.html [ Timeout Pass ]
@@ -2459,13 +2457,6 @@
Bug(GTK) fast/forms/select/popup-closes-on-blur.html [ Failure ]
-Bug(GTK) fast/media/media-query-list-02.html [ Failure ]
-Bug(GTK) fast/media/media-query-list-03.html [ Failure ]
-Bug(GTK) fast/media/media-query-list-05.html [ Failure ]
-Bug(GTK) fast/media/media-query-list-06.html [ Failure ]
-
-Bug(GTK) fast/media/view-mode-media-feature.html [ ImageOnlyFailure ]
-
# Shared workers disabled with the Network Process
webkit.org/b/139357 fast/workers/worker-crash-with-invalid-location.html [ Skip ]
webkit.org/b/139357 http/tests/media/video-accept-encoding.html [ Failure ]
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/platform/ios/TestExpectations (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/platform/ios/TestExpectations 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/platform/ios/TestExpectations 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1486,17 +1486,11 @@
fast/lists/list-marker-before-content-table.html [ Failure ]
fast/loader/scroll-position-restored-on-back-non-cached.html [ Failure ]
fast/masking/clip-path-selection.html [ Failure ]
-fast/media/media-query-list-02.html [ Failure ]
-fast/media/media-query-list-03.html [ Failure ]
-fast/media/media-query-list-04.html [ Failure ]
-fast/media/media-query-list-05.html [ Failure ]
-fast/media/media-query-list-06.html [ Failure ]
fast/media/mq-max-pixel-ratio.html [ ImageOnlyFailure ]
fast/media/mq-min-pixel-ratio.html [ ImageOnlyFailure ]
fast/media/mq-pixel-ratio.html [ ImageOnlyFailure ]
fast/media/mq-resolution-dpi-dpcm-warning.html [ Failure ]
fast/media/mq-resolution.html [ Failure ]
-fast/media/view-mode-media-feature.html [ ImageOnlyFailure ]
fast/media/viewport-media-query.html [ ImageOnlyFailure ]
fast/multicol/mixed-opacity-fixed-test.html [ ImageOnlyFailure ]
fast/multicol/newmulticol/multicol-clip-rounded-corners.html [ ImageOnlyFailure ]
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/platform/ios-wk2/TestExpectations (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/platform/ios-wk2/TestExpectations 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/platform/ios-wk2/TestExpectations 2017-08-17 06:57:33 UTC (rev 220830)
@@ -775,7 +775,6 @@
fast/loader/document-with-fragment-url-3.html
fast/loader/document-with-fragment-url-4.html
fast/loader/fragment-after-redirect-gets-back-entry.html
-fast/media/media-query-list-04.html
fast/replaced/no-focus-ring-embed.html
fast/replaced/no-focus-ring-iframe.html
fast/replaced/no-focus-ring-object.html
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/platform/mac/TestExpectations (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/platform/mac/TestExpectations 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/platform/mac/TestExpectations 2017-08-17 06:57:33 UTC (rev 220830)
@@ -77,15 +77,6 @@
# Requires testRunner.setMediaType() and implementation
fast/media/print-restores-previous-mediatype.html
-# VIEW_MODE_CSS_MEDIA is not enabled on Mac.
-# DumpRenderTree requires testRunner.setViewModeMediaFeature()
-fast/media/view-mode-media-feature.html [ ImageOnlyFailure ]
-fast/media/media-query-list-02.html [ Failure ]
-fast/media/media-query-list-03.html [ Failure ]
-fast/media/media-query-list-04.html [ Failure Timeout ]
-fast/media/media-query-list-05.html [ Failure ]
-fast/media/media-query-list-06.html [ Failure ]
-
# Needs testRunner.enableAutoResizeMode()
fast/autoresize
Modified: releases/WebKitGTK/webkit-2.18/LayoutTests/platform/win/TestExpectations (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/LayoutTests/platform/win/TestExpectations 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/LayoutTests/platform/win/TestExpectations 2017-08-17 06:57:33 UTC (rev 220830)
@@ -805,14 +805,6 @@
#webkit.org/b/34447 [ Release ] http/tests/media/video-referer.html [ Failure ]
webkit.org/b/34447 [ Debug ] http/tests/media/video-referer.html [ Skip ] # Crashing
-# DumpRenderTree requires testRunner.setViewModeMediaFeature()
-#fast/media/view-mode-media-feature.html [ ImageOnlyFailure ]
-#fast/media/media-query-list-02.html [ Failure ]
-#fast/media/media-query-list-03.html [ Failure ]
-#fast/media/media-query-list-04.html [ Failure ]
-#fast/media/media-query-list-05.html [ Failure ]
-#fast/media/media-query-list-06.html [ Failure ]
-
webkit.org/b/38376 media/media-document-audio-size.html [ Skip ]
# Media Stream API is not yet enabled.
Modified: releases/WebKitGTK/webkit-2.18/Source/_javascript_Core/ChangeLog (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/_javascript_Core/ChangeLog 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/_javascript_Core/ChangeLog 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,3 +1,14 @@
+2017-08-14 Simon Fraser <[email protected]>
+
+ Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
+ https://bugs.webkit.org/show_bug.cgi?id=175557
+
+ Reviewed by Jon Lee.
+
+ No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2017-08-10 Sam Weinig <[email protected]>
WTF::Function does not allow for reference / non-default constructible return types
Modified: releases/WebKitGTK/webkit-2.18/Source/WTF/ChangeLog (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WTF/ChangeLog 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WTF/ChangeLog 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,3 +1,14 @@
+2017-08-14 Simon Fraser <[email protected]>
+
+ Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
+ https://bugs.webkit.org/show_bug.cgi?id=175557
+
+ Reviewed by Jon Lee.
+
+ No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
+
+ * wtf/FeatureDefines.h:
+
2017-08-11 Don Olmstead <[email protected]>
[WTF] Move ValueToString into WTF
Modified: releases/WebKitGTK/webkit-2.18/Source/WTF/wtf/FeatureDefines.h (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WTF/wtf/FeatureDefines.h 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WTF/wtf/FeatureDefines.h 2017-08-17 06:57:33 UTC (rev 220830)
@@ -148,10 +148,6 @@
#define ENABLE_WEB_ARCHIVE 1
#endif
-#if !defined(ENABLE_VIEW_MODE_CSS_MEDIA)
-#define ENABLE_VIEW_MODE_CSS_MEDIA 0
-#endif
-
#if !defined(ENABLE_WEBASSEMBLY)
#define ENABLE_WEBASSEMBLY (defined(ENABLE_B3_JIT) && ENABLE_B3_JIT)
#endif
@@ -207,10 +203,6 @@
#endif
#endif
-#if !defined(ENABLE_VIEW_MODE_CSS_MEDIA)
-#define ENABLE_VIEW_MODE_CSS_MEDIA 0
-#endif
-
#if !defined(ENABLE_WEBASSEMBLY)
#define ENABLE_WEBASSEMBLY (defined(ENABLE_B3_JIT) && ENABLE_B3_JIT)
#endif
@@ -308,10 +300,6 @@
#define ENABLE_WEB_ARCHIVE 1
#endif
-#if !defined(ENABLE_VIEW_MODE_CSS_MEDIA)
-#define ENABLE_VIEW_MODE_CSS_MEDIA 0
-#endif
-
#if !defined(ENABLE_WEBGL)
#define ENABLE_WEBGL 1
#endif
@@ -680,10 +668,6 @@
#define ENABLE_DATACUE_VALUE 0
#endif
-#if !defined(ENABLE_VIEW_MODE_CSS_MEDIA)
-#define ENABLE_VIEW_MODE_CSS_MEDIA 1
-#endif
-
#if !defined(ENABLE_WEBGL)
#define ENABLE_WEBGL 0
#endif
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/ChangeLog 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,3 +1,26 @@
+2017-08-14 Simon Fraser <[email protected]>
+
+ Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
+ https://bugs.webkit.org/show_bug.cgi?id=175557
+
+ Reviewed by Jon Lee.
+
+ No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSValueKeywords.in:
+ * css/MediaFeatureNames.h:
+ * css/MediaQueryEvaluator.cpp:
+ (WebCore::viewModeEvaluate): Deleted.
+ * css/MediaQueryExpression.cpp:
+ (WebCore::featureWithValidIdent):
+ (WebCore::isFeatureValidWithoutValue):
+ * page/Page.cpp:
+ (WebCore::Page::stringToViewMode): Deleted.
+ (WebCore::Page::setViewMode): Deleted.
+ * page/Page.h:
+ (WebCore::Page::viewMode const): Deleted.
+
2017-08-14 Said Abou-Hallawa <[email protected]>
The none smooth stroke applied to an SVG shape breaks its hit testing
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/PAL/ChangeLog (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/PAL/ChangeLog 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/PAL/ChangeLog 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,3 +1,14 @@
+2017-08-14 Simon Fraser <[email protected]>
+
+ Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
+ https://bugs.webkit.org/show_bug.cgi?id=175557
+
+ Reviewed by Jon Lee.
+
+ No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2017-08-07 Brian Burg <[email protected]>
Remove CANVAS_PATH compilation guard
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/css/CSSValueKeywords.in (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/css/CSSValueKeywords.in 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/css/CSSValueKeywords.in 2017-08-17 06:57:33 UTC (rev 220830)
@@ -991,15 +991,6 @@
economy
exact
-#if defined(ENABLE_VIEW_MODE_CSS_MEDIA) && ENABLE_VIEW_MODE_CSS_MEDIA
-// (-webkit-view-mode:) media feature:
-floating
-fullscreen
-maximized
-minimized
-windowed
-#endif // ENABLE_VIEW_MODE_CSS_MEDIA
-
// -webkit-hyphenate-limit-lines
no-limit
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/css/MediaFeatureNames.h (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/css/MediaFeatureNames.h 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/css/MediaFeatureNames.h 2017-08-17 06:57:33 UTC (rev 220830)
@@ -23,11 +23,7 @@
#include <wtf/NeverDestroyed.h>
#include <wtf/text/AtomicString.h>
-#if ENABLE(VIEW_MODE_CSS_MEDIA)
-#define CSS_MEDIAQUERY_VIEW_MODE(macro) macro(viewMode, "-webkit-view-mode")
-#else
#define CSS_MEDIAQUERY_VIEW_MODE(macro)
-#endif
#define CSS_MEDIAQUERY_NAMES_FOR_EACH_MEDIAFEATURE(macro) \
macro(animation, "-webkit-animation") \
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/css/MediaQueryEvaluator.cpp (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/css/MediaQueryEvaluator.cpp 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/css/MediaQueryEvaluator.cpp 2017-08-17 06:57:33 UTC (rev 220830)
@@ -601,35 +601,6 @@
#endif
}
-#if ENABLE(VIEW_MODE_CSS_MEDIA)
-
-static bool viewModeEvaluate(CSSValue* value, const CSSToLengthConversionData&, Frame& frame, MediaFeaturePrefix)
-{
- if (!value)
- return true;
-
- auto keyword = downcast<CSSPrimitiveValue>(*value).valueID();
-
- switch (frame.page()->viewMode()) {
- case Page::ViewModeWindowed:
- return keyword == CSSValueWindowed;
- case Page::ViewModeFloating:
- return keyword == CSSValueFloating;
- case Page::ViewModeFullscreen:
- return keyword == CSSValueFullscreen;
- case Page::ViewModeMaximized:
- return keyword == CSSValueMaximized;
- case Page::ViewModeMinimized:
- return keyword == CSSValueMinimized;
- default:
- break;
- }
-
- return false;
-}
-
-#endif // ENABLE(VIEW_MODE_CSS_MEDIA)
-
static bool videoPlayableInlineEvaluate(CSSValue*, const CSSToLengthConversionData&, Frame& frame, MediaFeaturePrefix)
{
return frame.settings().allowsInlineMediaPlayback();
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/css/MediaQueryExpression.cpp (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/css/MediaQueryExpression.cpp 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/css/MediaQueryExpression.cpp 2017-08-17 06:57:33 UTC (rev 220830)
@@ -39,9 +39,6 @@
static inline bool featureWithValidIdent(const AtomicString& mediaFeature)
{
return mediaFeature == MediaFeatureNames::orientation
-#if ENABLE(VIEW_MODE_CSS_MEDIA)
- || mediaFeature == MediaFeatureNames::viewMode
-#endif
|| mediaFeature == MediaFeatureNames::colorGamut
|| mediaFeature == MediaFeatureNames::anyHover
|| mediaFeature == MediaFeatureNames::anyPointer
@@ -151,9 +148,6 @@
|| mediaFeature == MediaFeatureNames::transition
|| mediaFeature == MediaFeatureNames::animation
|| mediaFeature == MediaFeatureNames::invertedColors
-#if ENABLE(VIEW_MODE_CSS_MEDIA)
- || mediaFeature == MediaFeatureNames::viewMode
-#endif
|| mediaFeature == MediaFeatureNames::pointer
|| mediaFeature == MediaFeatureNames::prefersReducedMotion
|| mediaFeature == MediaFeatureNames::devicePixelRatio
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/page/Page.cpp (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/page/Page.cpp 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/page/Page.cpp 2017-08-17 06:57:33 UTC (rev 220830)
@@ -435,45 +435,6 @@
return DOMRectList::create(quads);
}
-#if ENABLE(VIEW_MODE_CSS_MEDIA)
-struct ViewModeInfo {
- const char* name;
- Page::ViewMode type;
-};
-static const int viewModeMapSize = 5;
-static const ViewModeInfo viewModeMap[viewModeMapSize] = {
- {"windowed", Page::ViewModeWindowed},
- {"floating", Page::ViewModeFloating},
- {"fullscreen", Page::ViewModeFullscreen},
- {"maximized", Page::ViewModeMaximized},
- {"minimized", Page::ViewModeMinimized}
-};
-
-Page::ViewMode Page::stringToViewMode(const String& text)
-{
- for (auto& mode : viewModeMap) {
- if (text == mode.name)
- return mode.type;
- }
- return Page::ViewModeInvalid;
-}
-
-void Page::setViewMode(ViewMode viewMode)
-{
- if (viewMode == m_viewMode || viewMode == ViewModeInvalid)
- return;
-
- m_viewMode = viewMode;
-
-
- if (m_mainFrame->view())
- m_mainFrame->view()->forceLayout();
-
- if (m_mainFrame->document())
- m_mainFrame->document()->styleScope().didChangeStyleSheetEnvironment();
-}
-#endif // ENABLE(VIEW_MODE_CSS_MEDIA)
-
bool Page::openedByDOM() const
{
return m_openedByDOM;
Modified: releases/WebKitGTK/webkit-2.18/Source/WebCore/page/Page.h (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WebCore/page/Page.h 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WebCore/page/Page.h 2017-08-17 06:57:33 UTC (rev 220830)
@@ -251,21 +251,6 @@
Seconds domTimerAlignmentInterval() const { return m_domTimerAlignmentInterval; }
-#if ENABLE(VIEW_MODE_CSS_MEDIA)
- enum ViewMode {
- ViewModeInvalid,
- ViewModeWindowed,
- ViewModeFloating,
- ViewModeFullscreen,
- ViewModeMaximized,
- ViewModeMinimized
- };
- static ViewMode stringToViewMode(const String&);
-
- ViewMode viewMode() const { return m_viewMode; }
- WEBCORE_EXPORT void setViewMode(ViewMode);
-#endif // ENABLE(VIEW_MODE_CSS_MEDIA)
-
void setTabKeyCyclesThroughElements(bool b) { m_tabKeyCyclesThroughElements = b; }
bool tabKeyCyclesThroughElements() const { return m_tabKeyCyclesThroughElements; }
@@ -736,10 +721,6 @@
RefPtr<StorageNamespace> m_sessionStorage;
RefPtr<StorageNamespace> m_ephemeralLocalStorage;
-#if ENABLE(VIEW_MODE_CSS_MEDIA)
- ViewMode m_viewMode { ViewModeWindowed };
-#endif
-
TimerThrottlingState m_timerThrottlingState { TimerThrottlingState::Disabled };
MonotonicTime m_timerThrottlingStateLastChangedTime;
Seconds m_domTimerAlignmentInterval;
Modified: releases/WebKitGTK/webkit-2.18/Source/WebKit/ChangeLog (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WebKit/ChangeLog 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WebKit/ChangeLog 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,3 +1,14 @@
+2017-08-14 Simon Fraser <[email protected]>
+
+ Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
+ https://bugs.webkit.org/show_bug.cgi?id=175557
+
+ Reviewed by Jon Lee.
+
+ No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2017-08-14 Carlos Garcia Campos <[email protected]>
[GTK][WPE] Avoid emitting WebKitFaviconDatabase::favicon-changed multiple times while setting an icon
Modified: releases/WebKitGTK/webkit-2.18/Source/WebKitLegacy/mac/ChangeLog (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/WebKitLegacy/mac/ChangeLog 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/WebKitLegacy/mac/ChangeLog 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,3 +1,14 @@
+2017-08-14 Simon Fraser <[email protected]>
+
+ Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
+ https://bugs.webkit.org/show_bug.cgi?id=175557
+
+ Reviewed by Jon Lee.
+
+ No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2017-08-13 Manuel Rego Casasnovas <[email protected]>
Composition underline color is always black
Modified: releases/WebKitGTK/webkit-2.18/Source/cmake/OptionsMac.cmake (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/cmake/OptionsMac.cmake 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/cmake/OptionsMac.cmake 2017-08-17 06:57:33 UTC (rev 220830)
@@ -86,7 +86,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO_TRACK PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATACUE_VALUE PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIEW_MODE_CSS_MEDIA PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL2 PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGPU PRIVATE ON)
Modified: releases/WebKitGTK/webkit-2.18/Source/cmake/OptionsWPE.cmake (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/cmake/OptionsWPE.cmake 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/cmake/OptionsWPE.cmake 2017-08-17 06:57:33 UTC (rev 220830)
@@ -32,7 +32,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_USER_MESSAGE_HANDLERS PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO_TRACK PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIEW_MODE_CSS_MEDIA PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_ANIMATIONS PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PUBLIC ON)
Modified: releases/WebKitGTK/webkit-2.18/Source/cmake/OptionsWin.cmake (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/cmake/OptionsWin.cmake 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/cmake/OptionsWin.cmake 2017-08-17 06:57:33 UTC (rev 220830)
@@ -62,7 +62,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SVG_FONTS PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIDEO_TRACK PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VIEW_MODE_CSS_MEDIA PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBASSEMBLY PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_ANIMATIONS PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO PUBLIC OFF)
Modified: releases/WebKitGTK/webkit-2.18/Source/cmake/WebKitFeatures.cmake (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Source/cmake/WebKitFeatures.cmake 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Source/cmake/WebKitFeatures.cmake 2017-08-17 06:57:33 UTC (rev 220830)
@@ -179,7 +179,6 @@
WEBKIT_OPTION_DEFINE(ENABLE_USER_MESSAGE_HANDLERS "Toggle user script message handler support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_VIDEO "Toggle Video support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_VIDEO_TRACK "Toggle Track support for HTML5 video" PRIVATE OFF)
- WEBKIT_OPTION_DEFINE(ENABLE_VIEW_MODE_CSS_MEDIA "Toggle Track support for the view-mode media Feature" PRIVATE ON)
WEBKIT_OPTION_DEFINE(ENABLE_WEBASSEMBLY "Toggle WebAssembly support" PRIVATE ${ENABLE_FTL_DEFAULT})
WEBKIT_OPTION_DEFINE(ENABLE_WEBDRIVER "Whether to enable the WebDriver service process" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_WEBGL "Toggle WebGL support" PRIVATE OFF)
Modified: releases/WebKitGTK/webkit-2.18/Tools/ChangeLog (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Tools/ChangeLog 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Tools/ChangeLog 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1,3 +1,22 @@
+2017-08-14 Simon Fraser <[email protected]>
+
+ Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
+ https://bugs.webkit.org/show_bug.cgi?id=175557
+
+ Reviewed by Jon Lee.
+
+ No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
+
+ * DumpRenderTree/TestRunner.cpp:
+ (TestRunner::staticFunctions):
+ (setViewModeMediaFeatureCallback): Deleted.
+ * DumpRenderTree/TestRunner.h:
+ * DumpRenderTree/mac/TestRunnerMac.mm:
+ (TestRunner::setViewModeMediaFeature): Deleted.
+ * DumpRenderTree/win/TestRunnerWin.cpp:
+ (TestRunner::setViewModeMediaFeature): Deleted.
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
2017-08-11 Sam Weinig <[email protected]>
WTF::Function does not allow for reference / non-default constructible return types
Modified: releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/TestRunner.cpp (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/TestRunner.cpp 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/TestRunner.cpp 2017-08-17 06:57:33 UTC (rev 220830)
@@ -1330,21 +1330,6 @@
return JSValueMakeUndefined(context);
}
-static JSValueRef setViewModeMediaFeatureCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
-{
- // Has mac implementation
- if (argumentCount < 1)
- return JSValueMakeUndefined(context);
-
- JSRetainPtr<JSStringRef> mode(Adopt, JSValueToStringCopy(context, arguments[0], exception));
- ASSERT(!*exception);
-
- TestRunner* controller = static_cast<TestRunner*>(JSObjectGetPrivate(thisObject));
- controller->setViewModeMediaFeature(mode.get());
-
- return JSValueMakeUndefined(context);
-}
-
static JSValueRef setWillSendRequestClearHeaderCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
{
// Has mac & windows implementation
@@ -2209,7 +2194,6 @@
{ "setUserStyleSheetEnabled", setUserStyleSheetEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
{ "setUserStyleSheetLocation", setUserStyleSheetLocationCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
{ "setValueForUser", setValueForUserCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
- { "setViewModeMediaFeature", setViewModeMediaFeatureCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
{ "setWebViewEditable", setWebViewEditableCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
{ "setWillSendRequestClearHeader", setWillSendRequestClearHeaderCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
{ "setWillSendRequestReturnsNull", setWillSendRequestReturnsNullCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
Modified: releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/TestRunner.h (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/TestRunner.h 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/TestRunner.h 2017-08-17 06:57:33 UTC (rev 220830)
@@ -120,7 +120,6 @@
void setUserStyleSheetEnabled(bool flag);
void setUserStyleSheetLocation(JSStringRef path);
void setValueForUser(JSContextRef, JSValueRef nodeObject, JSStringRef value);
- void setViewModeMediaFeature(JSStringRef);
void setXSSAuditorEnabled(bool flag);
void setSpatialNavigationEnabled(bool);
void setScrollbarPolicy(JSStringRef orientation, JSStringRef policy);
Modified: releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/mac/TestRunnerMac.mm (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/mac/TestRunnerMac.mm 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/mac/TestRunnerMac.mm 2017-08-17 06:57:33 UTC (rev 220830)
@@ -575,11 +575,6 @@
[(DOMHTMLInputElement *)element setValueForUser:(NSString *)valueCF.get()];
}
-void TestRunner::setViewModeMediaFeature(JSStringRef mode)
-{
- // FIXME: implement
-}
-
void TestRunner::dispatchPendingLoadRequests()
{
[[mainFrame webView] _dispatchPendingLoadRequests];
Modified: releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/win/TestRunnerWin.cpp (220829 => 220830)
--- releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/win/TestRunnerWin.cpp 2017-08-17 06:17:09 UTC (rev 220829)
+++ releases/WebKitGTK/webkit-2.18/Tools/DumpRenderTree/win/TestRunnerWin.cpp 2017-08-17 06:57:33 UTC (rev 220830)
@@ -834,11 +834,6 @@
domInputElement->setValueForUser(valueBSTR);
}
-void TestRunner::setViewModeMediaFeature(JSStringRef mode)
-{
- // FIXME: implement
-}
-
void TestRunner::dispatchPendingLoadRequests()
{
COMPtr<IWebView> webView;
