Title: [220870] trunk
Revision
220870
Author
[email protected]
Date
2017-08-17 12:18:54 -0700 (Thu, 17 Aug 2017)

Log Message

Disable CSS regions at compile time
https://bugs.webkit.org/show_bug.cgi?id=175630

Reviewed by Antti Koivisto.

.:

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Skip tests that are entirely about regions, and tweak logic
and/or expectations for tests that test regions in addition to
other things.

* TestExpectations:
* fast/css/will-change/resources/will-change-stacking-helper.js:
* fast/dom/collection-iterators-expected.txt:
* fast/dom/collection-iterators.html:
* js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/ios/fast/dom/collection-iterators-expected.txt:
* platform/mac-wk2/TestExpectations:
* platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:

Modified Paths

Diff

Modified: trunk/ChangeLog (220869 => 220870)


--- trunk/ChangeLog	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/ChangeLog	2017-08-17 19:18:54 UTC (rev 220870)
@@ -1,3 +1,17 @@
+2017-08-17  Andreas Kling  <[email protected]>
+
+        Disable CSS regions at compile time
+        https://bugs.webkit.org/show_bug.cgi?id=175630
+
+        Reviewed by Antti Koivisto.
+
+        * Source/cmake/OptionsGTK.cmake:
+        * Source/cmake/OptionsMac.cmake:
+        * Source/cmake/OptionsWPE.cmake:
+        * Source/cmake/OptionsWin.cmake:
+        * Source/cmake/tools/vsprops/FeatureDefines.props:
+        * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
+
 2017-08-14  Simon Fraser  <[email protected]>
 
         Remove Proximity Events and related code

Modified: trunk/LayoutTests/ChangeLog (220869 => 220870)


--- trunk/LayoutTests/ChangeLog	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/ChangeLog	2017-08-17 19:18:54 UTC (rev 220870)
@@ -1,3 +1,25 @@
+2017-08-17  Andreas Kling  <[email protected]>
+
+        Disable CSS regions at compile time
+        https://bugs.webkit.org/show_bug.cgi?id=175630
+
+        Reviewed by Antti Koivisto.
+
+        Skip tests that are entirely about regions, and tweak logic
+        and/or expectations for tests that test regions in addition to
+        other things.
+
+        * TestExpectations:
+        * fast/css/will-change/resources/will-change-stacking-helper.js:
+        * fast/dom/collection-iterators-expected.txt:
+        * fast/dom/collection-iterators.html:
+        * js/dom/dom-static-property-for-in-iteration-expected.txt:
+        * platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
+        * platform/ios/fast/dom/collection-iterators-expected.txt:
+        * platform/mac-wk2/TestExpectations:
+        * platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt:
+        * platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:
+
 2017-08-17  Antti Koivisto  <[email protected]>
 
         RenderListItem - Avoid render tree mutation during layout

Modified: trunk/LayoutTests/TestExpectations (220869 => 220870)


--- trunk/LayoutTests/TestExpectations	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/TestExpectations	2017-08-17 19:18:54 UTC (rev 220870)
@@ -1445,3 +1445,10 @@
 webkit.org/b/175611 imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub.html [ Skip ]
 webkit.org/b/175611 imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html [ Skip ]
 webkit.org/b/175611 imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html [ Skip ]
+
+# CSS Regions are being phased out.
+fast/regions [ Skip ]
+compositing/regions [ Skip ]
+fast/ruby/ruby-rt-with-region-crash.html [ Skip ]
+inspector/dom/content-node-region-info.html [ Skip ]
+fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html [ Skip ]

Modified: trunk/LayoutTests/fast/css/will-change/resources/will-change-stacking-helper.js (220869 => 220870)


--- trunk/LayoutTests/fast/css/will-change/resources/will-change-stacking-helper.js	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/fast/css/will-change/resources/will-change-stacking-helper.js	2017-08-17 19:18:54 UTC (rev 220870)
@@ -24,7 +24,6 @@
     { 'property' : '-webkit-mask-box-image', 'stacking' : true },
     { 'property' : '-webkit-transform', 'stacking' : true },
     { 'property' : '-webkit-transform-style', 'stacking' : true },
-    { 'property' : '-webkit-flow-from', 'stacking' : true },
 ];
 
 function makeStackingElement(stackingProperty, value)

Modified: trunk/LayoutTests/fast/dom/collection-iterators-expected.txt (220869 => 220870)


--- trunk/LayoutTests/fast/dom/collection-iterators-expected.txt	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/fast/dom/collection-iterators-expected.txt	2017-08-17 19:18:54 UTC (rev 220870)
@@ -48,14 +48,6 @@
 PASS 'forEach' in obj is false
 PASS 'values' in obj is false
 
-* WebKitNamedFlowCollection
-PASS Symbol.iterator in obj is true
-PASS for..of did not throw an exception
-PASS 'entries' in obj is false
-PASS 'keys' in obj is false
-PASS 'forEach' in obj is false
-PASS 'values' in obj is false
-
 * Plugin
 PASS obj.__proto__ is Plugin.prototype
 PASS Symbol.iterator in obj is true

Modified: trunk/LayoutTests/fast/dom/collection-iterators.html (220869 => 220870)


--- trunk/LayoutTests/fast/dom/collection-iterators.html	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/fast/dom/collection-iterators.html	2017-08-17 19:18:54 UTC (rev 220870)
@@ -45,7 +45,6 @@
 checkHasIterator("CSSStyleDeclaration", window.getComputedStyle(document.body));
 checkHasIterator("CSSValueList", window.getComputedStyle(document.body).getPropertyCSSValue('background-position'));
 checkHasIterator("MimeTypeArray", navigator.mimeTypes);
-checkHasIterator("WebKitNamedFlowCollection", document.webkitGetNamedFlows());
 if (navigator.plugins.length)
     checkHasIterator("Plugin", navigator.plugins[0]);
 checkHasIterator("PluginArray", navigator.plugins);

Modified: trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt (220869 => 220870)


--- trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt	2017-08-17 19:18:54 UTC (rev 220870)
@@ -134,7 +134,6 @@
 PASS a["clientHeight"] is 0
 PASS a["innerHTML"] is nerget
 PASS a["outerHTML"] is <a id="foo" href=""
-PASS a["webkitRegionOverset"] is undefined
 PASS a["oncopy"] is null
 PASS a["oncut"] is null
 PASS a["onpaste"] is null

Modified: trunk/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt (220869 => 220870)


--- trunk/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt	2017-08-17 19:18:54 UTC (rev 220870)
@@ -134,7 +134,6 @@
 PASS a["clientHeight"] is 0
 PASS a["innerHTML"] is nerget
 PASS a["outerHTML"] is <a id="foo" href=""
-PASS a["webkitRegionOverset"] is undefined
 PASS a["oncopy"] is null
 PASS a["oncut"] is null
 PASS a["onpaste"] is null

Modified: trunk/LayoutTests/platform/ios/fast/dom/collection-iterators-expected.txt (220869 => 220870)


--- trunk/LayoutTests/platform/ios/fast/dom/collection-iterators-expected.txt	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/platform/ios/fast/dom/collection-iterators-expected.txt	2017-08-17 19:18:54 UTC (rev 220870)
@@ -48,14 +48,6 @@
 PASS 'forEach' in obj is false
 PASS 'values' in obj is false
 
-* WebKitNamedFlowCollection
-PASS Symbol.iterator in obj is true
-PASS for..of did not throw an exception
-PASS 'entries' in obj is false
-PASS 'keys' in obj is false
-PASS 'forEach' in obj is false
-PASS 'values' in obj is false
-
 * PluginArray
 PASS obj.__proto__ is PluginArray.prototype
 PASS Symbol.iterator in obj is true

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (220869 => 220870)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-08-17 19:18:54 UTC (rev 220870)
@@ -747,3 +747,6 @@
 webkit.org/b/173946 [ Debug ] media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Pass Failure ]
 
 webkit.org/b/175270 [ Debug ] plugins/crash-restoring-plugin-page-from-page-cache.html [ Skip ]
+
+# CSS Regions are being phased out.
+tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html [ Skip ]

Modified: trunk/LayoutTests/platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt (220869 => 220870)


--- trunk/LayoutTests/platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt	2017-08-17 19:18:54 UTC (rev 220870)
@@ -50,7 +50,6 @@
 PASS a["clientWidth"] is 0
 PASS a["scrollWidth"] is 0
 PASS a["attributes"] is [object NamedNodeMap]
-PASS a["webkitRegionOverset"] is undefined
 PASS a["ALLOW_KEYBOARD_INPUT"] is 1
 PASS a["offsetWidth"] is 39
 PASS a["classList"] is 

Modified: trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt (220869 => 220870)


--- trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt	2017-08-17 19:18:54 UTC (rev 220870)
@@ -133,7 +133,6 @@
 PASS a["clientHeight"] is 0
 PASS a["innerHTML"] is nerget
 PASS a["outerHTML"] is <a id="foo" href=""
-PASS a["webkitRegionOverset"] is undefined
 PASS a["oncopy"] is null
 PASS a["oncut"] is null
 PASS a["onpaste"] is null

Modified: trunk/Source/_javascript_Core/ChangeLog (220869 => 220870)


--- trunk/Source/_javascript_Core/ChangeLog	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-08-17 19:18:54 UTC (rev 220870)
@@ -1,3 +1,12 @@
+2017-08-17  Andreas Kling  <[email protected]>
+
+        Disable CSS regions at compile time
+        https://bugs.webkit.org/show_bug.cgi?id=175630
+
+        Reviewed by Antti Koivisto.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-08-17  Jacobo Aragunde PĂ©rez  <[email protected]>
 
         [WPE][GTK] Ensure proper casting of data in gvariants

Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (220869 => 220870)


--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-08-17 19:18:54 UTC (rev 220870)
@@ -79,7 +79,7 @@
 ENABLE_CSS_DEVICE_ADAPTATION = ;
 ENABLE_CSS_IMAGE_ORIENTATION = ;
 ENABLE_CSS_IMAGE_RESOLUTION = ;
-ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
+ENABLE_CSS_REGIONS = ;
 ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
 ENABLE_CSS3_TEXT = ;
 ENABLE_CURSOR_VISIBILITY = ENABLE_CURSOR_VISIBILITY;

Modified: trunk/Source/WebCore/ChangeLog (220869 => 220870)


--- trunk/Source/WebCore/ChangeLog	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/WebCore/ChangeLog	2017-08-17 19:18:54 UTC (rev 220870)
@@ -1,3 +1,12 @@
+2017-08-17  Andreas Kling  <[email protected]>
+
+        Disable CSS regions at compile time
+        https://bugs.webkit.org/show_bug.cgi?id=175630
+
+        Reviewed by Antti Koivisto.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-08-17  Wenson Hsieh  <[email protected]>
 
         [iOS] Respect type fidelities when copying image elements to the pasteboard

Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (220869 => 220870)


--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2017-08-17 19:18:54 UTC (rev 220870)
@@ -79,7 +79,7 @@
 ENABLE_CSS_DEVICE_ADAPTATION = ;
 ENABLE_CSS_IMAGE_ORIENTATION = ;
 ENABLE_CSS_IMAGE_RESOLUTION = ;
-ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
+ENABLE_CSS_REGIONS = ;
 ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
 ENABLE_CSS3_TEXT = ;
 ENABLE_CURSOR_VISIBILITY = ENABLE_CURSOR_VISIBILITY;

Modified: trunk/Source/WebCore/PAL/ChangeLog (220869 => 220870)


--- trunk/Source/WebCore/PAL/ChangeLog	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/WebCore/PAL/ChangeLog	2017-08-17 19:18:54 UTC (rev 220870)
@@ -1,3 +1,12 @@
+2017-08-17  Andreas Kling  <[email protected]>
+
+        Disable CSS regions at compile time
+        https://bugs.webkit.org/show_bug.cgi?id=175630
+
+        Reviewed by Antti Koivisto.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-08-17  Wenson Hsieh  <[email protected]>
 
         [iOS] Respect type fidelities when copying image elements to the pasteboard

Modified: trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (220869 => 220870)


--- trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig	2017-08-17 19:18:54 UTC (rev 220870)
@@ -79,7 +79,7 @@
 ENABLE_CSS_DEVICE_ADAPTATION = ;
 ENABLE_CSS_IMAGE_ORIENTATION = ;
 ENABLE_CSS_IMAGE_RESOLUTION = ;
-ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
+ENABLE_CSS_REGIONS = ;
 ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
 ENABLE_CSS3_TEXT = ;
 ENABLE_CURSOR_VISIBILITY = ENABLE_CURSOR_VISIBILITY;

Modified: trunk/Source/WebKit/ChangeLog (220869 => 220870)


--- trunk/Source/WebKit/ChangeLog	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/WebKit/ChangeLog	2017-08-17 19:18:54 UTC (rev 220870)
@@ -1,3 +1,12 @@
+2017-08-17  Andreas Kling  <[email protected]>
+
+        Disable CSS regions at compile time
+        https://bugs.webkit.org/show_bug.cgi?id=175630
+
+        Reviewed by Antti Koivisto.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-08-17  Wenson Hsieh  <[email protected]>
 
         [iOS] Respect type fidelities when copying image elements to the pasteboard

Modified: trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig (220869 => 220870)


--- trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig	2017-08-17 19:18:54 UTC (rev 220870)
@@ -79,7 +79,7 @@
 ENABLE_CSS_DEVICE_ADAPTATION = ;
 ENABLE_CSS_IMAGE_ORIENTATION = ;
 ENABLE_CSS_IMAGE_RESOLUTION = ;
-ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
+ENABLE_CSS_REGIONS = ;
 ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
 ENABLE_CSS3_TEXT = ;
 ENABLE_CURSOR_VISIBILITY = ENABLE_CURSOR_VISIBILITY;

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (220869 => 220870)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2017-08-17 19:18:54 UTC (rev 220870)
@@ -1,3 +1,12 @@
+2017-08-17  Andreas Kling  <[email protected]>
+
+        Disable CSS regions at compile time
+        https://bugs.webkit.org/show_bug.cgi?id=175630
+
+        Reviewed by Antti Koivisto.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-08-17  Don Olmstead  <[email protected]>
 
         [PAL] Move SessionID into PAL

Modified: trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig (220869 => 220870)


--- trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig	2017-08-17 19:18:54 UTC (rev 220870)
@@ -79,7 +79,7 @@
 ENABLE_CSS_DEVICE_ADAPTATION = ;
 ENABLE_CSS_IMAGE_ORIENTATION = ;
 ENABLE_CSS_IMAGE_RESOLUTION = ;
-ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
+ENABLE_CSS_REGIONS = ;
 ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
 ENABLE_CSS3_TEXT = ;
 ENABLE_CURSOR_VISIBILITY = ENABLE_CURSOR_VISIBILITY;

Modified: trunk/Source/cmake/OptionsGTK.cmake (220869 => 220870)


--- trunk/Source/cmake/OptionsGTK.cmake	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/cmake/OptionsGTK.cmake	2017-08-17 19:18:54 UTC (rev 220870)
@@ -154,7 +154,7 @@
 # Changing these options is completely unsupported.
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_TRANSFORMS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOWNLOAD_ATTRIBUTE PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF)

Modified: trunk/Source/cmake/OptionsMac.cmake (220869 => 220870)


--- trunk/Source/cmake/OptionsMac.cmake	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/cmake/OptionsMac.cmake	2017-08-17 19:18:54 UTC (rev 220870)
@@ -17,7 +17,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_DEVICE_ADAPTATION PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_ORIENTATION PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_RESOLUTION PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SCROLL_SNAP PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT PRIVATE OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CURSOR_VISIBILITY PRIVATE ON)

Modified: trunk/Source/cmake/OptionsWPE.cmake (220869 => 220870)


--- trunk/Source/cmake/OptionsWPE.cmake	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/cmake/OptionsWPE.cmake	2017-08-17 19:18:54 UTC (rev 220870)
@@ -13,7 +13,7 @@
 
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_TRANSFORMS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DEVICE_ORIENTATION PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PUBLIC OFF)

Modified: trunk/Source/cmake/OptionsWin.cmake (220869 => 220870)


--- trunk/Source/cmake/OptionsWin.cmake	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/cmake/OptionsWin.cmake	2017-08-17 19:18:54 UTC (rev 220870)
@@ -22,7 +22,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_BOX_DECORATION_BREAK PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_COMPOSITING PUBLIC OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CURSOR_VISIBILITY PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CUSTOM_SCHEME_HANDLER PUBLIC OFF)

Modified: trunk/Source/cmake/tools/vsprops/FeatureDefines.props (220869 => 220870)


--- trunk/Source/cmake/tools/vsprops/FeatureDefines.props	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/cmake/tools/vsprops/FeatureDefines.props	2017-08-17 19:18:54 UTC (rev 220870)
@@ -12,7 +12,7 @@
     <ENABLE_CSS_BOX_DECORATION_BREAK>ENABLE_CSS_BOX_DECORATION_BREAK</ENABLE_CSS_BOX_DECORATION_BREAK>
     <ENABLE_CSS_COMPOSITING />
     <ENABLE_CSS_IMAGE_SET>ENABLE_CSS_IMAGE_SET</ENABLE_CSS_IMAGE_SET>
-    <ENABLE_CSS_REGIONS>ENABLE_CSS_REGIONS</ENABLE_CSS_REGIONS>
+    <ENABLE_CSS_REGIONS />
     <ENABLE_CSS_SELECTORS_LEVEL4>ENABLE_CSS_SELECTORS_LEVEL4</ENABLE_CSS_SELECTORS_LEVEL4>
     <ENABLE_CSS_SHADERS />
     <ENABLE_CSS_SHAPE_INSIDE>ENABLE_CSS_SHAPE_INSIDE</ENABLE_CSS_SHAPE_INSIDE>

Modified: trunk/Source/cmake/tools/vsprops/FeatureDefinesCairo.props (220869 => 220870)


--- trunk/Source/cmake/tools/vsprops/FeatureDefinesCairo.props	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Source/cmake/tools/vsprops/FeatureDefinesCairo.props	2017-08-17 19:18:54 UTC (rev 220870)
@@ -12,7 +12,7 @@
     <ENABLE_CSS_BOX_DECORATION_BREAK>ENABLE_CSS_BOX_DECORATION_BREAK</ENABLE_CSS_BOX_DECORATION_BREAK>
     <ENABLE_CSS_COMPOSITING />
     <ENABLE_CSS_IMAGE_SET>ENABLE_CSS_IMAGE_SET</ENABLE_CSS_IMAGE_SET>
-    <ENABLE_CSS_REGIONS>ENABLE_CSS_REGIONS</ENABLE_CSS_REGIONS>
+    <ENABLE_CSS_REGIONS />
     <ENABLE_CSS_SELECTORS_LEVEL4>ENABLE_CSS_SELECTORS_LEVEL4</ENABLE_CSS_SELECTORS_LEVEL4>
     <ENABLE_CSS_SHADERS />
     <ENABLE_CSS_SHAPE_INSIDE>ENABLE_CSS_SHAPE_INSIDE</ENABLE_CSS_SHAPE_INSIDE>

Modified: trunk/Tools/ChangeLog (220869 => 220870)


--- trunk/Tools/ChangeLog	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Tools/ChangeLog	2017-08-17 19:18:54 UTC (rev 220870)
@@ -1,3 +1,13 @@
+2017-08-17  Andreas Kling  <[email protected]>
+
+        Disable CSS regions at compile time
+        https://bugs.webkit.org/show_bug.cgi?id=175630
+
+        Reviewed by Antti Koivisto.
+
+        * Scripts/webkitperl/FeatureList.pm:
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
 2017-08-17  Wenson Hsieh  <[email protected]>
 
         Unreviewed, try to fix the internal iOS 10 build after r220865.

Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (220869 => 220870)


--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2017-08-17 19:18:54 UTC (rev 220870)
@@ -179,7 +179,7 @@
       define => "ENABLE_CSS_IMAGE_SET", default => (isGtk() || isWPE()), value => \$cssImageSetSupport },
 
     { option => "css-regions", desc => "Toggle CSS Regions support",
-      define => "ENABLE_CSS_REGIONS", default => 1, value => \$cssRegionsSupport },
+      define => "ENABLE_CSS_REGIONS", default => 0, value => \$cssRegionsSupport },
 
     { option => "css-shapes", desc => "Toggle CSS Shapes support",
       define => "ENABLE_CSS_SHAPES", default => 1, value => \$cssShapesSupport },

Modified: trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig (220869 => 220870)


--- trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2017-08-17 19:01:08 UTC (rev 220869)
+++ trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig	2017-08-17 19:18:54 UTC (rev 220870)
@@ -79,7 +79,7 @@
 ENABLE_CSS_DEVICE_ADAPTATION = ;
 ENABLE_CSS_IMAGE_ORIENTATION = ;
 ENABLE_CSS_IMAGE_RESOLUTION = ;
-ENABLE_CSS_REGIONS = ENABLE_CSS_REGIONS;
+ENABLE_CSS_REGIONS = ;
 ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
 ENABLE_CSS3_TEXT = ;
 ENABLE_CURSOR_VISIBILITY = ENABLE_CURSOR_VISIBILITY;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to