Title: [220901] trunk
- Revision
- 220901
- Author
- [email protected]
- Date
- 2017-08-17 21:13:36 -0700 (Thu, 17 Aug 2017)
Log Message
[Input Events] Rename inputType "formatForeColor" to "formatFontColor"
https://bugs.webkit.org/show_bug.cgi?id=175703
Reviewed by Ryosuke Niwa.
Source/WebCore:
Renames an inputType value to match the spec. There is no other change in behavior.
Rebaselines fast/events/input-events-selection-forecolor-data.html and fast/events/input-events-forecolor-data.html.
* editing/EditCommand.cpp:
(WebCore::inputTypeNameForEditingAction):
LayoutTests:
Rebaselines two LayoutTests that check for the "formatForeColor" inputType.
* fast/events/input-events-forecolor-data-expected.txt:
* fast/events/input-events-selection-forecolor-data.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (220900 => 220901)
--- trunk/LayoutTests/ChangeLog 2017-08-18 04:03:24 UTC (rev 220900)
+++ trunk/LayoutTests/ChangeLog 2017-08-18 04:13:36 UTC (rev 220901)
@@ -1,3 +1,15 @@
+2017-08-17 Wenson Hsieh <[email protected]>
+
+ [Input Events] Rename inputType "formatForeColor" to "formatFontColor"
+ https://bugs.webkit.org/show_bug.cgi?id=175703
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaselines two LayoutTests that check for the "formatForeColor" inputType.
+
+ * fast/events/input-events-forecolor-data-expected.txt:
+ * fast/events/input-events-selection-forecolor-data.html:
+
2017-08-17 Ryan Haddad <[email protected]>
Mark media/video-controls-rendering.html as flaky.
Modified: trunk/LayoutTests/fast/events/input-events-forecolor-data-expected.txt (220900 => 220901)
--- trunk/LayoutTests/fast/events/input-events-forecolor-data-expected.txt 2017-08-18 04:03:24 UTC (rev 220900)
+++ trunk/LayoutTests/fast/events/input-events-forecolor-data-expected.txt 2017-08-18 04:13:36 UTC (rev 220901)
@@ -4,28 +4,28 @@
event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
event.data = "" 255, 255)
event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
event.data = "" 255, 255)
event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
event.data = "" 255, 0)
event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
event.data = "" 255, 0)
event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
event.data = "" 0, 0)
event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
event.data = "" 0, 0)
event.type = beforeinput
-event.inputType = formatForeColor
+event.inputType = formatFontColor
event.data = "" 0, 0)
event.type = input
-event.inputType = formatForeColor
+event.inputType = formatFontColor
event.data = "" 0, 0)
PASS successfullyParsed is true
Modified: trunk/LayoutTests/fast/events/input-events-selection-forecolor-data.html (220900 => 220901)
--- trunk/LayoutTests/fast/events/input-events-selection-forecolor-data.html 2017-08-18 04:03:24 UTC (rev 220900)
+++ trunk/LayoutTests/fast/events/input-events-selection-forecolor-data.html 2017-08-18 04:13:36 UTC (rev 220901)
@@ -29,7 +29,7 @@
function handleInput(event)
{
- if (event.inputType === "formatForeColor")
+ if (event.inputType === "formatFontColor")
write(`Received ${event.type} event with data: "${event.data}"`);
}
</script>
Modified: trunk/Source/WebCore/ChangeLog (220900 => 220901)
--- trunk/Source/WebCore/ChangeLog 2017-08-18 04:03:24 UTC (rev 220900)
+++ trunk/Source/WebCore/ChangeLog 2017-08-18 04:13:36 UTC (rev 220901)
@@ -1,3 +1,16 @@
+2017-08-17 Wenson Hsieh <[email protected]>
+
+ [Input Events] Rename inputType "formatForeColor" to "formatFontColor"
+ https://bugs.webkit.org/show_bug.cgi?id=175703
+
+ Reviewed by Ryosuke Niwa.
+
+ Renames an inputType value to match the spec. There is no other change in behavior.
+ Rebaselines fast/events/input-events-selection-forecolor-data.html and fast/events/input-events-forecolor-data.html.
+
+ * editing/EditCommand.cpp:
+ (WebCore::inputTypeNameForEditingAction):
+
2017-08-17 Daewoong Jang <[email protected]>
[Curl] Improve multi-threaded networking
Modified: trunk/Source/WebCore/editing/EditCommand.cpp (220900 => 220901)
--- trunk/Source/WebCore/editing/EditCommand.cpp 2017-08-18 04:03:24 UTC (rev 220900)
+++ trunk/Source/WebCore/editing/EditCommand.cpp 2017-08-18 04:13:36 UTC (rev 220901)
@@ -56,7 +56,7 @@
case EditActionUnderline:
return ASCIILiteral("formatUnderline");
case EditActionSetColor:
- return ASCIILiteral("formatForeColor");
+ return ASCIILiteral("formatFontColor");
case EditActionDeleteByDrag:
return ASCIILiteral("deleteByDrag");
case EditActionCut:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
