Title: [220930] trunk/Source
- Revision
- 220930
- Author
- [email protected]
- Date
- 2017-08-18 13:50:59 -0700 (Fri, 18 Aug 2017)
Log Message
[Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=173536
Reviewed by Brent Fulgham.
If the tree state is dirty, accessible objects are deleted while iterating over children
under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
style is updated before this method is called.
Source/WebCore:
No new tests, covered by existing tests.
* accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue):
Source/WebKitLegacy/win:
* AccessibleBase.cpp:
(AccessibleBase::getAccessibilityObjectForChild):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (220929 => 220930)
--- trunk/Source/WebCore/ChangeLog 2017-08-18 20:16:57 UTC (rev 220929)
+++ trunk/Source/WebCore/ChangeLog 2017-08-18 20:50:59 UTC (rev 220930)
@@ -1,3 +1,19 @@
+2017-08-18 Per Arne Vollan <[email protected]>
+
+ [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
+ https://bugs.webkit.org/show_bug.cgi?id=173536
+
+ Reviewed by Brent Fulgham.
+
+ If the tree state is dirty, accessible objects are deleted while iterating over children
+ under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
+ style is updated before this method is called.
+
+ No new tests, covered by existing tests.
+
+ * accessibility/win/AccessibilityObjectWrapperWin.cpp:
+ (WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue):
+
2017-08-18 Youenn Fablet <[email protected]>
[Cache API] Add response body storage
Modified: trunk/Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp (220929 => 220930)
--- trunk/Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp 2017-08-18 20:16:57 UTC (rev 220929)
+++ trunk/Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp 2017-08-18 20:50:59 UTC (rev 220930)
@@ -40,6 +40,8 @@
{
// FIXME: This should be fleshed out to match the Mac version
+ m_object->updateBackingStore();
+
// Not a real concept on Windows, but used heavily in WebKit accessibility testing.
if (attributeName == "AXTitleUIElementAttribute") {
if (!m_object->exposesTitleUIElement())
Modified: trunk/Source/WebKitLegacy/win/AccessibleBase.cpp (220929 => 220930)
--- trunk/Source/WebKitLegacy/win/AccessibleBase.cpp 2017-08-18 20:16:57 UTC (rev 220929)
+++ trunk/Source/WebKitLegacy/win/AccessibleBase.cpp 2017-08-18 20:50:59 UTC (rev 220930)
@@ -1021,6 +1021,8 @@
if (!m_object)
return E_FAIL;
+ m_object->updateBackingStore();
+
if (vChild.vt != VT_I4)
return E_INVALIDARG;
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (220929 => 220930)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2017-08-18 20:16:57 UTC (rev 220929)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2017-08-18 20:50:59 UTC (rev 220930)
@@ -1,3 +1,17 @@
+2017-08-18 Per Arne Vollan <[email protected]>
+
+ [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
+ https://bugs.webkit.org/show_bug.cgi?id=173536
+
+ Reviewed by Brent Fulgham.
+
+ If the tree state is dirty, accessible objects are deleted while iterating over children
+ under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
+ style is updated before this method is called.
+
+ * AccessibleBase.cpp:
+ (AccessibleBase::getAccessibilityObjectForChild):
+
2017-08-17 Don Olmstead <[email protected]>
[PAL] Move SessionID into PAL
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
