Title: [220950] trunk
Revision
220950
Author
[email protected]
Date
2017-08-18 20:05:57 -0700 (Fri, 18 Aug 2017)

Log Message

REGRESSION(r219640): Speedometer no longer runs on Safari 7
https://bugs.webkit.org/show_bug.cgi?id=175749

Reviewed by Joseph Pecoraro.

PerformanceTests:

Use regular string instead of template literal to make the script compatible with older versions of Safari.

* Speedometer/resources/benchmark-runner.js:
(BenchmarkRunner.prototype._runTest):

Websites/browserbench.org:

Fix the bug on browserbench.org.

* Speedometer/resources/benchmark-runner.js:
(BenchmarkRunner.prototype._runTest):

Modified Paths

Diff

Modified: trunk/PerformanceTests/ChangeLog (220949 => 220950)


--- trunk/PerformanceTests/ChangeLog	2017-08-19 01:40:54 UTC (rev 220949)
+++ trunk/PerformanceTests/ChangeLog	2017-08-19 03:05:57 UTC (rev 220950)
@@ -1,3 +1,15 @@
+2017-08-18  Ryosuke Niwa  <[email protected]>
+
+        REGRESSION(r219640): Speedometer no longer runs on Safari 7
+        https://bugs.webkit.org/show_bug.cgi?id=175749
+
+        Reviewed by Joseph Pecoraro.
+
+        Use regular string instead of template literal to make the script compatible with older versions of Safari.
+
+        * Speedometer/resources/benchmark-runner.js:
+        (BenchmarkRunner.prototype._runTest):
+
 2017-08-17  Mathias Bynens  <[email protected]>
 
         Speedometer: Update to modern Vue.js version

Modified: trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js (220949 => 220950)


--- trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js	2017-08-19 01:40:54 UTC (rev 220949)
+++ trunk/PerformanceTests/Speedometer/resources/benchmark-runner.js	2017-08-19 03:05:57 UTC (rev 220950)
@@ -126,11 +126,11 @@
     var contentWindow = self._frame.contentWindow;
     var contentDocument = self._frame.contentDocument;
 
-    self._writeMark(`${suite.name}.${test.name}-start`);
+    self._writeMark(suite.name + '.' + test.name + '-start');
     var startTime = now();
     test.run(prepareReturnValue, contentWindow, contentDocument);
     var endTime = now();
-    self._writeMark(`${suite.name}.${test.name}-sync-end`);
+    self._writeMark(suite.name + '.' + test.name + '-sync-end');
 
     var syncTime = endTime - startTime;
 
@@ -137,7 +137,7 @@
     var startTime = now();
     setTimeout(function () {
         var endTime = now();
-        self._writeMark(`${suite.name}.${test.name}-async-end`);
+        self._writeMark(suite.name + '.' + test.name + '-async-end');
         callback(syncTime, endTime - startTime);
     }, 0);
 }

Modified: trunk/Websites/browserbench.org/ChangeLog (220949 => 220950)


--- trunk/Websites/browserbench.org/ChangeLog	2017-08-19 01:40:54 UTC (rev 220949)
+++ trunk/Websites/browserbench.org/ChangeLog	2017-08-19 03:05:57 UTC (rev 220950)
@@ -1,3 +1,15 @@
+2017-08-18  Ryosuke Niwa  <[email protected]>
+
+        REGRESSION(r219640): Speedometer no longer runs on Safari 7
+        https://bugs.webkit.org/show_bug.cgi?id=175749
+
+        Reviewed by Joseph Pecoraro.
+
+        Fix the bug on browserbench.org.
+
+        * Speedometer/resources/benchmark-runner.js:
+        (BenchmarkRunner.prototype._runTest):
+
 2017-07-18  Ryosuke Niwa  <[email protected]>
 
         Merge r219640 into Speedometer 1.0.

Modified: trunk/Websites/browserbench.org/Speedometer/resources/benchmark-runner.js (220949 => 220950)


--- trunk/Websites/browserbench.org/Speedometer/resources/benchmark-runner.js	2017-08-19 01:40:54 UTC (rev 220949)
+++ trunk/Websites/browserbench.org/Speedometer/resources/benchmark-runner.js	2017-08-19 03:05:57 UTC (rev 220950)
@@ -126,11 +126,11 @@
     var contentWindow = self._frame.contentWindow;
     var contentDocument = self._frame.contentDocument;
 
-    self._writeMark(`${suite.name}.${test.name}-start`);
+    self._writeMark(suite.name + '.' + test.name + '-start');
     var startTime = now();
     test.run(prepareReturnValue, contentWindow, contentDocument);
     var endTime = now();
-    self._writeMark(`${suite.name}.${test.name}-sync-end`);
+    self._writeMark(suite.name + '.' + test.name + '-sync-end');
 
     var syncTime = endTime - startTime;
 
@@ -137,7 +137,7 @@
     var startTime = now();
     setTimeout(function () {
         var endTime = now();
-        self._writeMark(`${suite.name}.${test.name}-async-end`);
+        self._writeMark(suite.name + '.' + test.name + '-async-end');
         callback(syncTime, endTime - startTime);
     }, 0);
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to