Title: [220966] trunk/Tools
- Revision
- 220966
- Author
- [email protected]
- Date
- 2017-08-21 09:30:54 -0700 (Mon, 21 Aug 2017)
Log Message
Add WTFLogChannel level to allow runtime log filtering
https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>
Unreviewed build fix.
* TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::LoggingTest::output): Disable testing output by default because it
fails on some of the bots.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (220965 => 220966)
--- trunk/Tools/ChangeLog 2017-08-21 15:44:28 UTC (rev 220965)
+++ trunk/Tools/ChangeLog 2017-08-21 16:30:54 UTC (rev 220966)
@@ -4,6 +4,18 @@
https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>
+ Unreviewed build fix.
+
+ * TestWebKitAPI/Tests/WebCore/Logging.cpp:
+ (TestWebKitAPI::LoggingTest::output): Disable testing output by default because it
+ fails on some of the bots.
+
+2017-08-21 Eric Carlson <[email protected]>
+
+ Add WTFLogChannel level to allow runtime log filtering
+ https://bugs.webkit.org/show_bug.cgi?id=175731
+ <rdar://problem/33967234>
+
Reviewed by Jer Noble.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp (220965 => 220966)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp 2017-08-21 15:44:28 UTC (rev 220965)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp 2017-08-21 16:30:54 UTC (rev 220966)
@@ -47,7 +47,9 @@
};
static const size_t logChannelCount = sizeof(testLogChannels) / sizeof(testLogChannels[0]);
-#define TEST_OUTPUT (!PLATFORM(COCOA) || (!PLATFORM(IOS) || __MAC_OS_X_VERSION_MAX_ALLOWED >= 101200))
+// Define the following to enable all tests. Disabled by default because replacing stderr with a
+// non-blocking pipe fails on some of the bots.
+#define TEST_OUTPUT 0
namespace TestWebKitAPI {
@@ -57,7 +59,7 @@
{
WTF::initializeMainThread();
- // Replace stderr with a nonblocking pipe that we can read from.
+ // Replace stderr with a non-blocking pipe that we can read from.
pipe(m_descriptors);
fcntl(m_descriptors[0], F_SETFL, fcntl(m_descriptors[0], F_GETFL, 0) | O_NONBLOCK);
dup2(m_descriptors[1], STDERR_FILENO);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
