Diff
Modified: trunk/Source/WebCore/ChangeLog (221021 => 221022)
--- trunk/Source/WebCore/ChangeLog 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebCore/ChangeLog 2017-08-22 17:38:14 UTC (rev 221022)
@@ -1,3 +1,20 @@
+2017-08-22 Alex Christensen <[email protected]>
+
+ Remove ChromeClient::hasOpenedPopup
+ https://bugs.webkit.org/show_bug.cgi?id=175804
+
+ Reviewed by Sam Weinig.
+
+ No change in behavior. All implementations just returned false.
+
+ * loader/EmptyClients.h:
+ * page/Chrome.cpp:
+ (WebCore::Chrome::hasOpenedPopup const): Deleted.
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * rendering/RenderMenuList.cpp:
+ (RenderMenuList::showPopup):
+
2017-08-22 Andy Estes <[email protected]>
[Payment Request] Implement error checking for show(), abort(), and canMakePayment()
Modified: trunk/Source/WebCore/loader/EmptyClients.h (221021 => 221022)
--- trunk/Source/WebCore/loader/EmptyClients.h 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2017-08-22 17:38:14 UTC (rev 221022)
@@ -94,7 +94,6 @@
bool selectItemWritingDirectionIsNatural() final { return false; }
bool selectItemAlignmentFollowsMenuWritingDirection() final { return false; }
- bool hasOpenedPopup() const final { return false; }
RefPtr<PopupMenu> createPopupMenu(PopupMenuClient&) const final;
RefPtr<SearchPopupMenu> createSearchPopupMenu(PopupMenuClient&) const final;
Modified: trunk/Source/WebCore/page/Chrome.cpp (221021 => 221022)
--- trunk/Source/WebCore/page/Chrome.cpp 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebCore/page/Chrome.cpp 2017-08-22 17:38:14 UTC (rev 221022)
@@ -521,11 +521,6 @@
return m_client.selectItemAlignmentFollowsMenuWritingDirection();
}
-bool Chrome::hasOpenedPopup() const
-{
- return m_client.hasOpenedPopup();
-}
-
RefPtr<PopupMenu> Chrome::createPopupMenu(PopupMenuClient& client) const
{
notifyPopupOpeningObservers();
Modified: trunk/Source/WebCore/page/Chrome.h (221021 => 221022)
--- trunk/Source/WebCore/page/Chrome.h 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebCore/page/Chrome.h 2017-08-22 17:38:14 UTC (rev 221022)
@@ -167,7 +167,6 @@
bool selectItemWritingDirectionIsNatural();
bool selectItemAlignmentFollowsMenuWritingDirection();
- bool hasOpenedPopup() const;
RefPtr<PopupMenu> createPopupMenu(PopupMenuClient&) const;
RefPtr<SearchPopupMenu> createSearchPopupMenu(PopupMenuClient&) const;
Modified: trunk/Source/WebCore/page/ChromeClient.h (221021 => 221022)
--- trunk/Source/WebCore/page/ChromeClient.h 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebCore/page/ChromeClient.h 2017-08-22 17:38:14 UTC (rev 221022)
@@ -381,7 +381,6 @@
virtual bool selectItemWritingDirectionIsNatural() = 0;
virtual bool selectItemAlignmentFollowsMenuWritingDirection() = 0;
// Checks if there is an opened popup, called by RenderMenuList::showPopup().
- virtual bool hasOpenedPopup() const = 0;
virtual RefPtr<PopupMenu> createPopupMenu(PopupMenuClient&) const = 0;
virtual RefPtr<SearchPopupMenu> createSearchPopupMenu(PopupMenuClient&) const = 0;
Modified: trunk/Source/WebCore/rendering/RenderMenuList.cpp (221021 => 221022)
--- trunk/Source/WebCore/rendering/RenderMenuList.cpp 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebCore/rendering/RenderMenuList.cpp 2017-08-22 17:38:14 UTC (rev 221022)
@@ -370,9 +370,6 @@
if (m_popupIsVisible)
return;
- if (document().page()->chrome().hasOpenedPopup())
- return;
-
// Create m_innerBlock here so it ends up as the first child.
// This is important because otherwise we might try to create m_innerBlock
// inside the showPopup call and it would fail.
Modified: trunk/Source/WebKit/ChangeLog (221021 => 221022)
--- trunk/Source/WebKit/ChangeLog 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebKit/ChangeLog 2017-08-22 17:38:14 UTC (rev 221022)
@@ -1,3 +1,14 @@
+2017-08-22 Alex Christensen <[email protected]>
+
+ Remove ChromeClient::hasOpenedPopup
+ https://bugs.webkit.org/show_bug.cgi?id=175804
+
+ Reviewed by Sam Weinig.
+
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::hasOpenedPopup const): Deleted.
+ * WebProcess/WebCoreSupport/WebChromeClient.h:
+
2017-08-22 Brent Fulgham <[email protected]> and Pranjal Jumde <[email protected]>
Disable access to secure cookies if an HTTPS site loads mixed content
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp (221021 => 221022)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp 2017-08-22 17:38:14 UTC (rev 221022)
@@ -828,12 +828,6 @@
return true;
}
-bool WebChromeClient::hasOpenedPopup() const
-{
- notImplemented();
- return false;
-}
-
RefPtr<PopupMenu> WebChromeClient::createPopupMenu(PopupMenuClient& client) const
{
return WebPopupMenu::create(&m_page, &client);
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h (221021 => 221022)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h 2017-08-22 17:38:14 UTC (rev 221022)
@@ -199,7 +199,6 @@
bool selectItemWritingDirectionIsNatural() final;
bool selectItemAlignmentFollowsMenuWritingDirection() final;
- bool hasOpenedPopup() const final;
RefPtr<WebCore::PopupMenu> createPopupMenu(WebCore::PopupMenuClient&) const final;
RefPtr<WebCore::SearchPopupMenu> createSearchPopupMenu(WebCore::PopupMenuClient&) const final;
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (221021 => 221022)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2017-08-22 17:38:14 UTC (rev 221022)
@@ -1,3 +1,14 @@
+2017-08-22 Alex Christensen <[email protected]>
+
+ Remove ChromeClient::hasOpenedPopup
+ https://bugs.webkit.org/show_bug.cgi?id=175804
+
+ Reviewed by Sam Weinig.
+
+ * WebCoreSupport/WebChromeClient.h:
+ * WebCoreSupport/WebChromeClient.mm:
+ (WebChromeClient::hasOpenedPopup const): Deleted.
+
2017-08-22 Brent Fulgham <[email protected]> and Pranjal Jumde <[email protected]>
Disable access to secure cookies if an HTTPS site loads mixed content
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h (221021 => 221022)
--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h 2017-08-22 17:38:14 UTC (rev 221022)
@@ -198,7 +198,6 @@
bool selectItemWritingDirectionIsNatural() override;
bool selectItemAlignmentFollowsMenuWritingDirection() override;
- bool hasOpenedPopup() const final;
RefPtr<WebCore::PopupMenu> createPopupMenu(WebCore::PopupMenuClient&) const override;
RefPtr<WebCore::SearchPopupMenu> createSearchPopupMenu(WebCore::PopupMenuClient&) const override;
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm (221021 => 221022)
--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm 2017-08-22 17:38:14 UTC (rev 221022)
@@ -876,12 +876,6 @@
return true;
}
-bool WebChromeClient::hasOpenedPopup() const
-{
- notImplemented();
- return false;
-}
-
RefPtr<WebCore::PopupMenu> WebChromeClient::createPopupMenu(WebCore::PopupMenuClient& client) const
{
#if !PLATFORM(IOS)
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (221021 => 221022)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2017-08-22 17:38:14 UTC (rev 221022)
@@ -1,3 +1,14 @@
+2017-08-22 Alex Christensen <[email protected]>
+
+ Remove ChromeClient::hasOpenedPopup
+ https://bugs.webkit.org/show_bug.cgi?id=175804
+
+ Reviewed by Sam Weinig.
+
+ * WebCoreSupport/WebChromeClient.cpp:
+ (WebChromeClient::hasOpenedPopup const): Deleted.
+ * WebCoreSupport/WebChromeClient.h:
+
2017-08-18 Per Arne Vollan <[email protected]>
[Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.cpp (221021 => 221022)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.cpp 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.cpp 2017-08-22 17:38:14 UTC (rev 221022)
@@ -780,12 +780,6 @@
return true;
}
-bool WebChromeClient::hasOpenedPopup() const
-{
- notImplemented();
- return false;
-}
-
RefPtr<PopupMenu> WebChromeClient::createPopupMenu(PopupMenuClient& client) const
{
return adoptRef(new PopupMenuWin(&client));
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h (221021 => 221022)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h 2017-08-22 17:31:39 UTC (rev 221021)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h 2017-08-22 17:38:14 UTC (rev 221022)
@@ -150,7 +150,6 @@
bool selectItemWritingDirectionIsNatural() final;
bool selectItemAlignmentFollowsMenuWritingDirection() final;
- bool hasOpenedPopup() const final;
RefPtr<WebCore::PopupMenu> createPopupMenu(WebCore::PopupMenuClient&) const final;
RefPtr<WebCore::SearchPopupMenu> createSearchPopupMenu(WebCore::PopupMenuClient&) const final;
