Diff
Modified: trunk/Source/WebCore/ChangeLog (221027 => 221028)
--- trunk/Source/WebCore/ChangeLog 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebCore/ChangeLog 2017-08-22 18:19:33 UTC (rev 221028)
@@ -1,3 +1,19 @@
+2017-08-22 Alex Christensen <[email protected]>
+
+ Remove ChromeClient::scrollbarsModeDidChange
+ https://bugs.webkit.org/show_bug.cgi?id=175805
+
+ Reviewed by Daniel Bates.
+
+ No change in behavior. It was never called, and no implementations did anything.
+
+ * loader/EmptyClients.h:
+ * page/Chrome.cpp:
+ (WebCore::Chrome::scrollbarsModeDidChange const): Deleted.
+ * page/Chrome.h:
+ * page/ChromeClient.h:
+ * platform/HostWindow.h:
+
2017-08-22 Devin Rousso <[email protected]>
Web Inspector: provide way for ShaderPrograms to be enabled/disabled
Modified: trunk/Source/WebCore/loader/EmptyClients.h (221027 => 221028)
--- trunk/Source/WebCore/loader/EmptyClients.h 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2017-08-22 18:19:33 UTC (rev 221028)
@@ -122,7 +122,6 @@
PlatformPageClient platformPageClient() const final { return 0; }
void contentsSizeChanged(Frame&, const IntSize&) const final { }
- void scrollbarsModeDidChange() const final { }
void mouseDidMoveOverElement(const HitTestResult&, unsigned) final { }
void setToolTip(const String&, TextDirection) final { }
Modified: trunk/Source/WebCore/page/Chrome.cpp (221027 => 221028)
--- trunk/Source/WebCore/page/Chrome.cpp 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebCore/page/Chrome.cpp 2017-08-22 18:19:33 UTC (rev 221028)
@@ -137,11 +137,6 @@
m_client.scrollRectIntoView(rect);
}
-void Chrome::scrollbarsModeDidChange() const
-{
- m_client.scrollbarsModeDidChange();
-}
-
void Chrome::setWindowRect(const FloatRect& rect) const
{
m_client.setWindowRect(rect);
Modified: trunk/Source/WebCore/page/Chrome.h (221027 => 221028)
--- trunk/Source/WebCore/page/Chrome.h 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebCore/page/Chrome.h 2017-08-22 18:19:33 UTC (rev 221028)
@@ -81,7 +81,6 @@
IntRect rootViewToAccessibilityScreen(const IntRect&) const override;
#endif
PlatformPageClient platformPageClient() const override;
- void scrollbarsModeDidChange() const override;
void setCursor(const Cursor&) override;
void setCursorHiddenUntilMouseMoves(bool) override;
Modified: trunk/Source/WebCore/page/ChromeClient.h (221027 => 221028)
--- trunk/Source/WebCore/page/ChromeClient.h 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebCore/page/ChromeClient.h 2017-08-22 18:19:33 UTC (rev 221028)
@@ -178,7 +178,6 @@
#endif
virtual PlatformPageClient platformPageClient() const = 0;
- virtual void scrollbarsModeDidChange() const = 0;
#if ENABLE(CURSOR_SUPPORT)
virtual void setCursor(const Cursor&) = 0;
Modified: trunk/Source/WebCore/platform/HostWindow.h (221027 => 221028)
--- trunk/Source/WebCore/platform/HostWindow.h 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebCore/platform/HostWindow.h 2017-08-22 18:19:33 UTC (rev 221028)
@@ -66,9 +66,6 @@
// Method for retrieving the native client of the page.
virtual PlatformPageClient platformPageClient() const = 0;
- // To notify WebKit of scrollbar mode changes.
- virtual void scrollbarsModeDidChange() const = 0;
-
// Request that the cursor change.
virtual void setCursor(const Cursor&) = 0;
Modified: trunk/Source/WebKit/ChangeLog (221027 => 221028)
--- trunk/Source/WebKit/ChangeLog 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebKit/ChangeLog 2017-08-22 18:19:33 UTC (rev 221028)
@@ -1,3 +1,14 @@
+2017-08-22 Alex Christensen <[email protected]>
+
+ Remove ChromeClient::scrollbarsModeDidChange
+ https://bugs.webkit.org/show_bug.cgi?id=175805
+
+ Reviewed by Daniel Bates.
+
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::scrollbarsModeDidChange const): Deleted.
+ * WebProcess/WebCoreSupport/WebChromeClient.h:
+
2017-08-22 Chris Dumez <[email protected]>
Add sanity check for source origin in WebLoaderStrategy::startPingLoad()
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp (221027 => 221028)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp 2017-08-22 18:19:33 UTC (rev 221028)
@@ -640,11 +640,6 @@
#endif // ENABLE(NETSCAPE_PLUGIN_API)
}
-void WebChromeClient::scrollbarsModeDidChange() const
-{
- notImplemented();
-}
-
void WebChromeClient::mouseDidMoveOverElement(const HitTestResult& hitTestResult, unsigned modifierFlags)
{
RefPtr<API::Object> userData;
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h (221027 => 221028)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h 2017-08-22 18:19:33 UTC (rev 221028)
@@ -124,7 +124,6 @@
bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
- void scrollbarsModeDidChange() const final;
void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;
void setToolTip(const String&, WebCore::TextDirection) final;
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (221027 => 221028)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2017-08-22 18:19:33 UTC (rev 221028)
@@ -1,5 +1,14 @@
2017-08-22 Alex Christensen <[email protected]>
+ Remove ChromeClient::scrollbarsModeDidChange
+ https://bugs.webkit.org/show_bug.cgi?id=175805
+
+ Reviewed by Daniel Bates.
+
+ * WebCoreSupport/WebChromeClient.h:
+
+2017-08-22 Alex Christensen <[email protected]>
+
Remove ChromeClient::hasOpenedPopup
https://bugs.webkit.org/show_bug.cgi?id=175804
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h (221027 => 221028)
--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h 2017-08-22 18:19:33 UTC (rev 221028)
@@ -110,7 +110,6 @@
void setStatusbarText(const String&) override;
- void scrollbarsModeDidChange() const final { }
bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (221027 => 221028)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2017-08-22 18:19:33 UTC (rev 221028)
@@ -1,5 +1,14 @@
2017-08-22 Alex Christensen <[email protected]>
+ Remove ChromeClient::scrollbarsModeDidChange
+ https://bugs.webkit.org/show_bug.cgi?id=175805
+
+ Reviewed by Daniel Bates.
+
+ * WebCoreSupport/WebChromeClient.h:
+
+2017-08-22 Alex Christensen <[email protected]>
+
Remove ChromeClient::hasOpenedPopup
https://bugs.webkit.org/show_bug.cgi?id=175804
Modified: trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h (221027 => 221028)
--- trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h 2017-08-22 18:16:39 UTC (rev 221027)
+++ trunk/Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h 2017-08-22 18:19:33 UTC (rev 221028)
@@ -101,7 +101,6 @@
PlatformPageClient platformPageClient() const final;
void contentsSizeChanged(WebCore::Frame&, const WebCore::IntSize&) const final;
- void scrollbarsModeDidChange() const final { }
void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;
bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
