Title: [100030] trunk
- Revision
- 100030
- Author
- da...@apple.com
- Date
- 2011-11-11 14:51:58 -0800 (Fri, 11 Nov 2011)
Log Message
Remove all releaseRef implementations except for RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=71423
Reviewed by Julien Chaffraix.
Source/_javascript_Core:
* API/JSRetainPtr.h: Removed releaseRef.
* wtf/PassRefPtr.h: Removed releaseRef.
Source/WebCore:
* platform/win/COMPtr.h: Removed releaseRef.
Tools:
* DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSRetainPtr.h (100029 => 100030)
--- trunk/Source/_javascript_Core/API/JSRetainPtr.h 2011-11-11 22:50:09 UTC (rev 100029)
+++ trunk/Source/_javascript_Core/API/JSRetainPtr.h 2011-11-11 22:51:58 UTC (rev 100030)
@@ -71,9 +71,6 @@
void swap(JSRetainPtr&);
- // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
- T releaseRef() { return leakRef(); }
-
private:
T m_ptr;
};
Modified: trunk/Source/_javascript_Core/ChangeLog (100029 => 100030)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-11 22:50:09 UTC (rev 100029)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-11 22:51:58 UTC (rev 100030)
@@ -1,5 +1,15 @@
2011-11-11 Darin Adler <da...@apple.com>
+ Remove all releaseRef implementations except for RetainPtr
+ https://bugs.webkit.org/show_bug.cgi?id=71423
+
+ Reviewed by Julien Chaffraix.
+
+ * API/JSRetainPtr.h: Removed releaseRef.
+ * wtf/PassRefPtr.h: Removed releaseRef.
+
+2011-11-11 Darin Adler <da...@apple.com>
+
* _javascript_Core.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.
Modified: trunk/Source/_javascript_Core/wtf/PassRefPtr.h (100029 => 100030)
--- trunk/Source/_javascript_Core/wtf/PassRefPtr.h 2011-11-11 22:50:09 UTC (rev 100029)
+++ trunk/Source/_javascript_Core/wtf/PassRefPtr.h 2011-11-11 22:51:58 UTC (rev 100030)
@@ -92,9 +92,6 @@
friend PassRefPtr adoptRef<T>(T*);
- // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
- T* releaseRef() const WARN_UNUSED_RETURN { return leakRef(); }
-
private:
// adopting constructor
PassRefPtr(T* ptr, bool) : m_ptr(ptr) { }
@@ -155,9 +152,6 @@
NonNullPassRefPtr& operator=(const NonNullPassRefPtr&) { COMPILE_ASSERT(!sizeof(T*), NonNullPassRefPtr_should_never_be_assigned_to); return *this; }
- // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
- T* releaseRef() const WARN_UNUSED_RETURN { return leakRef(); }
-
private:
mutable T* m_ptr;
};
Modified: trunk/Source/WebCore/ChangeLog (100029 => 100030)
--- trunk/Source/WebCore/ChangeLog 2011-11-11 22:50:09 UTC (rev 100029)
+++ trunk/Source/WebCore/ChangeLog 2011-11-11 22:51:58 UTC (rev 100030)
@@ -1,5 +1,14 @@
2011-11-11 Darin Adler <da...@apple.com>
+ Remove all releaseRef implementations except for RetainPtr
+ https://bugs.webkit.org/show_bug.cgi?id=71423
+
+ Reviewed by Julien Chaffraix.
+
+ * platform/win/COMPtr.h: Removed releaseRef.
+
+2011-11-11 Darin Adler <da...@apple.com>
+
* WebCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.
Modified: trunk/Source/WebCore/platform/win/COMPtr.h (100029 => 100030)
--- trunk/Source/WebCore/platform/win/COMPtr.h 2011-11-11 22:50:09 UTC (rev 100029)
+++ trunk/Source/WebCore/platform/win/COMPtr.h 2011-11-11 22:51:58 UTC (rev 100030)
@@ -93,9 +93,6 @@
template<typename U> HRESULT copyRefTo(U**);
void adoptRef(T*);
- // FIXME: Remove releaseRef once we change all callers to call leakRef instead.
- T* releaseRef() { return leakRef(); }
-
private:
static T* copyQueryInterfaceRef(IUnknown*);
static T* createInstance(const IID& clsid);
Modified: trunk/Tools/ChangeLog (100029 => 100030)
--- trunk/Tools/ChangeLog 2011-11-11 22:50:09 UTC (rev 100029)
+++ trunk/Tools/ChangeLog 2011-11-11 22:51:58 UTC (rev 100030)
@@ -1,3 +1,13 @@
+2011-11-11 Darin Adler <da...@apple.com>
+
+ Remove all releaseRef implementations except for RetainPtr
+ https://bugs.webkit.org/show_bug.cgi?id=71423
+
+ Reviewed by Julien Chaffraix.
+
+ * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
+ (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
+
2011-11-11 Ryosuke Niwa <rn...@webkit.org>
Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
Modified: trunk/Tools/DumpRenderTree/cf/WebArchiveDumpSupport.cpp (100029 => 100030)
--- trunk/Tools/DumpRenderTree/cf/WebArchiveDumpSupport.cpp 2011-11-11 22:50:09 UTC (rev 100029)
+++ trunk/Tools/DumpRenderTree/cf/WebArchiveDumpSupport.cpp 2011-11-11 22:51:58 UTC (rev 100030)
@@ -226,5 +226,5 @@
// Replace "Apple Computer" with "Apple" in the DTD declaration.
CFStringFindAndReplace(string.get(), CFSTR("-//Apple Computer//"), CFSTR("-//Apple//"), CFRangeMake(0, CFStringGetLength(string.get())), 0);
- return string.releaseRef();
+ return string.leakRef();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
