Title: [221114] trunk/PerformanceTests
- Revision
- 221114
- Author
- [email protected]
- Date
- 2017-08-23 16:04:13 -0700 (Wed, 23 Aug 2017)
Log Message
Speedometer 2.0: Add the capability to run a specific suite
https://bugs.webkit.org/show_bug.cgi?id=175908
Reviewed by Saam Barati.
Added ?suite=X query parameter to specify a specific suite (e.g. React-TodoMVC) to run.
* Speedometer/resources/main.js:
(enableOneSuite): Added.
(startBenchmark): Return true if the benchmark actually had started running.
(startTest): Don't transition to the "running" state if the benchmark failed to start (e.g. no tests to run).
Modified Paths
Diff
Modified: trunk/PerformanceTests/ChangeLog (221113 => 221114)
--- trunk/PerformanceTests/ChangeLog 2017-08-23 22:53:14 UTC (rev 221113)
+++ trunk/PerformanceTests/ChangeLog 2017-08-23 23:04:13 UTC (rev 221114)
@@ -1,5 +1,19 @@
2017-08-23 Ryosuke Niwa <[email protected]>
+ Speedometer 2.0: Add the capability to run a specific suite
+ https://bugs.webkit.org/show_bug.cgi?id=175908
+
+ Reviewed by Saam Barati.
+
+ Added ?suite=X query parameter to specify a specific suite (e.g. React-TodoMVC) to run.
+
+ * Speedometer/resources/main.js:
+ (enableOneSuite): Added.
+ (startBenchmark): Return true if the benchmark actually had started running.
+ (startTest): Don't transition to the "running" state if the benchmark failed to start (e.g. no tests to run).
+
+2017-08-23 Ryosuke Niwa <[email protected]>
+
Speedometer 2.0: Async time is not always capturing layout time
https://bugs.webkit.org/show_bug.cgi?id=175871
Modified: trunk/PerformanceTests/Speedometer/resources/main.js (221113 => 221114)
--- trunk/PerformanceTests/Speedometer/resources/main.js 2017-08-23 22:53:14 UTC (rev 221113)
+++ trunk/PerformanceTests/Speedometer/resources/main.js 2017-08-23 23:04:13 UTC (rev 221114)
@@ -149,7 +149,24 @@
}
}
+function enableOneSuite(suites, suiteToEnable)
+{
+ suiteToEnable = suiteToEnable.toLowerCase();
+ var found = false;
+ for (var i = 0; i < suites.length; i++) {
+ var currentSuite = suites[i];
+ if (currentSuite.name.toLowerCase() == suiteToEnable) {
+ currentSuite.disabled = false;
+ found = true;
+ } else
+ currentSuite.disabled = true;
+ }
+ return found;
+}
+
function startBenchmark() {
+ var enabledSuites = Suites.filter(function (suite) { return !suite.disabled; });
+
if (location.search.length > 1) {
var parts = location.search.substring(1).split('&');
for (var i = 0; i < parts.length; i++) {
@@ -170,16 +187,24 @@
else
console.error('Invalid iteration count: ' + value);
break;
+ case 'suite':
+ if (!enableOneSuite(Suites, value)) {
+ alert('No tests to run');
+ return false;
+ }
+ break;
}
}
}
- var enabledSuites = Suites.filter(function (suite) { return !suite.disabled });
+ var enabledSuites = Suites.filter(function (suite) { return !suite.disabled; });
var totalSubtestCount = enabledSuites.reduce(function (testsCount, suite) { return testsCount + suite.tests.length; }, 0);
benchmarkClient.testsCount = benchmarkClient.iterationCount * totalSubtestCount;
benchmarkClient.suitesCount = enabledSuites.length;
var runner = new BenchmarkRunner(Suites, benchmarkClient);
runner.runMultipleIterations(benchmarkClient.iterationCount);
+
+ return true;
}
function computeScore(time) {
@@ -205,8 +230,8 @@
}
function startTest() {
- showSection('running');
- startBenchmark();
+ if (startBenchmark())
+ showSection('running');
}
function showResultsSummary() {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
