Title: [221118] trunk/PerformanceTests
- Revision
- 221118
- Author
- [email protected]
- Date
- 2017-08-23 16:54:40 -0700 (Wed, 23 Aug 2017)
Log Message
Speedometer 2.0: Add the capability to run a specific suite
https://bugs.webkit.org/show_bug.cgi?id=175908
Address Joe's review comments.
* Speedometer/resources/main.js:
(startBenchmark):
Modified Paths
Diff
Modified: trunk/PerformanceTests/ChangeLog (221117 => 221118)
--- trunk/PerformanceTests/ChangeLog 2017-08-23 23:53:42 UTC (rev 221117)
+++ trunk/PerformanceTests/ChangeLog 2017-08-23 23:54:40 UTC (rev 221118)
@@ -3,6 +3,16 @@
Speedometer 2.0: Add the capability to run a specific suite
https://bugs.webkit.org/show_bug.cgi?id=175908
+ Address Joe's review comments.
+
+ * Speedometer/resources/main.js:
+ (startBenchmark):
+
+2017-08-23 Ryosuke Niwa <[email protected]>
+
+ Speedometer 2.0: Add the capability to run a specific suite
+ https://bugs.webkit.org/show_bug.cgi?id=175908
+
Reviewed by Saam Barati.
Added ?suite=X query parameter to specify a specific suite (e.g. React-TodoMVC) to run.
Modified: trunk/PerformanceTests/Speedometer/resources/main.js (221117 => 221118)
--- trunk/PerformanceTests/Speedometer/resources/main.js 2017-08-23 23:53:42 UTC (rev 221117)
+++ trunk/PerformanceTests/Speedometer/resources/main.js 2017-08-23 23:54:40 UTC (rev 221118)
@@ -165,8 +165,6 @@
}
function startBenchmark() {
- var enabledSuites = Suites.filter(function (suite) { return !suite.disabled; });
-
if (location.search.length > 1) {
var parts = location.search.substring(1).split('&');
for (var i = 0; i < parts.length; i++) {
@@ -189,7 +187,7 @@
break;
case 'suite':
if (!enableOneSuite(Suites, value)) {
- alert('No tests to run');
+ alert('Suite "' + value + '" does not exist. No tests to run.');
return false;
}
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
